From f0ef06ebe1581e928cef26aed23379e1bb715e41 Mon Sep 17 00:00:00 2001
From: snipe <snipe@snipe.net>
Date: Fri, 27 Mar 2020 15:35:29 -0700
Subject: [PATCH] Added more alt tags

---
 app/Presenters/AssetModelPresenter.php       |  2 +-
 app/Presenters/AssetPresenter.php            |  4 +++-
 resources/views/accessories/edit.blade.php   |  2 +-
 resources/views/account/profile.blade.php    |  2 +-
 resources/views/auth/login.blade.php         | 13 ++++++++-----
 resources/views/hardware/requested.blade.php |  4 ++--
 resources/views/layouts/basic.blade.php      |  3 ++-
 resources/views/users/view.blade.php         |  4 ++--
 8 files changed, 20 insertions(+), 14 deletions(-)

diff --git a/app/Presenters/AssetModelPresenter.php b/app/Presenters/AssetModelPresenter.php
index f23f22b600..0e4b7dd350 100644
--- a/app/Presenters/AssetModelPresenter.php
+++ b/app/Presenters/AssetModelPresenter.php
@@ -67,7 +67,7 @@ class AssetModelPresenter extends Presenter
     public function imageUrl()
     {
         if (!empty($this->image)) {
-            return '<img src="' . url('/') . '/uploads/models/' . $this->image . '" height=50 width=50>';
+            return '<img src="' . url('/') . '/uploads/models/' . $this->image . '" alt="'.$this->name.'" height="50" width="50">';
         }
         return '';
     }
diff --git a/app/Presenters/AssetPresenter.php b/app/Presenters/AssetPresenter.php
index 88d9d26dba..86a333e594 100644
--- a/app/Presenters/AssetPresenter.php
+++ b/app/Presenters/AssetPresenter.php
@@ -324,12 +324,14 @@ class AssetPresenter extends Presenter
         $imagePath = '';
         if ($this->image && !empty($this->image)) {
             $imagePath = $this->image;
+            $imageAlt = $this->name;
         } elseif ($this->model && !empty($this->model->image)) {
             $imagePath = $this->model->image;
+            $imageAlt = $this->model->name;
         }
         $url = config('app.url');
         if (!empty($imagePath)) {
-            $imagePath = "<img src='{$url}/uploads/assets/{$imagePath}' height=50 width=50>";
+            $imagePath = '<img src="'.$url.'/uploads/assets/'.$imagePath.' height="50" width="50" alt="'.$imageAlt.'">';
         }
         return $imagePath;
     }
diff --git a/resources/views/accessories/edit.blade.php b/resources/views/accessories/edit.blade.php
index 874afa2d47..bacb755b77 100755
--- a/resources/views/accessories/edit.blade.php
+++ b/resources/views/accessories/edit.blade.php
@@ -29,7 +29,7 @@
         <label class="col-md-3 control-label" for="image_delete">{{ trans('general.image_delete') }}</label>
         <div class="col-md-5">
             {{ Form::checkbox('image_delete') }}
-            <img src="{{ url('/') }}/uploads/accessories/{{ $item->image }}" />
+            <img src="{{ url('/') }}/uploads/accessories/{{ $item->image }}" alt="{{ $item->name }}">
             {!! $errors->first('image_delete', '<span class="alert-msg">:message</span>') !!}
         </div>
     </div>
diff --git a/resources/views/account/profile.blade.php b/resources/views/account/profile.blade.php
index 49e29b05a6..e26daa6bf2 100755
--- a/resources/views/account/profile.blade.php
+++ b/resources/views/account/profile.blade.php
@@ -87,7 +87,7 @@
             <input class="form-control" type="text" name="gravatar" id="gravatar" value="{{ Input::old('gravatar', $user->gravatar) }}" />
             {!! $errors->first('gravatar', '<span class="alert-msg"><i class="fa fa-times"></i> :message</span>') !!}
             <p>
-              <img src="//secure.gravatar.com/avatar/{{ md5(strtolower(trim($user->gravatar))) }}" width="30" height="30" />
+              <img src="//secure.gravatar.com/avatar/{{ md5(strtolower(trim($user->gravatar))) }}" width="30" height="30" alt="{{ $user->present()->fullName() }}">
               <a href="http://gravatar.com"><small>Change your avatar at Gravatar.com</small></a>.
             </p>
           </div>
diff --git a/resources/views/auth/login.blade.php b/resources/views/auth/login.blade.php
index 483939e916..d06f332fc1 100755
--- a/resources/views/auth/login.blade.php
+++ b/resources/views/auth/login.blade.php
@@ -8,8 +8,8 @@
         <input type="hidden" name="_token" value="{{ csrf_token() }}" />
 
         <!-- this is a hack to prevent Chrome from trying to autocomplete fields -->
-        <input type="text" name="prevent_autofill" id="prevent_autofill" value="" style="display:none;" />
-        <input type="password" name="password_fake" id="password_fake" value="" style="display:none;" />
+        <input type="text" name="prevent_autofill" id="prevent_autofill" value="" style="display:none;" aria-hidden="true">
+        <input type="password" name="password_fake" id="password_fake" value="" style="display:none;" aria-hidden="true">
 
         <div class="container">
             <div class="row">
@@ -18,7 +18,7 @@
 
                     <div class="box login-box">
                         <div class="box-header">
-                            <h3 class="box-title"> {{ trans('auth/general.login_prompt')  }}</h3>
+                            <h1 class="box-title"> {{ trans('auth/general.login_prompt')  }}</h1>
                         </div>
 
 
@@ -41,12 +41,15 @@
 
 
                                     <fieldset>
+                                        <legend class="sr-only">Personalia:</legend>
                                         <div class="form-group{{ $errors->has('username') ? ' has-error' : '' }}">
-                                            <input class="form-control" placeholder="{{ trans('admin/users/table.username')  }}" name="username" type="text"  autocomplete="off" autofocus>
+                                            <label for="username">{{ trans('admin/users/table.username')  }}</label>
+                                            <input class="form-control" placeholder="{{ trans('admin/users/table.username')  }}" name="username" type="text" id="username" autocomplete="off" autofocus>
                                             {!! $errors->first('username', '<span class="alert-msg"><i class="fa fa-times"></i> :message</span>') !!}
                                         </div>
                                         <div class="form-group{{ $errors->has('password') ? ' has-error' : '' }}">
-                                            <input class="form-control" placeholder="{{ trans('admin/users/table.password')  }}" name="password" type="password" autocomplete="off">
+                                            <label for="password">{{ trans('admin/users/table.password')  }}</label>
+                                            <input class="form-control" placeholder="{{ trans('admin/users/table.password')  }}" name="password" type="password" id="password" autocomplete="off">
                                             {!! $errors->first('password', '<span class="alert-msg"><i class="fa fa-times"></i> :message</span>') !!}
                                         </div>
                                         <div class="checkbox">
diff --git a/resources/views/hardware/requested.blade.php b/resources/views/hardware/requested.blade.php
index 2bfff4c80c..11494fa5b4 100644
--- a/resources/views/hardware/requested.blade.php
+++ b/resources/views/hardware/requested.blade.php
@@ -64,9 +64,9 @@
                             {{ csrf_field() }}
                             <td>
                                 @if (($request->itemType() == "asset") && ($request->requestable))
-                                    <a href="{{ $request->requestable->getImageUrl() }}" data-toggle="lightbox" data-type="image"><img src="{{ $request->requestable->getImageUrl() }}" style="max-height: {{ $snipeSettings->thumbnail_max_h }}px; width: auto;" class="img-responsive"></a>
+                                    <a href="{{ $request->requestable->getImageUrl() }}" data-toggle="lightbox" data-type="image"><img src="{{ $request->requestable->getImageUrl() }}" style="max-height: {{ $snipeSettings->thumbnail_max_h }}px; width: auto;" class="img-responsive" alt="{{ $request->requestable->name }}"></a>
                                 @elseif (($request->itemType() == "asset_model") && ($request->requestable))
-                                        <a href="{{ url('/') }}/uploads/models/{{ $request->requestable->image }}" data-toggle="lightbox" data-type="image"><img src="{{ url('/') }}/uploads/models/{{ $request->requestable->image }}" style="max-height: {{ $snipeSettings->thumbnail_max_h }}px; width: auto;" class="img-responsive"></a>
+                                        <a href="{{ url('/') }}/uploads/models/{{ $request->requestable->image }}" data-toggle="lightbox" data-type="image"><img src="{{ url('/') }}/uploads/models/{{ $request->requestable->image }}" style="max-height: {{ $snipeSettings->thumbnail_max_h }}px; width: auto;" class="img-responsive" alt="{{ $request->requestable->name }}"></a>
                                 @endif
 
 
diff --git a/resources/views/layouts/basic.blade.php b/resources/views/layouts/basic.blade.php
index c23ce6542a..f3ee0d9fa2 100644
--- a/resources/views/layouts/basic.blade.php
+++ b/resources/views/layouts/basic.blade.php
@@ -33,6 +33,7 @@
         border-color: {{ $snipeSettings->header_color }};
         }
 
+
         </style>
 
     @endif
@@ -49,7 +50,7 @@
 
     @if (($snipeSettings) && ($snipeSettings->logo!=''))
         <center>
-            <img id="login-logo" src="{{ url('/') }}/uploads/{{ $snipeSettings->logo }}">
+            <img id="login-logo" src="{{ url('/') }}/uploads/{{ $snipeSettings->logo }}" alt="{{ ($snipeSettings) && ($snipeSettings->site_name) ? $snipeSettings->site_name : 'Snipe-IT' }} logo">
         </center>
     @endif
   <!-- Content -->
diff --git a/resources/views/users/view.blade.php b/resources/views/users/view.blade.php
index 7ca003797e..15a3b05395 100755
--- a/resources/views/users/view.blade.php
+++ b/resources/views/users/view.blade.php
@@ -116,9 +116,9 @@
             @endif
             <div class="col-md-2 text-center">
               @if ($user->avatar)
-                <img src="/uploads/avatars/{{ $user->avatar }}" class="avatar img-thumbnail hidden-print">
+                <img src="/uploads/avatars/{{ $user->avatar }}" class="avatar img-thumbnail hidden-print" alt="{{ $user->present()->fullName() }}">
               @else
-                <img src="{{ $user->present()->gravatar() }}" class="avatar img-circle hidden-print">
+                <img src="{{ $user->present()->gravatar() }}" class="avatar img-circle hidden-print" alt="{{ $user->present()->fullName() }}">
               @endif
             </div>