DRCIT/snipe-it
1
0
Fork 0
mirror of https://github.com/snipe/snipe-it.git synced 2025-01-12 14:27:33 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Implement tests included two currently failing tests

Browse source
This commit is contained in:
Marcus Moore 2024-01-29 16:48:40 -08:00
parent e5d3df7d24
commit f1ab8253f0
No known key found for this signature in database
2 changed files with 41 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

53
tests/Feature/Api/Accessories/AccessoryCheckoutTest.php
View file

@ -15,30 +15,44 @@ class AccessoryCheckoutTest extends TestCase
public function testCheckingOutAccessoryRequiresCorrectPermission() public function testCheckingOutAccessoryRequiresCorrectPermission()
{ {
$this->markTestIncomplete(); $this->actingAsForApi(User::factory()->create())
->postJson(route('api.accessories.checkout', Accessory::factory()->create()))
->assertForbidden();
} }
public function testValidation() public function testValidation()
{ {
$this->markTestIncomplete(); $this->actingAsForApi(User::factory()->checkoutAccessories()->create())
->postJson(route('api.accessories.checkout', Accessory::factory()->create()), [
// missing assigned_to
])
->assertStatusMessageIs('error');
} }
public function testAccessoryMustBeAvailableWhenCheckingOut() public function testAccessoryMustBeAvailableWhenCheckingOut()
{ {
$this->markTestIncomplete(); $this->actingAsForApi(User::factory()->checkoutAccessories()->create())
->postJson(route('api.accessories.checkout', Accessory::factory()->withoutItemsRemaining()->create()), [
'assigned_to' => User::factory()->create()->id,
])
->assertStatusMessageIs('error');
} }
public function testAccessoryCanBeCheckedOut() public function testAccessoryCanBeCheckedOut()
{ {
$this->markTestIncomplete(); $accessory = Accessory::factory()->create();
$user = User::factory()->create();
$this->actingAsForApi(User::factory()->checkoutAccessories()->create())
->postJson(route('api.accessories.checkout', $accessory), [
'assigned_to' => $user->id,
]);
$this->assertTrue($accessory->users->contains($user));
} }
public function testUserSentNotificationUponCheckout() public function testUserSentNotificationUponCheckout()
{ {
$this->markTestIncomplete();
$this->withoutExceptionHandling();
Notification::fake(); Notification::fake();
$accessory = Accessory::factory()->requiringAcceptance()->create(); $accessory = Accessory::factory()->requiringAcceptance()->create();
@ -54,11 +68,24 @@ class AccessoryCheckoutTest extends TestCase
public function testActionLogCreatedUponCheckout() public function testActionLogCreatedUponCheckout()
{ {
$this->markTestIncomplete(); $accessory = Accessory::factory()->create();
} $actor = User::factory()->checkoutAccessories()->create();
$user = User::factory()->create();
public function testUserSentEulaUponCheckoutIfAcceptanceRequired() $this->actingAsForApi($actor)
{ ->postJson(route('api.accessories.checkout', $accessory), [
$this->markTestIncomplete(); 'assigned_to' => $user->id,
'note' => 'oh hi there',
]);
$this->assertDatabaseHas('action_logs', [
'action_type' => 'checkout',
'target_id' => $user->id,
'target_type' => User::class,
'item_id' => $accessory->id,
'item_type' => Accessory::class,
'user_id' => $actor->id,
'note' => 'oh hi there',
]);
} }
} }

5
tests/Feature/Checkouts/AccessoryCheckoutTest.php
View file

@ -22,10 +22,8 @@ class AccessoryCheckoutTest extends TestCase
public function testValidation() public function testValidation()
{ {
$accessory = Accessory::factory()->create();
$this->actingAs(User::factory()->checkoutAccessories()->create()) $this->actingAs(User::factory()->checkoutAccessories()->create())
->post(route('accessories.checkout.store', $accessory), [ ->post(route('accessories.checkout.store', Accessory::factory()->create()), [
// missing assigned_to // missing assigned_to
]) ])
->assertSessionHas('error'); ->assertSessionHas('error');
@ -43,7 +41,6 @@ class AccessoryCheckoutTest extends TestCase
public function testAccessoryCanBeCheckedOut() public function testAccessoryCanBeCheckedOut()
{ {
$accessory = Accessory::factory()->create(); $accessory = Accessory::factory()->create();
$user = User::factory()->create(); $user = User::factory()->create();
$this->actingAs(User::factory()->checkoutAccessories()->create()) $this->actingAs(User::factory()->checkoutAccessories()->create())