DRCIT/snipe-it
1
0
Fork 0
mirror of https://github.com/snipe/snipe-it.git synced 2025-03-05 20:52:15 -08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Removed else condition on custom fields API for code quality

Browse source
This commit is contained in:
snipe 2017-10-26 22:33:40 -07:00
parent 00d910ddbc
commit f2499fc7d2
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
app/Http/Controllers/Api/CustomFieldsController.php
View file

@ -57,15 +57,15 @@ class CustomFieldsController extends Controller
*/ */
public function destroy($field_id) public function destroy($field_id)
{ {
$field = CustomField::find($field_id); $field = CustomField::findOrFail($field_id);
if ($field->fieldset->count() >0) { if ($field->fieldset->count() >0) {
return response()->json(Helper::formatStandardApiResponse('error', null, 'Field is in use.')); return response()->json(Helper::formatStandardApiResponse('error', null, 'Field is in use.'));
} else {
$field->delete();
return response()->json(Helper::formatStandardApiResponse('success', null, trans('admin/custom_fields/message.field.delete.success')));
} }
$field->delete();
return response()->json(Helper::formatStandardApiResponse('success', null, trans('admin/custom_fields/message.field.delete.success')));
} }
} }