DRCIT/snipe-it
1
0
Fork 0
mirror of https://github.com/snipe/snipe-it.git synced 2025-02-21 03:15:45 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fixed notification tests

Browse source 
Signed-off-by: snipe <snipe@snipe.net>
This commit is contained in:
snipe 2021-12-02 20:01:03 -08:00
parent 0104f35f31
commit f334bf1058
3 changed files with 23 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/Listeners/CheckoutableListener.php
View file

@ -135,7 +135,7 @@ class CheckoutableListener
/** /**
* Notify Admin users if the settings is activated * Notify Admin users if the settings is activated
*/ */
if (Setting::getSettings()->admin_cc_email != '') { if ((Setting::getSettings()) && (Setting::getSettings()->admin_cc_email != '')) {
$notifiables->push(new AdminRecipient()); $notifiables->push(new AdminRecipient());
} }

2
app/Notifications/CheckoutAssetNotification.php
View file

@ -53,7 +53,7 @@ class CheckoutAssetNotification extends Notification
{ {
$notifyBy = []; $notifyBy = [];
if (Setting::getSettings()->slack_endpoint != '') { if ((Setting::getSettings()) && (Setting::getSettings()->slack_endpoint != '')) {
\Log::debug('use slack'); \Log::debug('use slack');
$notifyBy[] = 'slack'; $notifyBy[] = 'slack';
} }

29
tests/Unit/NotificationTest.php
View file

@ -2,10 +2,14 @@
namespace Tests\Unit; namespace Tests\Unit;
use App\Models\User; use App\Models\User;
use App\Models\Asset;
use App\Models\AssetModel;
use App\Models\Category;
use Carbon\Carbon;
use App\Notifications\CheckoutAssetNotification; use App\Notifications\CheckoutAssetNotification;
use Illuminate\Support\Facades\Notification; use Illuminate\Support\Facades\Notification;
use Tests\Unit\BaseTest; use Tests\Unit\BaseTest;
use Auth;
class NotificationTest extends BaseTest class NotificationTest extends BaseTest
{ {
@ -16,15 +20,24 @@ class NotificationTest extends BaseTest
public function testAUserIsEmailedIfTheyCheckoutAnAssetWithEULA() public function testAUserIsEmailedIfTheyCheckoutAnAssetWithEULA()
{ {
$admin = User::factory()->superuser()->create();
Auth::login($admin);
$cat = $this->createValidCategory('asset-laptop-category', ['require_acceptance' => true]);
$model = $this->createValidAssetModel('mbp-13-model', ['category_id' => $cat->id]);
$asset = $this->createValidAsset(['model_id' => $model->id]);
$user = $this->createValidUser();
$user = User::factory()->create();
$asset = Asset::factory()
->create(
[
'model_id' => AssetModel::factory()
->create(
[
'category_id' => Category::factory()->assetLaptopCategory()->id
]
)->id,
'warranty_months' => 24,
'purchase_date' => Carbon::createFromDate(2017, 1, 1)->hour(0)->minute(0)->second(0)
]);
//dd($asset);
Notification::fake(); Notification::fake();
$asset->checkOut($user, 1); $asset->checkOut($user, $asset->id);
Notification::assertSentTo($user, CheckoutAssetNotification::class); Notification::assertSentTo($user, CheckoutAssetNotification::class);
} }
} }