DRCIT/snipe-it
1
0
Fork 0
mirror of https://github.com/snipe/snipe-it.git synced 2025-03-05 20:52:15 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Always run validation on checkin

Browse source
This commit is contained in:
Marcus Moore 2024-11-20 12:25:06 -08:00
parent da4c877ed8
commit f932a4fc76
No known key found for this signature in database
2 changed files with 7 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
app/Http/Controllers/Api/ComponentsController.php
View file

@ -317,14 +317,12 @@ class ComponentsController extends Controller
$max_to_checkin = $component_assets->assigned_qty; $max_to_checkin = $component_assets->assigned_qty;
if ($max_to_checkin > 1) { $validator = Validator::make($request->all(), [
$validator = Validator::make($request->all(), [ "checkin_qty" => "required|numeric|between:1,$max_to_checkin"
"checkin_qty" => "required|numeric|between:1,$max_to_checkin" ]);
]);
if ($validator->fails()) { if ($validator->fails()) {
return response()->json(Helper::formatStandardApiResponse('error', null, 'Checkin quantity must be between 1 and '.$max_to_checkin)); return response()->json(Helper::formatStandardApiResponse('error', null, 'Checkin quantity must be between 1 and ' . $max_to_checkin));
}
} }
// Validation passed, so let's figure out what we have to do here. // Validation passed, so let's figure out what we have to do here.

2
tests/Feature/Checkins/Api/ComponentCheckinTest.php
View file

@ -52,7 +52,7 @@ class ComponentCheckinTest extends TestCase implements TestsFullMultipleCompanie
$component = Component::factory()->checkedOutToAsset()->create(); $component = Component::factory()->checkedOutToAsset()->create();
$pivot = $component->assets->first()->pivot; $pivot = $component->assets->first()->pivot;
$pivot->update(['assigned_qty' => 2]); $pivot->update(['assigned_qty' => 1]);
$this->actingAsForApi(User::factory()->checkinComponents()->create()) $this->actingAsForApi(User::factory()->checkinComponents()->create())
->postJson(route('api.components.checkin', $component->assets->first()->pivot->id), [ ->postJson(route('api.components.checkin', $component->assets->first()->pivot->id), [