spencerrlongg
5e475c3558
Remove unused imports from AssetsController files.
...
Simplify the code by cleaning up unused import statements in both `AssetsController.php` and `Api/AssetsController.php`. This reduces potential confusion and helps maintain cleaner code for future development and maintenance.
2024-12-03 14:41:30 -06:00
spencerrlongg
bdf1033277
Merge remote-tracking branch 'upstream/develop' into refactor/asset-action
...
# Conflicts:
# app/Http/Controllers/Api/AssetsController.php
# app/Http/Controllers/Assets/AssetsController.php
# app/Http/Controllers/Assets/BulkAssetsController.php
# resources/lang/en-US/admin/hardware/message.php
2024-12-03 14:31:50 -06:00
spencerrlongg
16740b41e4
Simplify asset handling logic for creation and update
...
Refactor asset creation and update processes by removing redundant save checks and organizing error handling logic. Enhance success and failure feedback in the asset creation flow to improve clarity and user experience. Add support for detailed multi-success and partial failure messages to alert users of outcomes.
2024-12-03 13:50:30 -06:00
spencerrlongg
0a1aba5406
a little work for conflicts
2024-11-29 14:32:19 -06:00
spencerrlongg
09d4e0cb05
Remove unnecessary parameter and add delete asset tests
...
Removed the redundant $request parameter from the destroy method in AssetsController. Added feature tests to verify asset deletion functionality with proper permissions and ensure deletion is forbidden without permissions.
2024-11-26 14:37:45 -06:00
spencerrlongg
233656df01
Add tests for storing assets with all fields and multiple entries
...
Introduced StoreAssetTest to verify the handling of full asset records and multiple asset entries in the database. Updated StoreAssetAction and AssetsController to support next audit date validation and improved error handling.
2024-11-26 14:28:22 -06:00
spencerrlongg
705a852d45
Refactor error handling and remove redundant code
...
Refactored error handling by replacing `\Exception` with `Exception` for consistency. Removed redundant comments and unused code to improve readability and maintainability of the `StoreAssetAction` class.
2024-11-25 20:09:30 -06:00
spencerrlongg
5aa2f307cd
Remove debug dump statements
...
This commit removes various debug dump statements from BulkAssetsController and UpdateAssetAction. These changes clean up the code and improve readability by eliminating unnecessary debugging output. Maintaining clean code ensures better maintainability and performance.
2024-11-22 20:49:52 -06:00
spencerrlongg
617fe85699
Fix typos and use correct array notation in asset updates
...
Corrected spelling mistakes in test files and updated code to use the correct array notation in request validation for asset updates. This ensures better readability and consistency in the codebase while preventing potential errors related to incorrect data handling.
2024-11-20 13:11:03 -06:00
spencerrlongg
9f815996c7
tests 'n stuff
2024-11-19 14:45:54 -06:00
spencerrlongg
dd8fb6ef4a
fixed some things, made bulk progress, tests pass
2024-11-19 00:13:28 -06:00
spencerrlongg
7ab0b98ff2
var changes
2024-11-18 12:43:28 -06:00
spencerrlongg
c91dfaf9df
gui seemingly working, other good progress - api next
2024-11-14 16:54:23 -06:00
spencerrlongg
47d132703e
some more good progress on UpdateAssetAction.php
2024-11-12 18:08:29 -06:00
spencerrlongg
916c0c0394
good progress on update action
2024-11-12 14:46:56 -06:00
spencerrlongg
a57fffe696
a few fixes, tests pass
2024-11-04 13:39:42 -06:00
spencerrlongg
b00f8b5c40
a couple more tests passing
2024-10-30 19:37:51 -05:00
spencerrlongg
c0ea1fbe78
delete done
2024-10-30 15:19:34 -05:00
spencerrlongg
698434dcf8
no more base action, scaffolded update and delete
2024-10-30 13:48:14 -05:00
spencerrlongg
34886ee69a
almost wrapped up StoreAssetAction.php
2024-10-29 19:04:57 -05:00
spencerrlongg
eaa10249c2
alright, this mostly works.
2024-10-29 16:16:01 -05:00
snipe
dfc63641dc
Merge pull request #15550 from uberbrady/fix_multi_create_partial_failure
...
Crowdin Action / upload-sources-to-crowdin (push) Has been cancelled
Docker images (Alpine) / docker (push) Has been cancelled
Docker images / docker (push) Has been cancelled
Tests in MySQL / PHP ${{ matrix.php-version }} (8.1) (push) Has been cancelled
Tests in MySQL / PHP ${{ matrix.php-version }} (8.2) (push) Has been cancelled
Tests in MySQL / PHP ${{ matrix.php-version }} (8.3) (push) Has been cancelled
Tests in SQLite / PHP ${{ matrix.php-version }} (8.1.1) (push) Has been cancelled
Fix multi create partial failure (fixes: [RB-18591])
2024-10-24 11:40:50 +01:00
spencerrlongg
6e8ab3723c
bs
2024-10-23 13:56:01 -05:00
spencerrlongg
10d4c4b92e
just a little scaffolding
2024-10-23 12:55:47 -05:00
snipe
787e651778
Fixed todos with log message
...
Signed-off-by: snipe <snipe@snipe.net>
2024-10-21 16:52:21 +01:00
snipe
5823197e6f
Added checkin action on delete for checked out assets
...
Signed-off-by: snipe <snipe@snipe.net>
2024-10-01 14:29:02 +01:00
Brady Wetherington
b6340532d7
Improve the error and success messages and linking
2024-09-24 17:15:39 +01:00
Brady Wetherington
c71411465a
First pass at better-handling those annoying Rollbars we keep getting
2024-09-24 15:17:35 +01:00
snipe
bc540b6564
Requestable status not saving with manual [sc-26848]
...
Signed-off-by: snipe <snipe@snipe.net>
2024-09-20 14:02:28 +01:00
snipe
1582d81e5b
Change user_id to created_by
...
Signed-off-by: snipe <snipe@snipe.net>
2024-09-17 22:16:41 +01:00
snipe
a97530367d
Fixed tests again
...
Signed-off-by: snipe <snipe@snipe.net>
2024-09-11 17:29:22 +01:00
snipe
43250ae881
Updated tests
...
Signed-off-by: snipe <snipe@snipe.net>
2024-09-11 17:04:09 +01:00
snipe
98323185de
Null and warn if editing asset to a non-deployabe state
...
Signed-off-by: snipe <snipe@snipe.net>
2024-09-11 16:43:33 +01:00
snipe
56e31d2303
Fixed #15366 - use permission for encrypted custom fields
...
Signed-off-by: snipe <snipe@snipe.net>
2024-08-22 14:58:09 +01:00
snipe
d8038ac483
Removed status label list
...
Signed-off-by: snipe <snipe@snipe.net>
2024-08-15 10:17:08 +01:00
snipe
01c69c8f8f
Allow optional status label on quickscan checkin
...
Signed-off-by: snipe <snipe@snipe.net>
2024-08-15 10:08:48 +01:00
Florent Bervas
ad794248fe
add a warning message if asset tag not found
2024-08-05 13:54:33 +00:00
Florent Bervas
b804791ff6
feature: extend search capabilities to other assets attributes
2024-08-05 12:26:29 +00:00
snipe
037cc4d098
More tests
...
Signed-off-by: snipe <snipe@snipe.net>
2024-07-26 14:27:07 +01:00
snipe
b6d9f736e3
Pulled use session
...
Signed-off-by: snipe <snipe@snipe.net>
2024-07-26 10:41:28 +01:00
snipe
08f4fe5f35
Add status messages to redirect
...
Signed-off-by: snipe <snipe@snipe.net>
2024-07-25 22:02:34 +01:00
snipe
73a80a5fbc
Use blade component for redirect option
...
Signed-off-by: snipe <snipe@snipe.net>
2024-07-25 21:35:13 +01:00
snipe
293abbd1d0
Allow cloning of deleted assets
...
Signed-off-by: snipe <snipe@snipe.net>
2024-07-24 17:49:38 +01:00
snipe
175862d3c9
Added route param to message
...
Signed-off-by: snipe <snipe@snipe.net>
2024-07-23 16:37:01 +01:00
snipe
35160f88e0
Corrected return type
...
Signed-off-by: snipe <snipe@snipe.net>
2024-07-16 16:09:08 +01:00
snipe
bf060d43a7
Fixed typehint on assets controller
...
Signed-off-by: snipe <snipe@snipe.net>
2024-07-08 22:02:11 +01:00
snipe
9c304f238a
Merge pull request #15029 from snipe/fixes/small_docblock_fixes
...
General cleanup - Docblock fixes, adding type hinting, added tests, added asset model form validator
2024-07-08 17:43:50 +01:00
snipe
eba24b9242
Removed custom fieldsets on auditing - it’s not used
...
Signed-off-by: snipe <snipe@snipe.net>
2024-07-08 13:19:05 +01:00
snipe
96d1aea54a
More cleanup
...
Signed-off-by: snipe <snipe@snipe.net>
2024-07-05 00:54:50 +01:00
snipe
ae9085b11f
Modernize use statements, switch to auth()
...
Signed-off-by: snipe <snipe@snipe.net>
2024-07-04 20:49:22 +01:00
