Tobias Regnery
f50ccbcc49
Fix outdated comment in CompanyableTrait
...
As of commit 5800e8d
the user model uses CompanyableTrait so remove this clearly outdated comment
2024-10-17 11:07:28 +02:00
Godfrey M
9a79483375
removed namespaces from routing
2024-10-16 16:59:18 -07:00
Godfrey M
ed6034065b
removed test route
2024-10-16 16:47:36 -07:00
Godfrey M
a7754c1a7f
fixed asset checkout markdown, and notifiable variable
2024-10-16 16:46:52 -07:00
snipe
0e9b3c9119
Check for existence before trying to get the icon
...
Signed-off-by: snipe <snipe@snipe.net>
2024-10-17 00:27:39 +01:00
snipe
4933aa5784
Add StorageHelper to app config
...
Signed-off-by: snipe <snipe@snipe.net>
2024-10-17 00:27:04 +01:00
snipe
d67addc69e
Removed filetype column - it’s dumb
...
Signed-off-by: snipe <snipe@snipe.net>
2024-10-17 00:21:43 +01:00
snipe
02c80ff18a
Added comment
...
Signed-off-by: snipe <snipe@snipe.net>
2024-10-17 00:18:40 +01:00
snipe
c01190fac2
Conditionally add content-type
...
Signed-off-by: snipe <snipe@snipe.net>
2024-10-17 00:18:34 +01:00
snipe
017884f843
Added checks and filetype display
...
Signed-off-by: snipe <snipe@snipe.net>
2024-10-17 00:09:09 +01:00
snipe
c49921f50f
Removed unused (maybe?) API endpoint
...
Signed-off-by: snipe <snipe@snipe.net>
2024-10-17 00:08:54 +01:00
snipe
c49abb6aea
Refactor the UserFilesController show method for simpler inlining
...
Signed-off-by: snipe <snipe@snipe.net>
2024-10-17 00:08:38 +01:00
snipe
ccd2019448
Removed unusded use statements
...
Signed-off-by: snipe <snipe@snipe.net>
2024-10-17 00:08:04 +01:00
snipe
96191a5e93
Added method to decide if the file should be inlinable
...
Signed-off-by: snipe <snipe@snipe.net>
2024-10-17 00:07:54 +01:00
snipe
c56affd663
Added SVG icon
...
Signed-off-by: snipe <snipe@snipe.net>
2024-10-17 00:07:37 +01:00
Godfrey M
02bda3cd95
adds Checkout Consumable mailable and slackwebhook channel to notifs
2024-10-16 15:53:05 -07:00
Godfrey M
02ff646da4
adds checkin license mailable
2024-10-16 15:44:45 -07:00
Godfrey M
4becdca8aa
removes toMail from license notificaqtion
2024-10-16 15:39:20 -07:00
Godfrey M
2584d60344
adds Licenses seat checkout Mailable
2024-10-16 15:38:49 -07:00
Godfrey M
f1d83a3f28
forgot to add asset checkout markdown to projet
2024-10-16 15:30:53 -07:00
Godfrey M
c39df34bdf
forgot to add accessory mail to project
2024-10-16 15:29:50 -07:00
Godfrey M
dcdf600b78
adds Checkin and Checkout mailables and listner logic
2024-10-16 15:27:34 -07:00
Brady Wetherington
3cf746d7df
Rework the bulk checkout to not change how all checkouts work
2024-10-16 23:13:32 +01:00
Brady Wetherington
6b7af802af
Add 'bulk checkout' as one of the bulk actions in the bulk actions toolbar
2024-10-16 22:02:45 +01:00
Godfrey M
9710436d54
adds Mailables for asset checkin and out
2024-10-16 13:12:07 -07:00
Godfrey M
16cffe9a9d
simplified checkout webhook call
2024-10-16 12:53:35 -07:00
Godfrey M
9e1b86f586
sends checkout notification via webhook
2024-10-16 12:51:19 -07:00
Godfrey M
3ab2521cb0
email comes through, no picture and html markup appear though.
2024-10-16 12:21:33 -07:00
Marcus Moore
604a964462
Improve scenario descriptions
2024-10-16 11:52:24 -07:00
Marcus Moore
2f72c66614
Add additional case
2024-10-16 11:30:06 -07:00
Tobias Regnery
fdcc17ca2c
Fix user creation with FullMultipleCompanySupport enabled over API
...
It is currently possible as a non-superuser to create a new user or patch an existing user with arbitrary company over the API if FullMultipleCompanySupport is enabled.
Altough a highly unlikely scenario as the user needs permission to create API keys and new users, it is a bug that should get fixed.
Add a call to getIdForCurrentUser() to normalize the company_id if FullMultipleCompanySupport is enabled.
2024-10-16 11:47:18 +02:00
Marcus Moore
cba1a56040
Improve readability?
2024-10-15 17:38:11 -07:00
Marcus Moore
d9afde4610
Write failing test
2024-10-15 17:00:22 -07:00
Godfrey M
9f06a0e441
handle some edge cases, null values clean up variable names
2024-10-15 14:01:28 -07:00
Marcus Moore
42095c0167
Add reference link
2024-10-15 13:02:22 -07:00
Godfrey M
f8476f7133
finished the construct and mail call in the listner
2024-10-15 12:49:52 -07:00
Godfrey M
b29d032bf0
adds checkoutAssetMail class, and content method
2024-10-15 11:28:27 -07:00
snipe
2500375400
Merge pull request #15672 from uberbrady/ldap_location_fixes
...
Crowdin Action / upload-sources-to-crowdin (push) Has been cancelled
Docker images (Alpine) / docker (push) Has been cancelled
Docker images / docker (push) Has been cancelled
Tests in MySQL / PHP ${{ matrix.php-version }} (8.1) (push) Has been cancelled
Tests in MySQL / PHP ${{ matrix.php-version }} (8.2) (push) Has been cancelled
Tests in MySQL / PHP ${{ matrix.php-version }} (8.3) (push) Has been cancelled
Tests in SQLite / PHP ${{ matrix.php-version }} (8.1.1) (push) Has been cancelled
Clean up how we use the '$location' in LDAP sync command
2024-10-15 17:34:35 +01:00
Brady Wetherington
e4e1d0d50a
Clean up how we use the '$location' in LDAP sync command
2024-10-15 17:26:31 +01:00
snipe
16c8264e76
Merge pull request #15671 from snipe/bug/sc-27147
...
Bug/sc 27147
2024-10-15 16:42:34 +01:00
snipe
0ae9ce0aa9
Cannot sort by updated at on Users [sc-27147]
...
Signed-off-by: snipe <snipe@snipe.net>
2024-10-15 16:41:45 +01:00
snipe
50b8f180b3
More logical grouping in allow_columns
...
Signed-off-by: snipe <snipe@snipe.net>
2024-10-15 16:41:39 +01:00
snipe
914a647204
Merge pull request #15669 from snipe/remlove_ou_requirenedess
...
Fixed #15663 - remove requiredness for OU
2024-10-15 12:47:15 +01:00
snipe
e9225ff3ea
Switch to regular HTML for input form field
...
Signed-off-by: snipe <snipe@snipe.net>
2024-10-15 12:43:10 +01:00
snipe
d0d4159088
Fixed typo
...
Signed-off-by: snipe <snipe@snipe.net>
2024-10-15 12:42:09 +01:00
snipe
69b6080bd8
Merge pull request #15666 from snipe/updated_readme_llm
...
Crowdin Action / upload-sources-to-crowdin (push) Waiting to run
Docker images (Alpine) / docker (push) Waiting to run
Docker images / docker (push) Waiting to run
Tests in MySQL / PHP ${{ matrix.php-version }} (8.1) (push) Waiting to run
Tests in MySQL / PHP ${{ matrix.php-version }} (8.2) (push) Waiting to run
Tests in MySQL / PHP ${{ matrix.php-version }} (8.3) (push) Waiting to run
Tests in SQLite / PHP ${{ matrix.php-version }} (8.1.1) (push) Waiting to run
Update Docker Hub Description / dockerHubDescription (push) Has been cancelled
Added LLM note
2024-10-15 10:31:29 +01:00
snipe
b997d728fb
Added LLM note
...
Signed-off-by: snipe <snipe@snipe.net>
2024-10-15 10:30:34 +01:00
snipe
ddead359d0
Merge pull request #15660 from Toreg87/fixes/api_asset_create_fmcs2
...
Crowdin Action / upload-sources-to-crowdin (push) Waiting to run
Docker images (Alpine) / docker (push) Waiting to run
Docker images / docker (push) Waiting to run
Tests in MySQL / PHP ${{ matrix.php-version }} (8.1) (push) Waiting to run
Tests in MySQL / PHP ${{ matrix.php-version }} (8.2) (push) Waiting to run
Tests in MySQL / PHP ${{ matrix.php-version }} (8.3) (push) Waiting to run
Tests in SQLite / PHP ${{ matrix.php-version }} (8.1.1) (push) Waiting to run
Refactor asset creation with API
2024-10-14 14:29:34 +01:00
Tobias Regnery
f3c4e55667
Refactor asset creation with API
...
Commit fb4fe3004
restored the previous behaviour to check the company_id in case of FullMultipleCompanySupport.
But after rereading the code and the laravel documentation, the check is already there where it belongs in AssetStoreRequest::prepareForValidation()
The bug is the is_int-check of the request input in prepareForValidation(). Is is of type string even if it is a numeric value, so the call to getIdForCurrentUser() never happend.
Fix this by removing the check and the now redundant call to getIdForCurrentUser().
Wrong values will get caught by the model-level validation rules.
2024-10-14 15:14:41 +02:00
snipe
0d35335da7
Removed debugging
...
Crowdin Action / upload-sources-to-crowdin (push) Has been cancelled
Docker images (Alpine) / docker (push) Has been cancelled
Docker images / docker (push) Has been cancelled
Tests in MySQL / PHP ${{ matrix.php-version }} (8.1) (push) Has been cancelled
Tests in MySQL / PHP ${{ matrix.php-version }} (8.2) (push) Has been cancelled
Tests in MySQL / PHP ${{ matrix.php-version }} (8.3) (push) Has been cancelled
Tests in SQLite / PHP ${{ matrix.php-version }} (8.1.1) (push) Has been cancelled
Signed-off-by: snipe <snipe@snipe.net>
2024-10-11 16:06:17 +01:00