Commit graph

38 commits

Author SHA1 Message Date
Daniel Meltzer d722ed3823 Partialize forms (#2884)
* Consolidate edit form elements into reusable partials.

This is a large code change that doesn't do much immediately.  It
refactors all of the various edit.blade.php files to reference
standardized partials, so that they all reference the same base html
layout. This has the side effect of moving everything to the new fancy
"required" indicators, and making things look consistent.

In addition, I've gone ahead and renamed a few database fields.  We had
Assetmodel::modelno and Consumable::model_no, I've renamed both to
model_number.  We had items using ::note and ::notes, I've standardized
on ::notes.  Component used total_qty where consumables and accessories
used qty, so I've moved everything to qty (And fixed a few bugs in the
helper file in the process.

TODO includes looking at how/where to place the modal javascripts to
allow for on the fly creation from all places, rather than just the
asset page.

Rename assetmodel::modelno to model_number for clarity and consistency

Rename consumable::model_no to model_number for clarity and consistency

Rename assetmodel::note to notes for clarity and consistency

Port asset and assetmodel to new partials layout.  Adapt all code to the renamed model_number and notes database changes.  Fix some stying.

* Share a settings variable with all views.

* Allow editing the per_page setting.  We showed the value, but we never showed it on the edit page..

* use snipeSettings in all views instead of the long ugly path.

* War on partials. Centralize all bootstrap table javascript

* Use model_number instead of modelno in importer

* Codacy fix.

* More unification/deduplication.  Create an edit form template layout that we use as the base for all edit forms.  This gives the same interface for editing everything and makes the edit.blade.* files much easier to read.

* Use a ViewComposer instead of sharing the variable directly.  Fixes artisan optimize trying to hit the db--which ruins new installs

* Fix DB seeder.

* Base sql dump and csv's to import data from for tests.

* Start some functional tests for creating items.

* Add functional tests for all create methods.  Still need to do tests for edits, deletes, and lots of other things

* Improvements to functional tests.

Use the built in DB seeding mechanism instead of doing it ourselves.
Break the tests into multiple units, rather than testing everything in
each function.

* Some improvements to acceptance tests.

Make sure we're only looking at the "trs" within the bootstrap table.
Creation of assets is now tested at the functional level (and is faster)
so ignore it here.

I'm testing acceptance tests with the
IMPORT_{ASSETS,ACCESSORIES,CONSUMABLES}.csv in the tests/_data folder
imported.

* A few things to make acceptance tests work.  Add a name to the companies table, and make the locations table have the correct name

* Use a .env.tests file for testing functional and unit to allow a separate database.

* Add functional tests for compoents, groups, and licenses.

* Now that the config is in the functional.yml, this just confuses things.

* Start some functional tests for creating items.

* Add functional tests for all create methods.  Still need to do tests for edits, deletes, and lots of other things

* Improvements to functional tests.

Use the built in DB seeding mechanism instead of doing it ourselves.
Break the tests into multiple units, rather than testing everything in
each function.

* Some improvements to acceptance tests.

Make sure we're only looking at the "trs" within the bootstrap table.
Creation of assets is now tested at the functional level (and is faster)
so ignore it here.

I'm testing acceptance tests with the
IMPORT_{ASSETS,ACCESSORIES,CONSUMABLES}.csv in the tests/_data folder
imported.

* update db dump

* Update tests to new reality

* env for the test setup

* only load the database at beginning of tests, not between each Functional test.

* Fix a miss from renaming note to notes.

* Set Termination date when creating an asset.  It was only set on edit.

* Rename serial_number to serial in components for consistency.

* Update validation rules to match limits in database.  Currently we just accepted the values and they were truncated when adding to DB.

* Much more detailed functional testing of creating items.  This checks to make sure all values on form have been successfully persisted to database.
2016-11-16 16:56:57 -08:00
snipe d3a13bcd45 Functional config for laravel 5 2016-09-27 18:47:00 -07:00
snipe de17da099f Fixed tests 2016-08-02 01:12:58 -07:00
Daniel Meltzer df664bdc9d Fix categories acceptance test as it stands. We need to choose a category type to pass validation, and we need to see the elemnt alert-danger, not the text, to make the test fail when it should. (#2289) 2016-07-20 21:36:43 -07:00
Daniel Meltzer 68b0bbbec9 Fix tests (#2273)
* Update installer script for v3 now that things have moved around.

* Make Statuslabel attributes fillable and add them to the generated array.  Fixes status label tests.
2016-07-19 15:50:21 -07:00
snipe 697ed0d53c Fixes UAT for User
Needed to specify form name to prevent focus in asset tag search from being submitted
2016-05-31 21:16:30 -07:00
snipe 90a99429b3 Ugh, stupid indenting 2016-04-13 04:30:49 -07:00
snipe 1a2e545748 Configs. Again. 2016-04-13 04:30:13 -07:00
snipe d02423c1a5 Reverting url 2016-04-13 04:24:16 -07:00
snipe 3157a76e36 More poking and hoping. Travis is a piece of shit. 2016-04-13 04:11:38 -07:00
snipe 7236559b44 Try adding a defaul url to override the Webdriver "url is blank" bullshit 2016-04-13 04:07:03 -07:00
snipe 942b8d1b3c Put ORM back in 2016-04-13 03:56:44 -07:00
snipe 12e3d4647f Config URL is not found again. 2016-04-13 02:58:11 -07:00
snipe e094beea72 Hm, that didn't work 2016-04-13 02:50:56 -07:00
snipe c04754a17c https to http 2016-04-13 02:47:10 -07:00
snipe 0b71789274 Switched configs around a little 2016-04-13 02:41:55 -07:00
snipe 35cbf238a7 Yay, brand new error. 2016-04-13 02:25:45 -07:00
snipe 49405b48a3 Reverted name removal for Accessory in factory 2016-04-13 02:19:29 -07:00
snipe 3d666b27e0 Add Asserts 2016-04-13 02:19:09 -07:00
snipe 79073e5f1a Remove constructor 2016-04-13 02:19:03 -07:00
snipe e59d19865d Maybe the names are what's breaking it? 2016-04-13 01:58:46 -07:00
snipe 20876a4502 Meh 2016-04-13 01:51:28 -07:00
snipe 468fb14274 Added ci config to _env 2016-04-13 01:23:47 -07:00
snipe eaa02ef7d3 More poking and hoping 2016-04-13 01:14:23 -07:00
snipe 1eeb4d042a Sigh. 2016-04-13 00:56:43 -07:00
snipe 1c6e4a74be Why the fuck not. 2016-04-13 00:35:28 -07:00
snipe db83faeb49 Remove baseurl 2016-04-12 23:32:52 -07:00
snipe cf0a2051b0 Remove constructor 2016-04-12 22:53:38 -07:00
snipe f7d1415e33 Added SetUp back in :( 2016-04-12 22:49:07 -07:00
snipe aa4bb121ae Remove the putenv 2016-04-12 22:10:50 -07:00
snipe 1fb8f421a2 Add parent::createApplication(); 2016-04-12 22:00:21 -07:00
snipe cbe0f8a9eb Split environments into configs 2016-04-12 21:00:20 -07:00
snipe cc057fe282 Reformatting URL in acceptance.yml 2016-04-12 20:48:37 -07:00
snipe 2e7ddb75db Try diff block for testing (not testing-ci) 2016-03-30 15:56:53 -07:00
snipe 269944ecdf Try adding phantom as the browser 2016-03-30 15:47:29 -07:00
snipe 08c196872c Removed IP test in custom fields since we are using laravel's IP validation now 2016-03-28 21:53:36 -07:00
snipe 34536f29e9 Updated url with my local env SSL 2016-03-25 06:54:48 -07:00
snipe fe00b0e401 Version 3 - hold onto your butts 2016-03-25 01:18:05 -07:00