snipe
5d4e704fac
Added a comment
...
Signed-off-by: snipe <snipe@snipe.net>
2023-06-21 09:26:54 +01:00
snipe
2d9ddab3f0
Moved logic for tighter constraints when ids are passed
...
Signed-off-by: snipe <snipe@snipe.net>
2023-06-21 09:24:17 +01:00
Godfrey M
ee50906e44
attempt to add warranty to api controller
2023-06-13 11:20:55 -07:00
Marcus Moore
8e6e525b47
Remove scopeCompanyables call from LicensesController
2023-06-07 16:09:45 -07:00
Marcus Moore
a18f5e7fc0
Remove scopeCompanyables call from ConsumablesController
2023-06-07 14:22:22 -07:00
Marcus Moore
48850f3597
Remove scopeCompanyables call from ComponentsController
2023-06-06 18:02:18 -07:00
Ivan Nieto Vivanco
086265455d
Pass user count to the eloquent query
2023-05-23 11:53:09 -06:00
snipe
f9449aa81f
Merge pull request #13069 from marcusmoore/fixes/add-eager-load-to-asset-model-endpoint
...
Add eager loading to Asset Models controller
2023-05-22 14:39:32 -07:00
Marcus Moore
a6eeae6541
Eager load fieldset default values in asset model endpoint
2023-05-22 14:19:03 -07:00
snipe
71234228b4
Merge pull request #13025 from Godmartinz/archived_clears_assigned_to
...
removes assigned_to if archived
2023-05-16 17:25:24 -07:00
snipe
02cacf76c6
Additional multi-select options for custom report
...
Signed-off-by: snipe <snipe@snipe.net>
2023-05-16 13:58:21 -07:00
Godfrey M
8e3cbdad90
removes assigned_to if archived
2023-05-15 11:52:57 -07:00
snipe
0f3b77ee2d
Added multi-select option to custom report
...
Signed-off-by: snipe <snipe@snipe.net>
2023-05-10 14:45:31 -07:00
slong753
5e34ffa2b0
wip
2023-05-10 14:08:12 -05:00
snipe
9f39d71f16
Merge pull request #12831 from Godmartinz/adds_multi_select_to_custom_report
...
Added Multiselect of companies for custom reports
2023-05-10 11:36:21 -07:00
snipe
7c77f4a697
Extra debugging
...
Signed-off-by: snipe <snipe@snipe.net>
2023-05-10 09:10:53 -07:00
akemidx
537aa04c9a
Merge branch 'develop' into delete_asset_from_view_page
2023-05-10 09:30:54 -04:00
snipe
788c03ef57
Hide client secret if app is locked
...
Signed-off-by: snipe <snipe@snipe.net>
2023-05-10 02:22:49 -07:00
snipe
2dd32d8785
Re-add the image update
...
Signed-off-by: snipe <snipe@snipe.net>
2023-05-10 02:18:27 -07:00
snipe
ff66a938c1
Clearer comments
...
Signed-off-by: snipe <snipe@snipe.net>
2023-05-10 02:18:15 -07:00
snipe
7f0e677908
Use normal translation style
...
Signed-off-by: snipe <snipe@snipe.net>
2023-05-10 02:18:05 -07:00
snipe
e8a0c7f2ce
Remove avatar update, since we don’t take URLs for that
...
Signed-off-by: snipe <snipe@snipe.net>
2023-05-10 01:59:33 -07:00
snipe
e950cf4279
Switch to using username as match for google login
...
Signed-off-by: snipe <snipe@snipe.net>
2023-05-10 01:58:36 -07:00
snipe
567a800c51
Added debugging
...
Signed-off-by: snipe <snipe@snipe.net>
2023-05-10 01:47:52 -07:00
snipe
e5eb5932ca
Create constructor to override expected config variables
...
Signed-off-by: snipe <snipe@snipe.net>
2023-05-10 01:37:03 -07:00
snipe
3612526632
Disallow saving data if app is locked
...
Signed-off-by: snipe <snipe@snipe.net>
2023-05-10 01:14:54 -07:00
snipe
aefd330e4e
Added methods for google settings
...
Signed-off-by: snipe <snipe@snipe.net>
2023-05-10 00:54:28 -07:00
snipe
b7e8ce3064
Changed redirect
...
Signed-off-by: snipe <snipe@snipe.net>
2023-05-10 00:54:14 -07:00
snipe
c52b48c383
Google oauth login
...
Signed-off-by: snipe <snipe@snipe.net>
2023-05-10 00:14:28 -07:00
slong753
1d2596fc54
wip
2023-05-09 14:58:59 -05:00
snipe
332b017dcc
Pass filename for manual backups
...
Signed-off-by: snipe <snipe@snipe.net>
2023-05-08 15:00:02 -07:00
snipe
5960a5425d
Pass filename to pre-import backup
...
Signed-off-by: snipe <snipe@snipe.net>
2023-05-08 14:48:26 -07:00
snipe
6486ea4fb7
Merge pull request #12976 from inietov/fixes/validate_soft-deleted_models_in_asset_model
...
Refactor of #12955
2023-05-08 13:14:02 -07:00
snipe
d70e14de61
Merge pull request #12972 from marcusmoore/bug/sc-23177
...
Fixes user name missing in accessory acceptance notifications
2023-05-08 13:04:37 -07:00
snipe
8b73fa0053
Added missing use statement
...
Signed-off-by: snipe <snipe@snipe.net>
2023-05-06 06:36:09 -07:00
Ivan Nieto Vivanco
fbb7c55450
Tweak 'exist' rule in Asset->model_id field so it ignores soft-deleted models
2023-05-04 03:12:36 -06:00
Marcus Moore
96c6d8896f
Add additional information to acceptance notifications for assets, accessories, and consumables
2023-05-03 17:04:01 -07:00
Marcus Moore
4a0b3efd1f
Include user's name in Acceptance result notifications for accessories
2023-05-03 14:22:05 -07:00
slong753
815c77f943
wip
2023-05-03 14:49:31 -05:00
snipe
fe710efb40
Merge pull request #12874 from Godmartinz/feature/sc-23130
...
Adds a checkout range for custom asset reports
2023-05-03 11:43:44 -07:00
snipe
fc53b56481
Merge pull request #12955 from inietov/fixes/error_500_after_sign_and_accept_asset
...
Fixed Error 500 after sign and accept asset
2023-05-03 11:43:14 -07:00
snipe
b716f9f55e
Merge pull request #12916 from snipe/features/auto_add_to_fieldset
...
Added ability to auto-add fields to new fieldsets
2023-05-03 11:04:33 -07:00
snipe
ea17fdeba5
Merge pull request #12846 from snipe/features/livewire_location_import
...
Location importer via Livewire Importer
2023-05-03 11:02:06 -07:00
snipe
f5cd58e9b7
Unmix return type variables
...
Signed-off-by: snipe <snipe@snipe.net>
2023-05-03 10:57:02 -07:00
slong753
cdda4a56d8
aha, ok thisd kind of works
2023-05-02 19:11:43 -05:00
slong753
b2c2097e8b
just more troubleshooting stuff, still no solution
2023-05-02 18:54:20 -05:00
Ivan Nieto Vivanco
6936d76661
Prevent hard fail when retrieving acceptance data
2023-05-01 16:50:18 -06:00
Ivan Nieto Vivanco
1b2d830380
Check if model exists before create asset via API
2023-05-01 16:05:03 -06:00
Marcus Moore
3cae32b236
Eager load default locations
2023-04-27 17:13:09 -07:00
Marcus Moore
429c4cb99f
Remove the loading of asset maintenances that are not used by view
2023-04-27 17:12:53 -07:00
akemidx
d94bed3f57
push for testing
2023-04-27 18:58:59 -04:00
snipe
54a766c4f9
Added dynamic warranty URL to manufacturers
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-26 16:39:15 -07:00
snipe
5eac314f4d
Merge pull request #12906 from akemidx/feature/sc-20622
...
Dynamic warranty link for manufacturers' support urls
2023-04-26 14:49:22 -07:00
akemidx
497d17835f
requested edits
2023-04-26 17:06:08 -04:00
slong753
52c9fefbe0
ok, this works except error display
2023-04-26 15:06:50 -05:00
snipe
8f0b823fb3
Applies #12868
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-25 23:39:32 -07:00
snipe
22d73f503a
Merge pull request #12756 from dboth/develop
...
Fixed #8208 , #8896 , #8985 and #9789 : Currency issues when using non-english locales (resubmission)
2023-04-25 22:32:13 -07:00
snipe
d6ea5de5b8
Merge remote-tracking branch 'origin/develop' into features/auto_add_to_fieldset
2023-04-25 22:20:50 -07:00
snipe
c8c6f879d4
Merge pull request #12912 from Godmartinz/ldap_location_sync
...
added ldap_location to settings
2023-04-25 21:54:28 -07:00
snipe
45f22e7561
Updated the sync to disassociate if all boxed are unchecked
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-25 21:31:23 -07:00
snipe
15dc4e4779
Added fieldset sync
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-25 21:29:57 -07:00
slong753
6bec9cf880
fix a couple things
2023-04-25 23:26:16 -05:00
snipe
5eeca937cb
Added logic for syncing fieldset info
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-25 21:08:26 -07:00
snipe
662b7787a1
Updated redirect return
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-25 21:07:50 -07:00
Godfrey M
cb68f41d9c
added ldap_location to settings
2023-04-25 11:44:04 -07:00
snipe
66ce02fc48
Added permission on restore
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-25 08:09:16 -07:00
snipe
6e7f0728fd
Added more granular permissions on bulk actions for assets
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-25 08:06:45 -07:00
akemidx
9cd2783185
Regex added for link instead
2023-04-24 20:07:21 -04:00
Marcus Moore
2aba8252f3
Ensure users editing themselves do not deactivate their account
2023-04-20 21:59:55 -07:00
akemidx
16a5a883e5
new request, preparing support_url for validation
2023-04-20 16:34:25 -04:00
Ivan Nieto Vivanco
747d6cfdb4
Change the flow of the condition using an early return
2023-04-20 10:37:26 -06:00
Ivan Nieto Vivanco
ae53609b1b
Declare variables only if license is found
2023-04-20 10:16:11 -06:00
Godfrey M
bdd1045272
adds a checkout range for custom asset reports
2023-04-19 09:11:44 -07:00
snipe
3a808aa806
Updated method for available seat count
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-18 02:44:33 -07:00
snipe
dc6eb6f104
Throw a warning if there were no users affected
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-18 02:07:17 -07:00
snipe
a8a3ca3624
Use count on availSeats
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-18 02:06:42 -07:00
snipe
f21d9c27e6
Use new translations for logs
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-18 01:07:26 -07:00
snipe
bfcbd9628a
Refactored license controller with new counts
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-18 01:02:58 -07:00
snipe
087f0e596a
Fixed has to where
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-17 22:44:05 -07:00
snipe
99cecee4b5
Merge branch 'develop' into features/adds_license_checkin_checkout_to_all_in_gui
2023-04-17 14:54:30 -07:00
slong753
52dc99588e
pushing for now, needs validation work
2023-04-17 13:57:48 -05:00
Kevin Köllmann
04f3c4bf69
Fixed #12854 : Allow checkout of available components down to zero stock
2023-04-17 11:45:11 +02:00
snipe
a83991041a
Better placement for errors
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-16 16:08:06 -07:00
snipe
16ab2bec06
Added sorting and searching on autoassign_licenses via user API
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-16 15:27:39 -07:00
snipe
4b66ca6ac5
Added method to bulk checkin (much simpler than checking out)
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-16 15:27:15 -07:00
snipe
844ad83431
Added method to bulk checkout license seats
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-16 15:26:59 -07:00
snipe
9833d861d4
Added autoassign_licenses tp bulk users conditional
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-16 15:26:33 -07:00
snipe
03cc55cb6a
Set autoassign_licenses to false if unchecked
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-16 15:25:52 -07:00
snipe
8183b8deba
Added stub method
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-16 12:30:02 -07:00
snipe
64256351d8
Used a singleton to filter API limit value
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-16 08:46:39 -07:00
snipe
78ec21acc4
Added location case
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-16 07:47:49 -07:00
snipe
955539807c
Merge pull request #12830 from snipe/features/adds_supplier_id_to_components
...
Added supplier to components and consumables
2023-04-15 18:42:23 -07:00
snipe
fc7f1f907d
Fixed variable name
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-15 17:37:25 -07:00
snipe
4cbb9c2409
Use abs() instead of max
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-15 17:28:25 -07:00
Godfrey M
ab67d903b5
adds multi select to custom report for companies
2023-04-13 12:02:11 -07:00
snipe
2fe7fcecdb
Added case switch for sorting on suppliers
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-13 11:13:45 -07:00
snipe
d2b3e251ad
Added counters to API controllers
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-13 11:12:16 -07:00
snipe
07c0a1927b
Added supplier id to controllers
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-13 11:12:01 -07:00
slong753
8b9aea8874
very much WIP, but dupe queries reduced
...
but i think this can be cleaned up a bit more
2023-04-12 14:46:48 -05:00
snipe
112a04b108
Better handle weird data passed to the API via limit and offset
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-12 11:28:46 -07:00
snipe
70ce0d9ee6
Maintain activated state on editing a user
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-09 14:06:29 -07:00
snipe
baf267e2e9
Small cleanups
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-07 09:45:16 -07:00
snipe
cb76815e8b
Removed if check on assets, since that’s already handled via validation
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-07 09:42:31 -07:00
snipe
4c88c751ef
Code cleanup, better validation
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-06 22:03:40 -07:00
snipe
0abb993600
General cleanup and standardization for component API
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-06 22:02:57 -07:00
snipe
4840046f44
Check for available quantity on consumables before checkout
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-06 20:38:02 -07:00
snipe
ffdc0d76f7
Fixed accessories verifying that enough remain to be checked out
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-06 18:40:29 -07:00
snipe
383d48fd9c
Merge pull request #12787 from Godmartinz/accessory_unavailable_message
...
Added unavailable message to prevent over-checkout of Accessories
2023-04-06 15:05:18 -07:00
snipe
bd4757ad7a
Merge pull request #12779 from snipe/features/replace_icheck_with_only_css
...
Move from iCheck to pure CSS for radio and checkboxes
2023-04-06 14:58:33 -07:00
Godfrey M
3d7c55deb3
removed an unncessary query
2023-04-06 13:06:05 -07:00
Godfrey M
55943d8897
uses numRemaining now
2023-04-06 10:05:17 -07:00
snipe
161999fbca
Fixed #12772 - use the APP_URL config more consistently
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-05 16:05:40 -07:00
snipe
752365aa85
Updated support URL
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-05 14:54:40 -07:00
Godfrey M
b038fe8f2e
adds unavailable message to overcheckout
2023-04-05 10:00:39 -07:00
snipe
8b315a6502
Updated contrller to use trans_choice
...
Signed-off-by: snipe <snipe@snipe.net>
2023-04-03 18:55:09 -07:00
snipe
cfef9d8cca
Merge pull request #12763 from inietov/fixes/call_to_member_function_licenses_on_null
...
Fixed Call to a Member Function Licenses() on null [sc-20606]
2023-03-30 14:20:13 -07:00
slong753
0f72554a9f
translations for messages
2023-03-30 13:57:18 -05:00
slong753
382d849ee1
added catch for no assets selected
2023-03-30 13:52:29 -05:00
Ivan Nieto Vivanco
d10b7fd6af
Use firstorfail on eloquent query to return error if asset is not found
2023-03-29 19:11:28 -06:00
slong753
e4c76f454c
this is good, just needs translations done in view
2023-03-29 18:24:56 -05:00
slong753
162b70d5a9
wireframed, needs a view and should work
2023-03-29 17:34:36 -05:00
slong753
65bbecd145
this all works - could use some eyes
2023-03-29 14:46:31 -05:00
Dominik Both
3271c9dc9f
Fix #8208 , #8896 , #8985 , #9789
2023-03-29 09:56:34 +02:00
slong753
032ae4348e
custom fields display, need to get saving
...
+some clean up
2023-03-28 21:45:31 -05:00
slong753
804a788a27
initial fetch working
2023-03-28 20:31:24 -05:00
snipe
c9d1274edc
Merge pull request #12753 from snipe/fixes/lang_for_group_not_found
...
Fixes/lang for group not found
2023-03-28 16:45:22 -07:00
snipe
32922e6461
Use corrected language string
...
Signed-off-by: snipe <snipe@snipe.net>
2023-03-28 16:39:52 -07:00
Ivan Nieto Vivanco
77d513f80b
Assign target variable as the other checkout types
2023-03-28 17:25:57 -06:00
Ivan Nieto Vivanco
d70b7dbf41
Checks if exist on API checkout
2023-03-28 16:12:48 -06:00
snipe
e869b1fd53
Fixed #12724 - fieldset not saving on model
...
Signed-off-by: snipe <snipe@snipe.net>
2023-03-24 06:11:24 -07:00
snipe
545d023a18
Handled a few more hard-coded strings
...
Signed-off-by: snipe <snipe@snipe.net>
2023-03-21 23:56:07 -07:00
snipe
473211397f
Merge pull request #12708 from uberbrady/livewire_importer_no_subcomponent
...
Livewire importer without subcomponent
2023-03-21 23:07:04 -07:00
snipe
e08327be95
Ability to remove user location from users
...
Rework of #9677 - sorry @godmartinez - I suck :(
Signed-off-by: snipe <snipe@snipe.net>
2023-03-21 23:03:57 -07:00
snipe
418ce75a9f
Merge pull request #11431 from ntbutler-nbcs/develop
...
[Fix / Minor Change] Asset checkinbytag now consistent with existingAPI
2023-03-21 22:40:21 -07:00
snipe
c229d69cec
Added next audit date override in bulk asset edit
...
Signed-off-by: snipe <snipe@snipe.net>
2023-03-21 16:01:41 -07:00
snipe
4f8542b71b
Merge pull request #12680 from akemidx/clone_accessories
...
Clone accessories
2023-03-21 13:37:04 -07:00
snipe
f2a3c2a349
Merge pull request #12693 from snipe/fixes/use_statements
...
Updates the Gate “use” statement to be more specific
2023-03-18 12:00:23 -07:00
snipe
f9e190eb32
Updates the Gate “use” statement to be more specific
...
Signed-off-by: snipe <snipe@snipe.net>
2023-03-18 11:58:09 -07:00
snipe
8dd3ae8a37
Corrected gates, added fillable
...
Signed-off-by: snipe <snipe@snipe.net>
2023-03-18 11:53:20 -07:00
snipe
82dc57aa18
Renamed some variables, invoked the event listener
...
Signed-off-by: snipe <snipe@snipe.net>
2023-03-17 16:24:58 -07:00
snipe
9ac4efb912
Better commenting
...
Signed-off-by: snipe <snipe@snipe.net>
2023-03-17 16:24:38 -07:00
snipe
30cf7eb750
Disallow action in demo mode
...
Signed-off-by: snipe <snipe@snipe.net>
2023-03-17 02:42:50 -07:00
snipe
0dd11575c5
Added merge controller
...
Signed-off-by: snipe <snipe@snipe.net>
2023-03-16 18:19:16 -07:00
snipe
b374834999
Added extra order by switch for first_name and last_name
...
Signed-off-by: snipe <snipe@snipe.net>
2023-03-16 16:07:51 -07:00
snipe
5e4455f042
Deleted duplicate statement
...
Signed-off-by: snipe <snipe@snipe.net>
2023-03-16 16:07:36 -07:00
akemidx
a8e2f72e25
accessory cloning, WITHOUT copying over the image.
2023-03-15 16:55:24 -04:00
snipe
e9601bcf13
Handle already-deleted license files more gracefully
...
Signed-off-by: snipe <snipe@snipe.net>
2023-03-15 13:05:51 -07:00
akemidx
a3353b8496
committing
2023-03-15 13:48:22 -04:00
snipe
4c66267f3b
Merge pull request #12668 from inietov/fixes/undefined_array_key_0
...
Fixed ErrorException: Undefined array key 0 [sc-20424]
2023-03-14 17:10:04 -07:00
slong753
60b70a4074
catch and redirect back with error
2023-03-14 16:07:09 -05:00
snipe
dfd9fcc5e0
Merge pull request #12599 from inietov/fixes/unknown_column_0_in_field_list
...
Fixed Column not found: 1054 Unknown column '0' in 'field list' [sc-20004]
2023-03-14 09:51:42 -07:00
Ivan Nieto Vivanco
67471a3a77
Evaluate if the collection is empty before access the array index
2023-03-13 21:44:06 -06:00
Ivan Nieto Vivanco
d224f3177e
Delete a rule that was breaking validation
2023-03-13 16:43:10 -06:00
Ivan Nieto Vivanco
e7b3daa80c
Adjust validator to only receive valid groups id's
2023-03-13 16:10:08 -06:00
Ivan Nieto Vivanco
e4204a6dd1
Adds validator to PATCH request in the API UsersController
2023-03-13 15:49:05 -06:00
snipe
dccd6fd4b1
Duplicate withCount
...
Signed-off-by: snipe <snipe@snipe.net>
2023-03-08 13:06:14 -08:00
snipe
7f8bdbd252
Added showableAssets() relationship to Category model
...
Signed-off-by: snipe <snipe@snipe.net>
2023-03-08 13:01:38 -08:00
Brady Wetherington
09c1298e03
Merge branch 'develop' into livewire_importer_2_squashed_and_rebased
...
I'll be taking in the changes to the importer front-end elsewhere
2023-03-07 18:51:05 -08:00
akemidx
ec5836dab4
cloning accessories first bit
2023-03-07 16:41:48 -05:00
snipe
1ebbc767f1
Merge pull request #12624 from snipe/features/added_vip_and_byod_to_importer
...
Added `vip` and `byod` to importer
2023-03-06 17:11:28 -08:00
snipe
e1069ac234
Return a file not found error if it doesn’t appear on disk
...
Signed-off-by: snipe <snipe@snipe.net>
2023-03-06 15:09:37 -08:00
snipe
8b6e8898c1
Fixed hardcoded string
...
Signed-off-by: snipe <snipe@snipe.net>
2023-03-06 15:09:12 -08:00
snipe
2cb06165c4
Added missing vip field to transformer and request
...
Signed-off-by: snipe <snipe@snipe.net>
2023-03-06 15:00:04 -08:00
snipe
cc7325074e
Check that the file exists before trying to stat it for filesize
...
Signed-off-by: snipe <snipe@snipe.net>
2023-03-06 10:47:28 -08:00
snipe
f54d83ed59
Merge pull request #12612 from manuteleco/add_path_in_preflight_url_message
...
Fixed #11800 : Include path in the expected URL during Pre-Flight
2023-03-06 09:36:15 -08:00
Manuel Rodríguez Guimeráns
548ae7ad22
Add Reverse Proxy support to Pre-Flight URL check
...
Before this change, the Pre-Flight URL check would inevitably fail
whenever Snipe-IT was running behind a reverse proxy or load balancer.
The URL check tries to ensure that the configured application URL
matches the URL that is actually used to reach the application. However,
when running behind an HTTP intermediary (like a reverse proxy or a load
balancer) the HTTP connection that Snipe-IT receives is not the _real_
connection from the user anymore, but a connection from the HTTP
intermediary. The scheme, host and port that Snipe-IT would obtain from
that incoming intermediary connection wouldn't match what is configured
as application URL and, therefore, the URL check would fail.
This commit solves the situation by making Snipe-IT's Pre-Flight URL
check aware of the `X-Forwarded-Proto` and `X-Forwarded-Host` HTTP
headers. These headers represent the _de-facto_ standard used by reverse
proxies and other HTTP intermediary components to convey information
about the incoming HTTP connection to the upstream application. Being
the upstream application, Snipe-IT can then make use of this information
to correctly evaluate the validity of the configured application URL.
2023-03-05 18:15:16 +01:00
Manuel Rodríguez Guimeráns
1d4f4b92de
Include path in the expected URL during Pre-Flight
...
So that the message displayed to the user when the URL Pre-Flight check
fails is:
> Snipe-IT thinks your URL is SCHEME://DOMAIN, but your real
URL is SCHEME://DOMAIN/setup
instead of:
> Snipe-IT thinks your URL is SCHEME://DOMAIN/setup, but your real
URL is SCHEME://DOMAIN/setup
Having a missing "/setup" in the expected URL might confuse the user
into thinking that it is an additional configuration problem they need
to fix.
With this change, the comparison between the expected and actual URL
will not contain any accidental difference anymore. Only those that the
user really needs to be aware of and fix in their setup.
2023-03-05 17:52:45 +01:00
Ivan Nieto Vivanco
95f568b934
Remove unnecessary try/catch
2023-03-02 19:50:47 -06:00
Ivan Nieto Vivanco
8a5d426ccd
Use correct LicenseSeat property
2023-03-02 19:33:32 -06:00
Ivan Nieto Vivanco
e0b2dc043a
Adds try/catch to users API
2023-03-02 11:13:56 -06:00
snipe
b8231f420b
Remove name from blanking paroperties
...
Signed-off-by: snipe <snipe@snipe.net>
2023-03-01 14:12:33 -08:00
snipe
84a14918bb
Updated comments
...
Signed-off-by: snipe <snipe@snipe.net>
2023-03-01 14:03:33 -08:00
snipe
473553c464
Moved gate
...
Signed-off-by: snipe <snipe@snipe.net>
2023-03-01 14:01:40 -08:00
snipe
dac877f184
Added location clone
...
Signed-off-by: snipe <snipe@snipe.net>
2023-03-01 13:51:35 -08:00
Brady Wetherington
ca849db316
The 'download activity report' displayed the wrong value for 'admin'
2023-03-01 12:23:13 -08:00
snipe
562546a853
Updated comment
...
Signed-off-by: snipe <snipe@snipe.net>
2023-02-28 23:37:30 -08:00
snipe
4860440306
Check that it’s an array (versus checking that it’s not a bool)
...
Signed-off-by: snipe <snipe@snipe.net>
2023-02-28 23:32:10 -08:00
snipe
b72a9cc6fd
Check if the $owner is boolean
...
Signed-off-by: snipe <snipe@snipe.net>
2023-02-28 23:31:26 -08:00
snipe
463ef02fae
Merge pull request #12578 from inietov/fixes/undefined_variable_total
...
Fixed Undefined variable `$total`
2023-02-28 20:50:00 -08:00
Brady Wetherington
2f94bf96ff
Everything's all wired up; just need to clean up all the FIXME's and stuff
2023-02-28 18:36:52 -08:00
snipe
1f7ae08d76
Merge branch 'develop' into features/make_eol_sortable
2023-02-28 18:05:09 -08:00
Ivan Nieto Vivanco
1be0a8d911
Declare variable as an empty array
2023-02-28 10:22:49 -06:00
Ivan Nieto Vivanco
9d94bd6567
Validate if the license seat is not checked out, it can't be checked in
2023-02-27 18:57:38 -06:00
Brady Wetherington
0a085af0a0
Getting the basic wiring of the importer over into Livewire
...
WIP: Wiring up more and more of the actions on the importer
Files now upload okay, a little glitchy on the display-side though
add to readmes so i dont forget
2023-02-27 14:28:59 -08:00
snipe
96c851468c
Added max results limit to report index
...
Signed-off-by: snipe <snipe@snipe.net>
2023-02-27 12:04:46 -08:00
snipe
3e47d9e689
Pass the existing asset name to the bulk checkout form
...
Signed-off-by: snipe <snipe@snipe.net>
2023-02-24 09:54:46 -08:00
snipe
5e6ebb9a65
Merge pull request #12410 from uberbrady/paginate_accessories_report
...
Paginate accessories report
2023-02-23 12:26:17 -08:00
snipe
8e72da42e8
Merge pull request #12406 from akemidx/vip_tag
...
Added a checkbox to notate VIP status
2023-02-23 12:23:29 -08:00
snipe
eb6357636a
Merge pull request #12467 from marcusmoore/fix/scope-people-with-full-multiple-companies
...
Fix full company scoping in user selects
2023-02-23 10:36:33 -08:00
akemidx
690970b4aa
fixing ff error
2023-02-22 18:18:20 -05:00
snipe
4bf1566d2a
Merge pull request #12124 from Godmartinz/feature/sc-16946/add-checkbox-to-allow-skipping-a-user-during
...
Adds Boolean to Users Table for Auto Assigning Licenses
2023-02-21 20:10:46 -08:00
snipe
0c3115553e
Merge branch 'develop' into vip_tag
2023-02-21 20:03:49 -08:00
snipe
ff895739f4
Merge pull request #12446 from Godmartinz/livewire_slack_inputs
...
Adds Livewire slack inputs
2023-02-15 13:27:07 -08:00
snipe
3800cdd0da
Merge pull request #12466 from snipe/fixes/style_fixes
...
Style fixes
2023-02-15 11:07:59 -08:00
Ivan Nieto Vivanco
6936efd387
Remove e() function from customfield format input
2023-02-12 16:27:37 -06:00
snipe
b0b1c96ab5
Merge pull request #12514 from marcusmoore/fixes/preserve-asset-name-during-api-checkout
...
Fix asset names being removed during API checkout requests
2023-02-14 12:22:03 -08:00
Marcus Moore
8e00191b69
Add comment
2023-02-14 12:19:16 -08:00
Marcus Moore
a94f19a68e
Use name if provided by asset checkout request
2023-02-14 12:08:20 -08:00
Marcus Moore
2349f54013
Use translation strings for importer exceptions
2023-02-13 13:30:36 -08:00
Marcus Moore
73f355f3a8
Return 422 instead of 500 when import is invalid
2023-02-08 12:39:42 -08:00
Marcus Moore
b3881a43a7
Fix return type
2023-02-08 12:34:25 -08:00
Marcus Moore
c2c666aef0
Formatting
2023-02-08 12:32:57 -08:00
Marcus Moore
5962f1b627
Catch json encoding exceptions and display them to the user
2023-02-08 12:21:51 -08:00
snipe
c1d484b5df
Fixed mismatched field/fieldset
...
Signed-off-by: snipe <snipe@snipe.net>
2023-02-07 13:31:50 -08:00
snipe
d52d32fed9
Fixed visibility for constants and methods
...
Signed-off-by: snipe <snipe@snipe.net>
2023-02-06 12:44:02 -08:00
snipe
7363d4e223
FIxed yoda operator
...
Signed-off-by: snipe <snipe@snipe.net>
2023-02-06 12:43:35 -08:00
snipe
c8c5dddcc1
Removed unused else condition
...
Signed-off-by: snipe <snipe@snipe.net>
2023-02-06 12:43:19 -08:00
Marcus Moore
38cdcdf064
Eager load company
2023-02-06 10:59:51 -08:00
snipe
51f3857a31
Fixed something I think I broke
...
Signed-off-by: snipe <snipe@snipe.net>
2023-02-02 15:32:45 -08:00
akemidx
b8951e2b54
fixing name from vipuser to vip
2023-02-02 15:58:05 -05:00
Godfrey M
17f1772143
removes postslack from settings controller
2023-02-01 16:58:08 -08:00
Godfrey M
3a86547ef5
fixes messages for integration test, removes slack request file, rehouses ajax method
2023-02-01 16:51:05 -08:00
snipe
d9cdb92014
Merge branch 'develop' into vip_tag
2023-02-01 16:03:23 -08:00
snipe
1a8fb5bcfe
Merge pull request #12423 from snipe/features/edit_fieldset_name
...
Fixed #12418 - added ability to edit custom field names via GUI
2023-02-01 13:39:39 -08:00
Godfrey M
f95a904d90
adds integration button, working on its functionality
2023-02-01 12:08:13 -08:00
cram42
0f3c5d10ba
Merge branch 'feature-label2' into develop
2023-02-01 18:01:46 +11:00
cram42
73fd0a24ca
Clarify example asset variable
2023-02-01 17:58:58 +11:00
cram42
4b4c228f1a
Correct parameter order
2023-02-01 17:56:23 +11:00
snipe
f7ae5db4f3
Merge branch 'develop' into features/fixed_12382_added_checked_out_count_to_accessories
2023-01-31 19:56:43 -08:00
snipe
2d45ebe103
Merge pull request #12433 from inietov/fixes/asset_declined_date_issues
...
Fixed Invalid date value on assets acceptance mail notification
2023-01-31 19:14:51 -08:00
lukasfehling
cddae4869f
fixed the endpoint for user notification with all their assigned assets
2023-01-31 18:27:25 +01:00
Ivan Nieto Vivanco
ccc7b78f62
Store the acceptance dates with format YYY-mm-dd
2023-01-30 15:11:41 -06:00
snipe
22b0b9b090
Fixed gates on fieldsets
...
Signed-off-by: snipe <snipe@snipe.net>
2023-01-26 17:05:41 -08:00
snipe
583a0412fe
Added edit fieldsets translations
...
Signed-off-by: snipe <snipe@snipe.net>
2023-01-26 17:03:23 -08:00
Brady Wetherington
4a54586690
Add to Accessories#index an additional gate-check against reports.view
2023-01-26 11:56:06 -08:00
akemidx
53d8008a5f
Merge branch 'vip_tag' of github.com:akemidx/snipe-it into vip_tag
2023-01-25 17:14:29 -05:00
akemidx
b363524305
vipuser label updated to vip
2023-01-25 15:58:44 -05:00
snipe
4c3354b778
Merge branch 'develop' into vip_tag
2023-01-24 20:29:43 -08:00
Brady Wetherington
b00333c9f5
Merge remote-tracking branch 'upstream/develop' into develop
2023-01-24 17:36:39 -08:00
Brady Wetherington
c9f0f5fe8b
Change Accessories report to use server-side pagination from URL
2023-01-24 17:35:44 -08:00
akemidx
596846a94a
Add VIP Checkbox
2023-01-24 15:29:27 -05:00
Marcus Moore
b92d1d3ec7
Logically group query when searching users to scope to company
2023-01-24 11:54:56 -08:00
snipe
dc155846ca
Hoist the autorization higher in the stack so we’re not doing logic or math when the user isn’t authorized to touch this
...
Signed-off-by: snipe <snipe@snipe.net>
2023-01-23 21:49:17 -08:00
snipe
7a9ea91be0
Merge pull request #12387 from snipe/fixes/inconsistent_UI_for_image_delete
...
Updated - Refactored ImageHandler request to be more re-usable, and checkboxes with missing `minimal` class for iCheck
2023-01-23 21:39:55 -08:00
snipe
02dcb0fbd7
Shorten the additiona form request invocation to just ImageUploadRequest
...
We already have the `use App\Http\Requests\ImageUploadRequest` clause at the top of this file.
Signed-off-by: snipe <snipe@snipe.net>
2023-01-23 21:37:35 -08:00
cram42
c2c009a018
Merge branch 'develop' into develop
2023-01-24 09:53:42 +08:00
Jeremy Price
d3bcc48ae5
[imports] fix "Backup before importing?" checkbox on import page
...
We were always taking backups before import, no matter the status of
this box.
Turns out we were testing for the presence of the property defined by
the checkbox, rather than the value of the property, and as such were
always doing a backup.
We're now checking the status, and it behaves as expected
2023-01-23 15:08:59 -08:00
snipe
41537a2449
Added field to the API controller endpoints
...
Signed-off-by: snipe <snipe@snipe.net>
2023-01-22 00:56:44 -08:00
snipe
cd8cb445ba
Corrected fieldname for user fieldname for avatar in Controller
...
Signed-off-by: snipe <snipe@snipe.net>
2023-01-21 18:20:53 -08:00
snipe
f77d871dff
Use the imageHandler for profile avatar changes
...
Signed-off-by: snipe <snipe@snipe.net>
2023-01-21 18:05:20 -08:00
snipe
60eab08735
Added ->with(‘users as users_count’)
in Accessory query
...
Signed-off-by: snipe <snipe@snipe.net>
2023-01-21 14:41:07 -08:00
snipe
378dc968b7
Derp. Copypasta
...
Signed-off-by: snipe <snipe@snipe.net>
2023-01-18 15:44:28 -08:00
snipe
0c39c7a53d
Updated blades to add byod as a “status”
...
Signed-off-by: snipe <snipe@snipe.net>
2023-01-18 13:25:46 -08:00
snipe
b80d52a9c3
Added byod to asset controller for create and update methods
...
Signed-off-by: snipe <snipe@snipe.net>
2023-01-18 13:03:51 -08:00
snipe
ee4b8f4694
Added byod to API controller
...
Signed-off-by: snipe <snipe@snipe.net>
2023-01-18 13:03:31 -08:00
Godfrey M
7ce230fadc
missed a few renames
2023-01-18 08:57:59 -08:00
snipe
dbda288a44
Formatting changes only for readability
...
Signed-off-by: snipe <snipe@snipe.net>
2023-01-17 17:21:20 -08:00
snipe
eaf9332096
Added filterability to 2FA fields
...
Signed-off-by: snipe <snipe@snipe.net>
2023-01-17 17:21:03 -08:00
snipe
151719a91c
Added comments
...
Signed-off-by: snipe <snipe@snipe.net>
2023-01-10 16:24:46 -08:00
snipe
825df2cf75
Load up the item counts with the individual API methods for accurate numbers without n+1
...
Signed-off-by: snipe <snipe@snipe.net>
2023-01-10 16:17:03 -08:00