mirror of
https://github.com/snipe/snipe-it.git
synced 2024-12-28 06:59:41 -08:00
64d649be7f
* Extract a handlesimages trait to centralize logic for parsing/storing images on upload in create/edit methods. * Use same image upload/layout in accessories as consum+components. * Monster: Cleanup/Refactor http controllers. This cleans up docblocks, pulls most non-crudy actions into their own controllers, and does general cleanup/logic refactoring. There /should/ be no functional changes, but we all know how should works.. Extract checkin/checkout functions to a separate controller for accessories. Move controllers to subdirectory. Cleanup AssetModelsController Extract component checkin/checkout Assorted cleanups/doc/formatting in controllers. Refactor LicenseController. Refactor UsersController Update viewassetscontroller. * Codacy cleanups * More codacy cleanups. Extract a LicenseCheckout Form request as well. * A bit more refactor/cleaning of the license checkout method. * Review Related Cleanups * Fix most of the item_not_found translations. In many cases, the string being generated did not even use the id parameter. Where it does, pass it as id instead of as a different value. * Remove some old $data arrays from when we manually sent emails from the controllers. This has been superseeded by the notification system (yay!) * Bugfix: Only log the checkin of an accessory if the checkin completes sucessfully.
93 lines
3.3 KiB
PHP
93 lines
3.3 KiB
PHP
<?php
|
|
|
|
namespace App\Http\Controllers\Components;
|
|
|
|
use App\Http\Controllers\Controller;
|
|
use App\Models\Asset;
|
|
use App\Models\Component;
|
|
use Illuminate\Http\Request;
|
|
use Illuminate\Support\Facades\Auth;
|
|
use Illuminate\Support\Facades\Input;
|
|
use Illuminate\Support\Facades\Validator;
|
|
|
|
class ComponentCheckoutController extends Controller
|
|
{
|
|
/**
|
|
* Returns a view that allows the checkout of a component to an asset.
|
|
*
|
|
* @author [A. Gianotto] [<snipe@snipe.net>]
|
|
* @see ComponentCheckoutController::store() method that stores the data.
|
|
* @since [v3.0]
|
|
* @param int $componentId
|
|
* @return \Illuminate\Contracts\View\View
|
|
* @throws \Illuminate\Auth\Access\AuthorizationException
|
|
*/
|
|
public function create($componentId)
|
|
{
|
|
// Check if the component exists
|
|
if (is_null($component = Component::find($componentId))) {
|
|
// Redirect to the component management page with error
|
|
return redirect()->route('components.index')->with('error', trans('admin/components/message.not_found'));
|
|
}
|
|
$this->authorize('checkout', $component);
|
|
return view('components/checkout', compact('component'));
|
|
}
|
|
|
|
/**
|
|
* Validate and store checkout data.
|
|
*
|
|
* @author [A. Gianotto] [<snipe@snipe.net>]
|
|
* @see ComponentCheckoutController::create() method that returns the form.
|
|
* @since [v3.0]
|
|
* @param Request $request
|
|
* @param int $componentId
|
|
* @return \Illuminate\Http\RedirectResponse
|
|
* @throws \Illuminate\Auth\Access\AuthorizationException
|
|
*/
|
|
public function store(Request $request, $componentId)
|
|
{
|
|
// Check if the component exists
|
|
if (is_null($component = Component::find($componentId))) {
|
|
// Redirect to the component management page with error
|
|
return redirect()->route('components.index')->with('error', trans('admin/components/message.not_found'));
|
|
}
|
|
|
|
$this->authorize('checkout', $component);
|
|
|
|
$max_to_checkout = $component->numRemaining();
|
|
$validator = Validator::make($request->all(), [
|
|
"asset_id" => "required",
|
|
"assigned_qty" => "required|numeric|between:1,$max_to_checkout"
|
|
]);
|
|
|
|
if ($validator->fails()) {
|
|
return redirect()->back()
|
|
->withErrors($validator)
|
|
->withInput();
|
|
}
|
|
|
|
$admin_user = Auth::user();
|
|
$asset_id = e(Input::get('asset_id'));
|
|
|
|
// Check if the user exists
|
|
if (is_null($asset = Asset::find($asset_id))) {
|
|
// Redirect to the component management page with error
|
|
return redirect()->route('components.index')->with('error', trans('admin/components/message.asset_does_not_exist'));
|
|
}
|
|
|
|
// Update the component data
|
|
$component->asset_id = $asset_id;
|
|
|
|
$component->assets()->attach($component->id, [
|
|
'component_id' => $component->id,
|
|
'user_id' => $admin_user->id,
|
|
'created_at' => date('Y-m-d H:i:s'),
|
|
'assigned_qty' => Input::get('assigned_qty'),
|
|
'asset_id' => $asset_id
|
|
]);
|
|
|
|
$component->logCheckout(e(Input::get('note')), $asset);
|
|
return redirect()->route('components.index')->with('success', trans('admin/components/message.checkout.success'));
|
|
}
|
|
}
|