mirror of
https://github.com/snipe/snipe-it.git
synced 2024-12-27 14:39:49 -08:00
64d649be7f
* Extract a handlesimages trait to centralize logic for parsing/storing images on upload in create/edit methods. * Use same image upload/layout in accessories as consum+components. * Monster: Cleanup/Refactor http controllers. This cleans up docblocks, pulls most non-crudy actions into their own controllers, and does general cleanup/logic refactoring. There /should/ be no functional changes, but we all know how should works.. Extract checkin/checkout functions to a separate controller for accessories. Move controllers to subdirectory. Cleanup AssetModelsController Extract component checkin/checkout Assorted cleanups/doc/formatting in controllers. Refactor LicenseController. Refactor UsersController Update viewassetscontroller. * Codacy cleanups * More codacy cleanups. Extract a LicenseCheckout Form request as well. * A bit more refactor/cleaning of the license checkout method. * Review Related Cleanups * Fix most of the item_not_found translations. In many cases, the string being generated did not even use the id parameter. Where it does, pass it as id instead of as a different value. * Remove some old $data arrays from when we manually sent emails from the controllers. This has been superseeded by the notification system (yay!) * Bugfix: Only log the checkin of an accessory if the checkin completes sucessfully.
112 lines
4.4 KiB
PHP
112 lines
4.4 KiB
PHP
<?php
|
|
|
|
namespace App\Http\Controllers\Components;
|
|
|
|
use App\Http\Controllers\Controller;
|
|
use App\Models\Actionlog;
|
|
use App\Models\Asset;
|
|
use App\Models\Component;
|
|
use Illuminate\Http\Request;
|
|
use Illuminate\Support\Facades\DB;
|
|
use Illuminate\Support\Facades\Validator;
|
|
|
|
class ComponentCheckinController extends Controller
|
|
{
|
|
|
|
/**
|
|
* Returns a view that allows the checkin of a component from an asset.
|
|
*
|
|
* @author [A. Gianotto] [<snipe@snipe.net>]
|
|
* @see ComponentCheckinController::store() method that stores the data.
|
|
* @since [v4.1.4]
|
|
* @param $component_asset_id
|
|
* @return \Illuminate\Contracts\View\View
|
|
* @throws \Illuminate\Auth\Access\AuthorizationException
|
|
*/
|
|
public function create($component_asset_id)
|
|
{
|
|
|
|
// This could probably be done more cleanly but I am very tired. - @snipe
|
|
if ($component_assets = DB::table('components_assets')->find($component_asset_id)) {
|
|
if (is_null($component = Component::find($component_assets->component_id))) {
|
|
return redirect()->route('components.index')->with('error', trans('admin/components/messages.not_found'));
|
|
}
|
|
if (is_null($asset = Asset::find($component_assets->asset_id))) {
|
|
return redirect()->route('components.index')->with('error',
|
|
trans('admin/components/message.not_found'));
|
|
}
|
|
$this->authorize('checkin', $component);
|
|
return view('components/checkin', compact('component_assets','component','asset'));
|
|
}
|
|
|
|
return redirect()->route('components.index')->with('error', trans('admin/components/messages.not_found'));
|
|
|
|
}
|
|
|
|
|
|
/**
|
|
* Validate and store checkin data.
|
|
*
|
|
* @author [A. Gianotto] [<snipe@snipe.net>]
|
|
* @see ComponentCheckinController::create() method that returns the form.
|
|
* @since [v4.1.4]
|
|
* @param Request $request
|
|
* @param $component_asset_id
|
|
* @return \Illuminate\Http\RedirectResponse
|
|
* @throws \Illuminate\Auth\Access\AuthorizationException
|
|
*/
|
|
public function store(Request $request, $component_asset_id)
|
|
{
|
|
if ($component_assets = DB::table('components_assets')->find($component_asset_id)) {
|
|
if (is_null($component = Component::find($component_assets->component_id))) {
|
|
return redirect()->route('components.index')->with('error',
|
|
trans('admin/components/message.not_found'));
|
|
}
|
|
|
|
|
|
$this->authorize('checkin', $component);
|
|
|
|
$max_to_checkin = $component_assets->assigned_qty;
|
|
$validator = Validator::make($request->all(), [
|
|
"checkin_qty" => "required|numeric|between:1,$max_to_checkin"
|
|
]);
|
|
|
|
if ($validator->fails()) {
|
|
return redirect()->back()
|
|
->withErrors($validator)
|
|
->withInput();
|
|
}
|
|
|
|
// Validation passed, so let's figure out what we have to do here.
|
|
$qty_remaining_in_checkout = ($component_assets->assigned_qty - (int)$request->input('checkin_qty'));
|
|
|
|
// We have to modify the record to reflect the new qty that's
|
|
// actually checked out.
|
|
$component_assets->assigned_qty = $qty_remaining_in_checkout;
|
|
DB::table('components_assets')->where('id',
|
|
$component_asset_id)->update(['assigned_qty' => $qty_remaining_in_checkout]);
|
|
|
|
$log = new Actionlog();
|
|
$log->user_id = auth()->id();
|
|
$log->action_type = 'checkin from';
|
|
$log->target_type = Asset::class;
|
|
$log->target_id = $component_assets->asset_id;
|
|
$log->item_id = $component_assets->component_id;
|
|
$log->item_type = Component::class;
|
|
$log->note = $request->input('note');
|
|
$log->save();
|
|
|
|
// If the checked-in qty is exactly the same as the assigned_qty,
|
|
// we can simply delete the associated components_assets record
|
|
if ($qty_remaining_in_checkout == 0) {
|
|
DB::table('components_assets')->where('id', '=', $component_asset_id)->delete();
|
|
}
|
|
|
|
return redirect()->route('components.index')->with('success',
|
|
trans('admin/components/message.checkout.success'));
|
|
}
|
|
return redirect()->route('components.index')->with('error', trans('admin/components/message.not_found'));
|
|
}
|
|
|
|
}
|