mudhorn/TC2-BBS-mesh
1
0
Fork 1
mirror of https://github.com/TheCommsChannel/TC2-BBS-mesh.git synced 2025-03-05 20:51:53 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Added error handling for non-integer inputs in mail selection

Browse source 
- Wrapped int() conversion in a try-except block to catch ValueError when users input non-numeric values.
- Provided user feedback for invalid input and allowed retrying in the same step.
This commit is contained in:
tbrinkhuis 2024-09-09 19:37:19 +00:00
parent b778b8b6cd
commit 384fa7dc17
1 changed files with 6 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
command_handlers.py
View file

@ -229,9 +229,7 @@ def handle_bb_steps(sender_id, message, step, state, interface, bbs_nodes):
def handle_mail_steps(sender_id, message, step, state, interface, bbs_nodes): def handle_mail_steps(sender_id, message, step, state, interface, bbs_nodes):
message = message.lower().strip() message = message.lower().strip()
if len(message) == 2 and message[1] == 'x':
message = message[0]
if step == 1: if step == 1:
choice = message choice = message
if choice == 'r': if choice == 'r':
@ -252,17 +250,17 @@ def handle_mail_steps(sender_id, message, step, state, interface, bbs_nodes):
handle_help_command(sender_id, interface) handle_help_command(sender_id, interface)
elif step == 2: elif step == 2:
mail_id = int(message)
try: try:
mail_id = int(message)
sender_node_id = get_node_id_from_num(sender_id, interface) sender_node_id = get_node_id_from_num(sender_id, interface)
sender, date, subject, content, unique_id = get_mail_content(mail_id, sender_node_id) sender, date, subject, content, unique_id = get_mail_content(mail_id, sender_node_id)
send_message(f"Date: {date}\nFrom: {sender}\nSubject: {subject}\n{content}", sender_id, interface) send_message(f"Date: {date}\nFrom: {sender}\nSubject: {subject}\n{content}", sender_id, interface)
send_message("What would you like to do with this message?\n[K]eep [D]elete [R]eply", sender_id, interface) send_message("What would you like to do with this message?\n[K]eep [D]elete [R]eply", sender_id, interface)
update_user_state(sender_id, {'command': 'MAIL', 'step': 4, 'mail_id': mail_id, 'unique_id': unique_id, 'sender': sender, 'subject': subject, 'content': content}) update_user_state(sender_id, {'command': 'MAIL', 'step': 4, 'mail_id': mail_id, 'unique_id': unique_id, 'sender': sender, 'subject': subject, 'content': content})
except TypeError: except ValueError:
logging.info(f"Node {sender_id} tried to access non-existent message") send_message("Invalid input. Please enter a valid message number.", sender_id, interface)
send_message("Mail not found", sender_id, interface) # Optionally keep the user in the same state to try again
update_user_state(sender_id, None) update_user_state(sender_id, {'command': 'MAIL', 'step': 2})
elif step == 3: elif step == 3:
short_name = message.lower() short_name = message.lower()