n8n/packages/cli/test/unit/services/test-webhook-registrations.service.test.ts

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

108 lines
3.2 KiB
TypeScript
Raw Normal View History

feat(core): Cache test webhook registrations (#8176) In a multi-main setup, we have the following issue. The user's client connects to main A and runs a test webhook, so main A starts listening for a webhook call. A third-party service sends a request to the test webhook URL. The request is forwarded by the load balancer to main B, who is not listening for this webhook call. Therefore, the webhook call is unhandled. To start addressing this, cache test webhook registrations, using Redis for queue mode and in-memory for regular mode. When the third-party service sends a request to the test webhook URL, the request is forwarded by the load balancer to main B, who fetches test webhooks from the cache and, if it finds a match, executes the test webhook. This should be transparent - test webhook behavior should remain the same as so far. Notes: - Test webhook timeouts are not cached. A timeout is only relevant to the process it was created in, so another process retrieving from Redis a "foreign" timeout will be unable to act on it. A timeout also has circular references, so `cache-manager-ioredis-yet` is unable to serialize it. - In a single-main scenario, the timeout remains in the single process and is cleared on test webhook expiration, successful execution, and manual cancellation - all as usual. - In a multi-main scenario, we will need to have the process who received the webhook call send a message to the process who created the webhook directing this originating process to clear the timeout. This will likely be implemented via execution lifecycle hooks and Redis channel messages checking session ID. This implementation is out of scope for this PR and will come next. - Additional data in test webhooks is not cached. From what I can tell, additional data is not needed for test webhooks to be executed. Additional data also has circular references, so `cache-manager-ioredis-yet` is unable to serialize it. Follow-up to: #8155
2024-01-03 07:58:33 -08:00
import type { CacheService } from '@/services/cache.service';
import type { TestWebhookRegistration } from '@/services/test-webhook-registrations.service';
import { TestWebhookRegistrationsService } from '@/services/test-webhook-registrations.service';
import { mock } from 'jest-mock-extended';
describe('TestWebhookRegistrationsService', () => {
const cacheService = mock<CacheService>();
const registrations = new TestWebhookRegistrationsService(cacheService);
const registration = mock<TestWebhookRegistration>({
webhook: { httpMethod: 'GET', path: 'hello', webhookId: undefined },
});
const key = 'test-webhook:GET|hello';
const fullCacheKey = `n8n:cache:${key}`;
describe('register()', () => {
test('should register a test webhook registration', async () => {
await registrations.register(registration);
expect(cacheService.set).toHaveBeenCalledWith(key, registration);
});
});
describe('deregister()', () => {
test('should deregister a test webhook registration', async () => {
await registrations.register(registration);
await registrations.deregister(key);
expect(cacheService.delete).toHaveBeenCalledWith(key);
});
});
describe('get()', () => {
test('should retrieve a test webhook registration', async () => {
cacheService.get.mockResolvedValueOnce(registration);
const promise = registrations.get(key);
await expect(promise).resolves.toBe(registration);
});
test('should return undefined if no such test webhook registration was found', async () => {
cacheService.get.mockResolvedValueOnce(undefined);
const promise = registrations.get(key);
await expect(promise).resolves.toBeUndefined();
});
});
describe('getAllKeys()', () => {
test('should retrieve all test webhook registration keys', async () => {
cacheService.keys.mockResolvedValueOnce([fullCacheKey]);
const result = await registrations.getAllKeys();
expect(result).toEqual([key]);
});
});
describe('getAllRegistrations()', () => {
test('should retrieve all test webhook registrations', async () => {
cacheService.keys.mockResolvedValueOnce([fullCacheKey]);
cacheService.getMany.mockResolvedValueOnce([registration]);
const result = await registrations.getAllRegistrations();
expect(result).toEqual([registration]);
});
});
describe('updateWebhookProperties()', () => {
test('should update the properties of a test webhook registration', async () => {
cacheService.get.mockResolvedValueOnce(registration);
const newProperties = { ...registration.webhook, isTest: true };
await registrations.updateWebhookProperties(newProperties);
registration.webhook = newProperties;
expect(cacheService.set).toHaveBeenCalledWith(key, registration);
delete registration.webhook.isTest;
});
});
describe('deregisterAll()', () => {
test('should deregister all test webhook registrations', async () => {
cacheService.keys.mockResolvedValueOnce([fullCacheKey]);
await registrations.deregisterAll();
expect(cacheService.delete).toHaveBeenCalledWith(key);
});
});
describe('toKey()', () => {
test('should convert a test webhook registration to a key', () => {
const result = registrations.toKey(registration.webhook);
expect(result).toBe(key);
});
});
});