Add more fixes

packages/cli/src/services/curl.service.ts

@@ -261,12 +261,12 @@ const mapCookies = (cookies: CurlJson['cookies']): { cookie: string } | {} => {
 };
 
 export const flattenObject = (obj: { [x: string]: any }, prefix = '') =>
-	Object.keys(obj).reduce((acc, k) => {
+	Object.keys(obj).reduce<Record<string, unknown>>((acc, k) => {
 		const pre = prefix.length ? prefix + '.' : '';
-		// eslint-disable-next-line @typescript-eslint/no-unsafe-argument
-		if (typeof obj[k] === 'object') Object.assign(acc, flattenObject(obj[k], pre + k));
-		//@ts-ignore
-		// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
+		// @Problem: `typeof null` is `object`, which creates a bug here
+		if (typeof obj[k] === 'object')
+			// eslint-disable-next-line @typescript-eslint/no-unsafe-argument
+			Object.assign(acc, flattenObject(obj[k], pre + k));
 		else acc[pre + k] = obj[k];
 		return acc;
 	}, {});
@@ -465,12 +465,14 @@ export class CurlService {
 		}
 
 		if (!Object.keys(httpNodeParameters.options?.redirect.redirect).length) {
-			// @ts-ignore
+			// @Cleanup: Type `options.redirect` as optional and fix type errors
+			// @ts-expect-error Options is typed as non-optional
 			delete httpNodeParameters.options.redirect;
 		}
 
 		if (!Object.keys(httpNodeParameters.options.response.response).length) {
-			// @ts-ignore
+			// @Cleanup: Type `options.response` as optional and fix type errors
+			// @ts-expect-error Options is typed as non-optional
 			delete httpNodeParameters.options.response;
 		}
 

packages/cli/test/integration/middlewares/body-parser.test.ts

@@ -21,8 +21,8 @@ describe('bodyParser', () => {
 		const response = await request(server)
 			.post('/')
 			.set('content-encoding', 'gzip')
-			// @ts-ignore
-			.serialize((d) => gzipSync(JSON.stringify(d)))
+			// Mock for testing
+			.serialize((d) => gzipSync(JSON.stringify(d)) as unknown as string)
 			.send({ hello: 'world' })
 			.expect(200);
 		expect(response.text).toEqual('{"hello":"world"}');
@@ -32,8 +32,8 @@ describe('bodyParser', () => {
 		const response = await request(server)
 			.post('/')
 			.set('content-encoding', 'deflate')
-			// @ts-ignore
-			.serialize((d) => deflateSync(JSON.stringify(d)))
+			// Mock for testing
+			.serialize((d) => deflateSync(JSON.stringify(d)) as unknown as string)
 			.send({ hello: 'world' })
 			.expect(200);
 		expect(response.text).toEqual('{"hello":"world"}');

packages/cli/test/integration/shared/db/credentials.ts

@@ -1,3 +1,4 @@
+import type { ICredentialDataDecryptedObject } from 'n8n-workflow';
 import { Container } from 'typedi';
 
 import { CredentialsEntity } from '@/databases/entities/credentials-entity';
@@ -17,8 +18,8 @@ export async function encryptCredentialData(
 	const { createCredentialsFromCredentialsEntity } = await import('@/credentials-helper');
 	const coreCredential = createCredentialsFromCredentialsEntity(credential, true);
 
-	// @ts-ignore
-	coreCredential.setData(credential.data);
+	// data column is actually an object despite the type
+	coreCredential.setData(credential.data as unknown as ICredentialDataDecryptedObject);
 
 	return Object.assign(credential, coreCredential.getDataToSave());
 }

packages/core/src/WorkflowExecute.ts

@@ -1504,17 +1504,11 @@ export class WorkflowExecute {
 								lineResult.json.$error !== undefined &&
 								lineResult.json.$json !== undefined
 							) {
-								// eslint-disable-next-line @typescript-eslint/ban-ts-comment
-								// @ts-ignore
 								lineResult.error = lineResult.json.$error as NodeApiError | NodeOperationError;
 								lineResult.json = {
-									// eslint-disable-next-line @typescript-eslint/ban-ts-comment
-									// @ts-ignore
 									error: (lineResult.json.$error as NodeApiError | NodeOperationError).message,
 								};
 							} else if (lineResult.error !== undefined) {
-								// eslint-disable-next-line @typescript-eslint/ban-ts-comment
-								// @ts-ignore
 								lineResult.json = { error: lineResult.error.message };
 							}
 						}

packages/editor-ui/src/components/MfaSetupModal.vue

@@ -9,7 +9,6 @@ import { ref, onMounted } from 'vue';
 import { useUsersStore } from '@/stores/users.store';
 import { mfaEventBus } from '@/event-bus';
 import { useToast } from '@/composables/useToast';
-//@ts-ignore
 import QrcodeVue from 'qrcode.vue';
 import { useClipboard } from '@/composables/useClipboard';
 import { useI18n } from '@/composables/useI18n';

packages/editor-ui/src/components/NodeSettings.vue

@@ -403,7 +403,8 @@ const valueChanged = (parameterData: IUpdateInformation) => {
 
 		if (parameterData.value && typeof parameterData.value === 'object') {
 			for (const parameterName of Object.keys(parameterData.value)) {
-				//@ts-ignore
+				// @Cleanup: Instead use `Object.entries()` to get both key and value
+				// @ts-expect-error this breaks the connection of keys and values
 				newValue = parameterData.value[parameterName];
 
 				// Remove the 'parameters.' from the beginning to just have the
@@ -415,7 +416,8 @@ const valueChanged = (parameterData: IUpdateInformation) => {
 				const parameterPathArray = parameterPath.match(/(.*)\[(\d+)\]$/);
 
 				// Apply the new value
-				//@ts-ignore
+				// @Problem: `parameterData[parameterName]` makes little sense to me, please investigate if this should be `parameterData.value[parameterName]`? But that doesn't really make sense either.
+				// @ts-expect-error This seems like a bug?
 				if (parameterData[parameterName] === undefined && parameterPathArray !== null) {
 					// Delete array item
 					const path = parameterPathArray[1];

packages/editor-ui/src/components/executions/ExecutionsFilter.vue

@@ -70,9 +70,8 @@ const vModel = reactive(
 					return filter[key];
 				},
 				set(value) {
-					// TODO: find out what exactly is typechecker complaining about
-
-					// @ts-ignore
+					// @Cleanup: Type the `computed<>()` call correctly or swap reduce for an easier to type solution
+					// @ts-expect-error We lose type info on value because we set this up in a reduce loop
 					filter[key] = value;
 					emit('filterChanged', filter);
 				},

packages/editor-ui/src/components/executions/global/GlobalExecutionsListItem.vue

@@ -11,13 +11,14 @@ import type { PermissionsRecord } from '@/permissions';
 
 type Command = 'retrySaved' | 'retryOriginal' | 'delete';
 
-const emit = defineEmits<{
-	stop: [data: ExecutionSummary];
-	select: [data: ExecutionSummary];
-	retrySaved: [data: ExecutionSummary];
-	retryOriginal: [data: ExecutionSummary];
-	delete: [data: ExecutionSummary];
-}>();
+const emit = defineEmits<
+	{
+		stop: [data: ExecutionSummary];
+		select: [data: ExecutionSummary];
+	} & {
+		[c in Command]: [data: ExecutionSummary];
+	}
+>();
 
 const props = withDefaults(
 	defineProps<{
@@ -160,8 +161,9 @@ function onSelect() {
 }
 
 async function handleActionItemClick(commandData: Command) {
-	//@ts-ignore todo: fix this type
-	emit(commandData, props.execution);
+	// The `emit` function is not typed very well and does not take type unions of the single event types
+	// Se we need to hide the type
+	emit(commandData as never, props.execution);
 }
 </script>
 <template>

packages/editor-ui/src/composables/useHistoryHelper.test.ts

@@ -4,7 +4,10 @@ import { render } from '@testing-library/vue';
 import userEvent from '@testing-library/user-event';
 import { useHistoryHelper } from './useHistoryHelper';
 import { defineComponent, type PropType } from 'vue';
-import type { RouteLocationNormalizedLoaded } from 'vue-router';
+import type {
+	RouteLocationNormalizedLoaded,
+	RouteLocationNormalizedLoadedGeneric,
+} from 'vue-router';
 import { mock } from 'vitest-mock-extended';
 
 const undoMock = vi.fn();
@@ -56,7 +59,6 @@ describe('useHistoryHelper', () => {
 		redoMock.mockClear();
 	});
 	it('should call undo when Ctrl+Z is pressed', async () => {
-		// @ts-ignore
 		render(TestComponent, {
 			props: {
 				route: mock<RouteLocationNormalizedLoaded>({
@@ -74,7 +76,6 @@ describe('useHistoryHelper', () => {
 		expect(undoMock).toHaveBeenCalledTimes(2);
 	});
 	it('should call redo when Ctrl+Shift+Z is pressed', async () => {
-		// @ts-ignore
 		render(TestComponent, {
 			props: {
 				route: mock<RouteLocationNormalizedLoaded>({
@@ -92,8 +93,7 @@ describe('useHistoryHelper', () => {
 		expect(redoMock).toHaveBeenCalledTimes(2);
 	});
 	it('should not call undo when Ctrl+Z if not on NodeView', async () => {
-		// @ts-ignore
-		render(TestComponent, { props: { route: {} } });
+		render(TestComponent, { props: { route: {} as RouteLocationNormalizedLoadedGeneric } });
 
 		await userEvent.keyboard('{Control>}z');
 		await userEvent.keyboard('{Control>}z');

packages/editor-ui/src/composables/useWorkflowHelpers.ts

@@ -518,7 +518,6 @@ export function useWorkflowHelpers(options: { router: ReturnType<typeof useRoute
 
 		const nodes: INode[] = [];
 		for (let nodeIndex = 0; nodeIndex < workflowNodes.length; nodeIndex++) {
-			// @ts-ignore
 			nodeData = getNodeDataToSave(workflowNodes[nodeIndex]);
 
 			nodes.push(nodeData);
@@ -555,16 +554,17 @@ export function useWorkflowHelpers(options: { router: ReturnType<typeof useRoute
 			'notes',
 			'parameters',
 			'status',
-		];
+		] as const;
 
-		// @ts-ignore
-		const nodeData: INodeUi = {
+		// @Cleanup: Unify the following lines in a type-safe way, probably with Object.assign() and a filter
+		// Cast to INodeUi as we're about to provide all required keys
+		const nodeData = {
 			parameters: {},
-		};
+		} as INodeUi;
 
 		for (const key in node) {
-			if (key.charAt(0) !== '_' && skipKeys.indexOf(key) === -1) {
-				// @ts-ignore
+			if (key.charAt(0) !== '_' && skipKeys.indexOf(key as never) === -1) {
+				// @ts-expect-error We can't narrow the type to the same key, should Object.assign instead
 				nodeData[key] = node[key];
 			}
 		}

packages/editor-ui/src/stores/pushConnection.store.ts

@@ -142,7 +142,8 @@ export const usePushConnectionStore = defineStore(STORES.PUSH, () => {
 	async function pushMessageReceived(event: Event) {
 		let receivedData: PushMessage;
 		try {
-			// @ts-ignore
+			// @Cleanup: Check for data explicitly and log telemetry on missing field if appropriate
+			// @ts-expect-error We're okay to error on missing data attribute here
 			receivedData = JSON.parse(event.data);
 		} catch (error) {
 			return;

packages/editor-ui/src/stores/workflows.store.ts

@@ -366,7 +366,7 @@ export const useWorkflowsStore = defineStore(STORES.WORKFLOWS, () => {
 						undefined,
 				};
 			},
-		} as unknown as INodeTypes;
+		};
 
 		return nodeTypes;
 	}