mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-24 20:24:05 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

refactor(core): Stop reporting to Sentry unrecognized node errors (no-changelog) (#7728)

Browse source 
https://n8nio.sentry.io/issues/4636584213
This commit is contained in:
Iván Ovejero 2023-11-17 10:25:10 +01:00 committed by GitHub
parent b4ebb1a28d
commit 0408299c7d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
cypress/e2e/12-canvas.cy.ts
View file

@ -390,20 +390,20 @@ describe('Canvas Node Manipulation and Navigation', () => {
);
WorkflowPage.actions.executeWorkflow();
cy.contains('Node not found').should('be.visible');
cy.contains('Unrecognized node type').should('be.visible');
WorkflowPage.getters
.canvasNodeByName(`${unknownNodeName} 1`)
.find('[data-test-id=delete-node-button]')
.click({ force: true });
WorkflowPage.getters
WorkflowPage.getters
.canvasNodeByName(`${unknownNodeName} 2`)
.find('[data-test-id=delete-node-button]')
.click({ force: true });
WorkflowPage.actions.executeWorkflow();
cy.contains('Node not found').should('not.exist');
cy.contains('Unrecognized node type').should('not.exist');
});
});

12
packages/cli/src/NodeTypes.ts
View file

@ -8,12 +8,19 @@ import type {
} from 'n8n-workflow';
import { NodeHelpers } from 'n8n-workflow';
import { Service } from 'typedi';
import { RESPONSE_ERROR_MESSAGES } from './constants';
import { LoadNodesAndCredentials } from './LoadNodesAndCredentials';
import { join, dirname } from 'path';
import { readdir } from 'fs/promises';
import type { Dirent } from 'fs';
class UnrecognizedNodeError extends Error {
severity = 'warning';
constructor(nodeType: string) {
super(`Unrecognized node type: ${nodeType}".`);
}
}
@Service()
export class NodeTypes implements INodeTypes {
constructor(private loadNodesAndCredentials: LoadNodesAndCredentials) {
@ -67,7 +74,8 @@ export class NodeTypes implements INodeTypes {
loadedNodes[type] = { sourcePath, type: loaded };
return loadedNodes[type];
}
throw new Error(`${RESPONSE_ERROR_MESSAGES.NO_NODE}: ${type}`);
throw new UnrecognizedNodeError(type);
}
async getNodeTranslationPath({