mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-24 20:24:05 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix(editor): Make Webhook node pinnable (#9047)

Browse source
This commit is contained in:
Iván Ovejero 2024-04-03 17:41:15 +02:00 committed by GitHub
parent dc42ac17a6
commit 042aa62fc2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 17 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
cypress/e2e/13-pinning.cy.ts
View file

@ -69,6 +69,16 @@ describe('Data pinning', () => {
ndv.getters.outputTbodyCell(1, 0).should('include.text', 1); ndv.getters.outputTbodyCell(1, 0).should('include.text', 1);
}); });
it('should display pin data edit button for Webhook node', () => {
workflowPage.actions.addInitialNodeToCanvas('Webhook', { keepNdvOpen: true });
ndv.getters
.runDataPaneHeader()
.find('button')
.filter(':visible')
.should('have.attr', 'title', 'Edit Output');
});
it('Should be duplicating pin data when duplicating node', () => { it('Should be duplicating pin data when duplicating node', () => {
workflowPage.actions.addInitialNodeToCanvas('Schedule Trigger'); workflowPage.actions.addInitialNodeToCanvas('Schedule Trigger');
workflowPage.actions.addNodeToCanvas(EDIT_FIELDS_SET_NODE_NAME, true, true); workflowPage.actions.addNodeToCanvas(EDIT_FIELDS_SET_NODE_NAME, true, true);

8
packages/editor-ui/src/composables/useNodeType.ts
View file

@ -36,7 +36,13 @@ export function useNodeType(
: false; : false;
}); });
const isMultipleOutputsNodeType = computed(() => (nodeType.value?.outputs ?? []).length > 1); const isMultipleOutputsNodeType = computed(() => {
const outputs = nodeType.value?.outputs;
if (typeof outputs === 'string') return false; // e.g. Webhook node
return (outputs ?? []).length > 1;
});
return { return {
nodeType, nodeType,