mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-25 20:54:07 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

🐛 Fix issue Pipedrive-Trigger bug #1018 (#1021)

Browse source
This commit is contained in:
Ricardo Espinoza 2020-10-08 10:39:13 -04:00 committed by GitHub
parent cec264f8f4
commit 04cf86369d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
packages/nodes-base/nodes/Pipedrive/PipedriveTrigger.node.ts
View file

@ -187,12 +187,13 @@ export class PipedriveTrigger implements INodeType {
webhookMethods = { webhookMethods = {
default: { default: {
async checkExists(this: IHookFunctions): Promise<boolean> { async checkExists(this: IHookFunctions): Promise<boolean> {
const webhookUrl = this.getNodeWebhookUrl('default');
const webhookData = this.getWorkflowStaticData('node'); const webhookData = this.getWorkflowStaticData('node');
if (webhookData.webhookId === undefined) { const eventAction = this.getNodeParameter('action') as string;
// No webhook id is set so no webhook can exist
return false; const eventObject = this.getNodeParameter('object') as string;
}
// Webhook got created before so check if it still exists // Webhook got created before so check if it still exists
const endpoint = `/webhooks`; const endpoint = `/webhooks`;
@ -204,8 +205,11 @@ export class PipedriveTrigger implements INodeType {
} }
for (const existingData of responseData.data) { for (const existingData of responseData.data) {
if (existingData.id === webhookData.webhookId) { if (existingData.subscription_url === webhookUrl
&& existingData.event_action === eventAction
&& existingData.event_object === eventObject) {
// The webhook exists already // The webhook exists already
webhookData.webhookId = existingData.id;
return true; return true;
} }
} }