mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-02-21 02:56:40 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(core): Fix issue that parameters got lost in some edge cases

Browse source
This commit is contained in:
Jan Oberhauser 2022-06-11 18:12:04 +02:00
parent eec12f28d6
commit 04f0bf5b65
2 changed files with 34 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/workflow/src/NodeHelpers.ts
View file

@ -823,7 +823,7 @@ export function getNodeParameters(
Object.keys(propertyValues || {}).forEach((value) => {
returnValue[value] = {};
});
return { [nodeProperties.name]: returnValue };
nodeParameters[nodeProperties.name] = returnValue;
}
if (Object.keys(collectionValues).length !== 0 || returnDefaults) {

39
packages/workflow/test/NodeHelpers.test.ts
View file

@ -3010,9 +3010,15 @@ describe('Workflow', () => {
},
{
description:
'complex type "collection" which contains a "fixedCollection" with "multipleValues: false" that has a collection value added but nothing to the fixedCollection',
'complex type "collection" which contains a "fixedCollection" with "multipleValues: false" that has all values set to the default values (by having it as an empty object) in combination with another value',
input: {
nodePropertiesArray: [
{
name: 'mode',
displayName: 'mode',
type: 'string',
default: 'mode1',
},
{
displayName: 'Options',
name: 'options',
@ -3065,33 +3071,54 @@ describe('Workflow', () => {
},
],
nodeValues: {
mode: 'changed',
options: {
sort: {},
sort: {
value: {},
},
},
},
},
output: {
noneDisplayedFalse: {
defaultsFalse: {
mode: 'changed',
options: {
sort: {},
sort: {
value: {},
},
},
},
defaultsTrue: {
mode: 'changed',
options: {
sort: {},
sort: {
value: {
descending: true,
ordering: 'date',
},
},
},
},
},
noneDisplayedTrue: {
defaultsFalse: {
mode: 'changed',
options: {
sort: {},
sort: {
value: {},
},
},
},
defaultsTrue: {
mode: 'changed',
options: {
sort: {},
sort: {
value: {
descending: true,
ordering: 'date',
},
},
},
},
},