fix(core): Fix issue that parameters got lost in some edge cases

This commit is contained in:
Jan Oberhauser 2022-06-11 18:12:04 +02:00
parent eec12f28d6
commit 04f0bf5b65
2 changed files with 34 additions and 7 deletions

View file

@ -823,7 +823,7 @@ export function getNodeParameters(
Object.keys(propertyValues || {}).forEach((value) => { Object.keys(propertyValues || {}).forEach((value) => {
returnValue[value] = {}; returnValue[value] = {};
}); });
return { [nodeProperties.name]: returnValue }; nodeParameters[nodeProperties.name] = returnValue;
} }
if (Object.keys(collectionValues).length !== 0 || returnDefaults) { if (Object.keys(collectionValues).length !== 0 || returnDefaults) {

View file

@ -3010,9 +3010,15 @@ describe('Workflow', () => {
}, },
{ {
description: description:
'complex type "collection" which contains a "fixedCollection" with "multipleValues: false" that has a collection value added but nothing to the fixedCollection', 'complex type "collection" which contains a "fixedCollection" with "multipleValues: false" that has all values set to the default values (by having it as an empty object) in combination with another value',
input: { input: {
nodePropertiesArray: [ nodePropertiesArray: [
{
name: 'mode',
displayName: 'mode',
type: 'string',
default: 'mode1',
},
{ {
displayName: 'Options', displayName: 'Options',
name: 'options', name: 'options',
@ -3065,33 +3071,54 @@ describe('Workflow', () => {
}, },
], ],
nodeValues: { nodeValues: {
mode: 'changed',
options: { options: {
sort: {}, sort: {
value: {},
},
}, },
}, },
}, },
output: { output: {
noneDisplayedFalse: { noneDisplayedFalse: {
defaultsFalse: { defaultsFalse: {
mode: 'changed',
options: { options: {
sort: {}, sort: {
value: {},
},
}, },
}, },
defaultsTrue: { defaultsTrue: {
mode: 'changed',
options: { options: {
sort: {}, sort: {
value: {
descending: true,
ordering: 'date',
},
},
}, },
}, },
}, },
noneDisplayedTrue: { noneDisplayedTrue: {
defaultsFalse: { defaultsFalse: {
mode: 'changed',
options: { options: {
sort: {}, sort: {
value: {},
},
}, },
}, },
defaultsTrue: { defaultsTrue: {
mode: 'changed',
options: { options: {
sort: {}, sort: {
value: {
descending: true,
ordering: 'date',
},
},
}, },
}, },
}, },