mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-24 04:04:06 -08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

fix(Microsoft Outlook Node): Download executes more than once per incoming item (#8566)

Browse source
This commit is contained in:
Michael Kret 2024-02-07 15:18:00 +02:00 committed by GitHub
parent 7531f34386
commit 053fb5ff7a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
packages/nodes-base/nodes/Microsoft/Outlook/v2/actions/messageAttachment/download.operation.ts
View file

@ -49,7 +49,7 @@ export async function execute(this: IExecuteFunctions, index: number, items: INo
if (attachmentDetails.contentType) {
mimeType = attachmentDetails.contentType;
}
const fileName = attachmentDetails.name;
const fileName = attachmentDetails.name as string;
const response = await microsoftApiRequest.call(
this,
@ -74,13 +74,17 @@ export async function execute(this: IExecuteFunctions, index: number, items: INo
Object.assign(newItem.binary!, items[index].binary);
}
items[index] = newItem;
const data = Buffer.from(response.body as string, 'utf8');
items[index].binary![dataPropertyNameDownload] = await this.helpers.prepareBinaryData(
data as unknown as Buffer,
fileName as string,
newItem.binary![dataPropertyNameDownload] = await this.helpers.prepareBinaryData(
data,
fileName,
mimeType,
);
return items;
const executionData = this.helpers.constructExecutionMetaData(
this.helpers.returnJsonArray(newItem),
{ itemData: { item: index } },
);
return executionData;
}