mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-01-11 12:57:29 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(HTTP Request Node): Delete response.request only when it's a valid circular references (#8293)

Browse source
This commit is contained in:
कारतोफ्फेलस्क्रिप्ट™ 2024-01-10 18:05:19 +01:00 committed by GitHub
parent 8c7f39907f
commit 05c43faa2d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/nodes-base/nodes/HttpRequest/V1/HttpRequestV1.node.ts
View file

@ -994,7 +994,7 @@ export class HttpRequestV1 implements INodeType {
} }
response = response.value; response = response.value;
delete response.request; if (response?.request?.constructor.name === 'ClientRequest') delete response.request;
const options = this.getNodeParameter('options', itemIndex, {}); const options = this.getNodeParameter('options', itemIndex, {});

2
packages/nodes-base/nodes/HttpRequest/V2/HttpRequestV2.node.ts
View file

@ -1047,7 +1047,7 @@ export class HttpRequestV2 implements INodeType {
} }
response = response.value; response = response.value;
delete response.request; if (response?.request?.constructor.name === 'ClientRequest') delete response.request;
const options = this.getNodeParameter('options', itemIndex, {}); const options = this.getNodeParameter('options', itemIndex, {});

3
packages/nodes-base/nodes/HttpRequest/V3/HttpRequestV3.node.ts
View file

@ -1786,7 +1786,8 @@ export class HttpRequestV3 implements INodeType {
// eslint-disable-next-line prefer-const // eslint-disable-next-line prefer-const
for (let [index, response] of Object.entries(responses)) { for (let [index, response] of Object.entries(responses)) {
delete response.request; if (response?.request?.constructor.name === 'ClientRequest') delete response.request;
if (this.getMode() === 'manual' && index === '0') { if (this.getMode() === 'manual' && index === '0') {
// For manual executions save the first response in the context // For manual executions save the first response in the context
// so that we can use it in the frontend and so make it easier for // so that we can use it in the frontend and so make it easier for