mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-02-02 07:01:30 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

feat(editor): Open NDV when a node is added to canvas v2 (no-changelog) (#10114)

Browse source
This commit is contained in:
Elias Meire 2024-07-19 14:29:11 +02:00 committed by GitHub
parent 4559e3ae18
commit 062633ec9b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 21 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
packages/editor-ui/src/composables/__tests__/useCanvasOperations.spec.ts
View file

@ -167,6 +167,20 @@ describe('useCanvasOperations', () => {
}); });
expect(result.credentials).toBeUndefined(); expect(result.credentials).toBeUndefined();
}); });
it('should open NDV when specified', async () => {
nodeTypesStore.setNodeTypes([mockNodeTypeDescription({ name: 'type' })]);
await canvasOperations.addNode(
{
type: 'type',
name: 'Test Name',
},
{ openNDV: true },
);
expect(ndvStore.activeNodeName).toBe('Test Name');
});
}); });
describe('updateNodePosition', () => { describe('updateNodePosition', () => {

8
packages/editor-ui/src/composables/useCanvasOperations.ts
View file

@ -76,7 +76,7 @@ import type {
import { NodeConnectionType, NodeHelpers, TelemetryHelpers } from 'n8n-workflow'; import { NodeConnectionType, NodeHelpers, TelemetryHelpers } from 'n8n-workflow';
import { v4 as uuid } from 'uuid'; import { v4 as uuid } from 'uuid';
import type { Ref } from 'vue'; import type { Ref } from 'vue';
import { computed } from 'vue'; import { computed, nextTick } from 'vue';
import type { useRouter } from 'vue-router'; import type { useRouter } from 'vue-router';
type AddNodeData = Partial<INodeUi> & { type AddNodeData = Partial<INodeUi> & {
@ -429,6 +429,12 @@ export function useCanvasOperations({
workflowsStore.setNodePristine(nodeData.name, true); workflowsStore.setNodePristine(nodeData.name, true);
uiStore.stateIsDirty = true; uiStore.stateIsDirty = true;
if (options.openNDV) {
void nextTick(() => {
ndvStore.setActiveNodeName(nodeData.name);
});
}
return nodeData; return nodeData;
} }