mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(editor): Prevent duplicate creation of credential for OAuth2 (#7163)

Browse source 
This PR solves the issue reported in [this
ticket](https://linear.app/n8n/issue/PAY-825/click-to-connect-for-google-sheets-does-not-work-when-cred-is-not).

Basically when trying to connect OAuth2 credentials, n8n would create
the credential twice, possibly causing transaction issues.

This PR prevents n8n from firing a duplicate creation request,
effectively fixing the bug about duplicate creation.
This commit is contained in:
Csaba Tuncsik 2023-09-13 17:28:43 +02:00 committed by GitHub
parent c11dfbbe00
commit 07a6417f0f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
packages/editor-ui/src/components/CredentialEdit/GoogleAuthButton.vue
View file

@ -2,7 +2,6 @@
<button <button
:class="$style.googleAuthBtn" :class="$style.googleAuthBtn"
:title="$locale.baseText('credentialEdit.oAuthButton.signInWithGoogle')" :title="$locale.baseText('credentialEdit.oAuthButton.signInWithGoogle')"
@click.stop.prevent="$emit('click')"
:style="googleAuthButtons" :style="googleAuthButtons"
/> />
</template> </template>

2
packages/editor-ui/src/components/CredentialEdit/OauthButton.vue
View file

@ -1,6 +1,6 @@
<template> <template>
<div :class="$style.container"> <div :class="$style.container">
<GoogleAuthButton v-if="isGoogleOAuthType" @click="$emit('click')" /> <GoogleAuthButton v-if="isGoogleOAuthType" @click.stop="$emit('click')" />
<n8n-button <n8n-button
v-else v-else
:label="$locale.baseText('credentialEdit.oAuthButton.connectMyAccount')" :label="$locale.baseText('credentialEdit.oAuthButton.connectMyAccount')"