mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-09-19 22:37:31 -07:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

fix: Small changes to user activation modal (no-changelog) (#5962)

Browse source
This commit is contained in:
Ricardo Espinoza 2023-04-18 07:28:50 -04:00 committed by GitHub
parent c171365d2a
commit 0c10fbc83f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
cypress/e2e/22-user-activation-modal.cy.ts
View file

@ -45,13 +45,20 @@ describe('User activation survey', () => {
workflowPage.actions.activateWorkflow();
cy.intercept('GET', '/rest/workflows').as('getWorkflows');
cy.intercept('GET', '/rest/credentials').as('getCredentials');
cy.intercept('GET', '/rest/active').as('getActive');
cy.request(method, `${BASE_WEBHOOK_URL}/${path}`).then((response) => {
expect(response.status).to.eq(200);
cy.visit('/');
cy.reload();
cy.wait(['@getWorkflows', '@getCredentials', '@getActive']);
userActivationSurveyModal.getters.modalContainer().should('be.visible');
userActivationSurveyModal.getters.feedbackInput().should('be.visible');
userActivationSurveyModal.getters.feedbackInput().type('testing');
userActivationSurveyModal.getters.feedbackInput().should('have.value', 'testing');
userActivationSurveyModal.getters.sendFeedbackButton().click();
});
});

8
packages/editor-ui/src/components/UserActivationSurveyModal.vue
View file

@ -15,7 +15,7 @@
<n8n-text :bold="true"> {{ workflowName }} </n8n-text>
</template>
<template #ranSuccessfully>
<n8n-text :bold="true" :class="$style.link">
<n8n-text>
{{
locale.baseText('userActivationSurveyModal.description.workflowRanSuccessfully')
}}
@ -90,7 +90,7 @@ onMounted(async () => {
currentSettings?.firstSuccessfulWorkflowId ?? '',
);
workflowName.value = name;
showConfetti();
setTimeout(showConfetti, 500);
} catch (e) {}
});
@ -157,10 +157,6 @@ const showConfetti = () => {
margin-top: var(--spacing-l);
}
.link {
color: var(--color-primary);
}
.description > * {
font-size: var(--font-size-s);
}

4
packages/editor-ui/src/main.ts
View file

@ -49,9 +49,7 @@ router.afterEach((to, from) => {
runExternalHook('main.routeChange', useWebhooksStore(), { from, to });
const userStore = useUsersStore();
if (userStore.currentUser && to.name && to.name !== VIEWS.SIGNOUT && !to.name.includes('Modal')) {
setTimeout(() => {
userStore.showUserActivationSurveyModal();
}, 500);
userStore.showUserActivationSurveyModal();
}
});