From 0ce26d48e0267d705ec5fe0346fe5d30f25d0990 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Iv=C3=A1n=20Ovejero?= <ivov.src@gmail.com>
Date: Thu, 23 Dec 2021 12:21:27 +0100
Subject: [PATCH] :zap: Minor i18n fixes (#2585)

* :zap: Make subcategory render keys consistent

* :zap: Add missing or key

* :zap: Fix default text for multiple value button

* :zap: Simplify subcategory extraction
---
 packages/editor-ui/src/components/MultipleParameter.vue  | 4 ++--
 .../editor-ui/src/components/NodeCreator/NoResults.vue   | 2 +-
 .../src/components/NodeCreator/SubcategoryItem.vue       | 6 +-----
 packages/editor-ui/src/plugins/i18n/locales/en.json      | 9 +++++----
 4 files changed, 9 insertions(+), 12 deletions(-)

diff --git a/packages/editor-ui/src/components/MultipleParameter.vue b/packages/editor-ui/src/components/MultipleParameter.vue
index a3b0ea4b33..f06e17df60 100644
--- a/packages/editor-ui/src/components/MultipleParameter.vue
+++ b/packages/editor-ui/src/components/MultipleParameter.vue
@@ -65,8 +65,8 @@ export default mixins(genericHelpers)
 		computed: {
 			addButtonText (): string {
 				if (
-					!this.parameter.typeOptions &&
-					!this.parameter.typeOptions.multipleValueButtonText
+					!this.parameter.typeOptions ||
+					(this.parameter.typeOptions && !this.parameter.typeOptions.multipleValueButtonText)
 				) {
 					return this.$locale.baseText('multipleParameter.addItem');
 				}
diff --git a/packages/editor-ui/src/components/NodeCreator/NoResults.vue b/packages/editor-ui/src/components/NodeCreator/NoResults.vue
index 42b156e5e3..3616a58ff7 100644
--- a/packages/editor-ui/src/components/NodeCreator/NoResults.vue
+++ b/packages/editor-ui/src/components/NodeCreator/NoResults.vue
@@ -9,7 +9,7 @@
 			</div>
 			<div class="action">
 				{{ $locale.baseText('nodeCreator.noResults.dontWorryYouCanProbablyDoItWithThe') }}
-				<a @click="selectHttpRequest">{{ $locale.baseText('nodeCreator.noResults.httpRequest') }}</a> or
+				<a @click="selectHttpRequest">{{ $locale.baseText('nodeCreator.noResults.httpRequest') }}</a> {{ $locale.baseText('nodeCreator.noResults.or') }}
 				<a @click="selectWebhook">{{ $locale.baseText('nodeCreator.noResults.webhook') }}</a> {{ $locale.baseText('nodeCreator.noResults.node') }}
 			</div>
 		</div>
diff --git a/packages/editor-ui/src/components/NodeCreator/SubcategoryItem.vue b/packages/editor-ui/src/components/NodeCreator/SubcategoryItem.vue
index 547de84dea..024ec2434a 100644
--- a/packages/editor-ui/src/components/NodeCreator/SubcategoryItem.vue
+++ b/packages/editor-ui/src/components/NodeCreator/SubcategoryItem.vue
@@ -5,7 +5,7 @@
 				{{ $locale.baseText(`nodeCreator.subcategoryNames.${subcategoryName}`) }}
 			</div>
 			<div v-if="item.properties.description" :class="$style.description">
-				{{ $locale.baseText(`nodeCreator.subcategoryDescriptions.${subcategoryDescription}`) }}
+				{{ $locale.baseText(`nodeCreator.subcategoryDescriptions.${subcategoryName}`) }}
 			</div>
 		</div>
 		<div :class="$style.action">
@@ -24,10 +24,6 @@ export default Vue.extend({
 		subcategoryName() {
 			return camelcase(this.item.properties.subcategory);
 		},
-		subcategoryDescription() {
-			const firstWord = this.item.properties.description.split(' ').shift() || '';
-			return firstWord.toLowerCase().replace(/,/g, '');
-		},
 	},
 });
 </script>
diff --git a/packages/editor-ui/src/plugins/i18n/locales/en.json b/packages/editor-ui/src/plugins/i18n/locales/en.json
index dd979ce8e9..11e03c0a94 100644
--- a/packages/editor-ui/src/plugins/i18n/locales/en.json
+++ b/packages/editor-ui/src/plugins/i18n/locales/en.json
@@ -413,6 +413,7 @@
 			"dontWorryYouCanProbablyDoItWithThe": "Don’t worry, you can probably do it with the",
 			"httpRequest": "HTTP Request",
 			"node": "node",
+			"or": "or",
 			"requestTheNode": "Request the node",
 			"wantUsToMakeItFaster": "Want us to make it faster?",
 			"weDidntMakeThatYet": "We didn't make that... yet",
@@ -422,10 +423,10 @@
 			"searchNodes": "Search nodes..."
 		},
 		"subcategoryDescriptions": {
-			"branches": "Branches, core triggers, merge data",
-			"http": "HTTP Requests (API calls), date and time, scrape HTML",
-			"manipulate": "Manipulate data fields, run code",
-			"work": "Work with CSV, XML, text, images etc."
+			"dataTransformation": "Manipulate data fields, run code",
+			"files": "Work with CSV, XML, text, images etc.",
+			"flow": "Branches, core triggers, merge data",
+			"helpers": "HTTP Requests (API calls), date and time, scrape HTML"
 		},
 		"subcategoryNames": {
 			"dataTransformation": "Data Transformation",