mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-24 20:24:05 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

test(core): fix spy in EE credentials tests (#4369)

Browse source 
🧪 Fix spy in EE credentials tests
This commit is contained in:
Iván Ovejero 2022-10-20 09:25:39 +02:00 committed by GitHub
parent 4ce0fed0ab
commit 0e044f7684
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
packages/cli/test/integration/credentials.ee.test.ts
View file

@ -2,7 +2,7 @@ import express from 'express';
import { UserSettings } from 'n8n-core'; import { UserSettings } from 'n8n-core';
import { In } from 'typeorm'; import { In } from 'typeorm';
import { Db, IUser } from '../../src'; import { Db } from '../../src';
import { RESPONSE_ERROR_MESSAGES } from '../../src/constants'; import { RESPONSE_ERROR_MESSAGES } from '../../src/constants';
import type { CredentialWithSharings } from '../../src/credentials/credentials.types'; import type { CredentialWithSharings } from '../../src/credentials/credentials.types';
import * as UserManagementHelpers from '../../src/UserManagement/UserManagementHelper'; import * as UserManagementHelpers from '../../src/UserManagement/UserManagementHelper';
@ -11,13 +11,10 @@ import { randomCredentialPayload } from './shared/random';
import * as testDb from './shared/testDb'; import * as testDb from './shared/testDb';
import type { AuthAgent, SaveCredentialFunction } from './shared/types'; import type { AuthAgent, SaveCredentialFunction } from './shared/types';
import * as utils from './shared/utils'; import * as utils from './shared/utils';
import type { IUser } from 'n8n-workflow';
jest.mock('../../src/telemetry'); jest.mock('../../src/telemetry');
// mock whether credentialsSharing is enabled or not
const mockIsCredentialsSharingEnabled = jest.spyOn(UserManagementHelpers, 'isSharingEnabled');
mockIsCredentialsSharingEnabled.mockReturnValue(true);
let app: express.Application; let app: express.Application;
let testDbName = ''; let testDbName = '';
let globalOwnerRole: Role; let globalOwnerRole: Role;
@ -25,6 +22,7 @@ let globalMemberRole: Role;
let credentialOwnerRole: Role; let credentialOwnerRole: Role;
let saveCredential: SaveCredentialFunction; let saveCredential: SaveCredentialFunction;
let authAgent: AuthAgent; let authAgent: AuthAgent;
let sharingSpy: jest.SpyInstance<boolean>;
beforeAll(async () => { beforeAll(async () => {
app = await utils.initTestServer({ app = await utils.initTestServer({
@ -45,6 +43,8 @@ beforeAll(async () => {
utils.initTestLogger(); utils.initTestLogger();
utils.initTestTelemetry(); utils.initTestTelemetry();
sharingSpy = jest.spyOn(UserManagementHelpers, 'isSharingEnabled').mockReturnValue(true);
}); });
beforeEach(async () => { beforeEach(async () => {
@ -65,7 +65,7 @@ test('router should switch based on flag', async () => {
const savedCredential = await saveCredential(randomCredentialPayload(), { user: owner }); const savedCredential = await saveCredential(randomCredentialPayload(), { user: owner });
// free router // free router
mockIsCredentialsSharingEnabled.mockReturnValueOnce(false); sharingSpy.mockReturnValueOnce(false);
const freeShareResponse = authAgent(owner) const freeShareResponse = authAgent(owner)
.put(`/credentials/${savedCredential.id}/share`) .put(`/credentials/${savedCredential.id}/share`)
@ -82,7 +82,6 @@ test('router should switch based on flag', async () => {
expect(freeGetStatus).toBe(200); expect(freeGetStatus).toBe(200);
// EE router // EE router
mockIsCredentialsSharingEnabled.mockReturnValueOnce(true);
const eeShareResponse = authAgent(owner) const eeShareResponse = authAgent(owner)
.put(`/credentials/${savedCredential.id}/share`) .put(`/credentials/${savedCredential.id}/share`)