mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(editor): Curb arg linting for $input.first() and $input.last() (#4526)

Browse source 
🐛 Curb arg linting
This commit is contained in:
Iván Ovejero 2022-11-04 17:24:29 +01:00 committed by GitHub
parent 39d4bb2639
commit 0edd4bcc87
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
packages/editor-ui/src/components/CodeNodeEditor/linter.ts
View file

@ -267,34 +267,38 @@ export const linterExtension = (Vue as CodeNodeEditorMixin).extend({
} }
/** /**
* Lint for `.first()` or `.last()` called with argument in `runOnceForAllItems` mode * Lint for `$input.first()` or `$input.last()` called with argument in `runOnceForAllItems` mode
* *
* $input.itemMatching() * $input.first(arg) -> $input.first()
* $input.last(arg) -> $input.last()
*/ */
if (this.mode === 'runOnceForAllItems') { if (this.mode === 'runOnceForAllItems') {
type TargetNode = RangeNode & { type TargetNode = RangeNode & {
callee: RangeNode & { property: { name: string } & RangeNode }; callee: { property: { name: string } & RangeNode };
}; };
const isItemMatchingCallWithoutArg = (node: Node) => const inputFirstOrLastCalledWithArg = (node: Node) =>
node.type === 'CallExpression' && node.type === 'CallExpression' &&
node.callee.type === 'MemberExpression' && node.callee.type === 'MemberExpression' &&
node.callee.computed === false &&
node.callee.object.type === 'Identifier' &&
node.callee.object.name === '$input' &&
node.callee.property.type === 'Identifier' && node.callee.property.type === 'Identifier' &&
['first', 'last'].includes(node.callee.property.name) && ['first', 'last'].includes(node.callee.property.name)
node.arguments.length !== 0; && node.arguments.length !== 0;
walk<TargetNode>(ast, isItemMatchingCallWithoutArg).forEach((node) => { walk<TargetNode>(ast, inputFirstOrLastCalledWithArg).forEach((node) => {
const [start, end] = this.getRange(node.callee.property); const [start, end] = this.getRange(node.callee.property);
const message = [ const message = [
`\`.${node.callee.property.name}()\``, `\`$input.${node.callee.property.name}()\``,
this.$locale.baseText('codeNodeEditor.linter.allItems.firstOrLastCalledWithArg'), this.$locale.baseText('codeNodeEditor.linter.allItems.firstOrLastCalledWithArg'),
].join(' '); ].join(' ');
lintings.push({ lintings.push({
from: start, from: start,
to: end + '()'.length, to: end,
severity: DEFAULT_LINTER_SEVERITY, severity: DEFAULT_LINTER_SEVERITY,
message, message,
}); });