From 0fda8d9aacb7b8c6f09b3ed7d016d9bcc1e88561 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Iv=C3=A1n=20Ovejero?= Date: Fri, 17 Nov 2023 17:49:28 +0100 Subject: [PATCH] refactor(core): Stop reporting to Sentry `NodeApiError` outside 500 range (no-changelog) (#7753) https://n8nio.sentry.io/issues/4312838883 (and many others) Followup to https://github.com/n8n-io/n8n/pull/7662 --- packages/workflow/src/NodeErrors.ts | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/packages/workflow/src/NodeErrors.ts b/packages/workflow/src/NodeErrors.ts index 8abfcefac8..9ad7ca1d5f 100644 --- a/packages/workflow/src/NodeErrors.ts +++ b/packages/workflow/src/NodeErrors.ts @@ -357,9 +357,6 @@ export class NodeApiError extends NodeError { ) { super(node, error); - if (severity) this.severity = severity; - else if (httpCode?.charAt(0) !== '5') this.severity = 'warning'; - // only for request library error if (error.error) { removeCircularRefs(error.error as JsonObject); @@ -401,6 +398,12 @@ export class NodeApiError extends NodeError { this.findProperty(error, ERROR_STATUS_PROPERTIES, ERROR_NESTING_PROPERTIES) ?? null; } + if (severity) { + this.severity = severity; + } else if (this.httpCode?.charAt(0) !== '5') { + this.severity = 'warning'; + } + // set description of this error if (description) { this.description = description;