mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

chore: Fix flaky cypress tests (no-changelog) (#11894)

Browse source
This commit is contained in:
Eugene 2024-11-26 13:57:00 +01:00 committed by GitHub
parent bc4857a1b3
commit 10e011d71e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 15 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
cypress/e2e/17-sharing.cy.ts
View file

@ -88,7 +88,7 @@ describe('Sharing', { disableAutoLogin: true }, () => {
cy.visit(workflowsPage.url); cy.visit(workflowsPage.url);
workflowsPage.getters.workflowCards().should('have.length', 1); workflowsPage.getters.workflowCards().should('have.length', 1);
workflowsPage.getters.workflowCard('Workflow W1').click(); workflowsPage.getters.workflowCardContent('Workflow W1').click();
workflowPage.actions.addNodeToCanvas('Airtable', true, true); workflowPage.actions.addNodeToCanvas('Airtable', true, true);
ndv.getters.credentialInput().find('input').should('have.value', 'Credential C2'); ndv.getters.credentialInput().find('input').should('have.value', 'Credential C2');
ndv.actions.close(); ndv.actions.close();
@ -104,7 +104,7 @@ describe('Sharing', { disableAutoLogin: true }, () => {
cy.visit(workflowsPage.url); cy.visit(workflowsPage.url);
workflowsPage.getters.workflowCards().should('have.length', 2); workflowsPage.getters.workflowCards().should('have.length', 2);
workflowsPage.getters.workflowCard('Workflow W1').click(); workflowsPage.getters.workflowCardContent('Workflow W1').click();
workflowPage.actions.addNodeToCanvas('Airtable', true, true); workflowPage.actions.addNodeToCanvas('Airtable', true, true);
ndv.getters.credentialInput().find('input').should('have.value', 'Credential C2'); ndv.getters.credentialInput().find('input').should('have.value', 'Credential C2');
ndv.actions.close(); ndv.actions.close();
@ -133,7 +133,7 @@ describe('Sharing', { disableAutoLogin: true }, () => {
cy.visit(workflowsPage.url); cy.visit(workflowsPage.url);
workflowsPage.getters.workflowCards().should('have.length', 2); workflowsPage.getters.workflowCards().should('have.length', 2);
workflowsPage.getters.workflowCard('Workflow W1').click(); workflowsPage.getters.workflowCardContent('Workflow W1').click();
workflowPage.actions.openNode('Notion'); workflowPage.actions.openNode('Notion');
ndv.getters ndv.getters
.credentialInput() .credentialInput()
@ -144,7 +144,7 @@ describe('Sharing', { disableAutoLogin: true }, () => {
cy.waitForLoad(); cy.waitForLoad();
cy.visit(workflowsPage.url); cy.visit(workflowsPage.url);
workflowsPage.getters.workflowCard('Workflow W2').click('top'); workflowsPage.getters.workflowCardContent('Workflow W2').click('top');
workflowPage.actions.executeWorkflow(); workflowPage.actions.executeWorkflow();
}); });
@ -353,7 +353,7 @@ describe('Credential Usage in Cross Shared Workflows', () => {
credentialsPage.getters.emptyListCreateCredentialButton().click(); credentialsPage.getters.emptyListCreateCredentialButton().click();
credentialsModal.actions.createNewCredential('Notion API'); credentialsModal.actions.createNewCredential('Notion API');
cy.visit(workflowsPage.url); cy.visit(workflowsPage.url);
workflowsPage.getters.workflowCard(workflowName).click(); workflowsPage.getters.workflowCardContent(workflowName).click();
workflowPage.actions.addNodeToCanvas(NOTION_NODE_NAME, true, true); workflowPage.actions.addNodeToCanvas(NOTION_NODE_NAME, true, true);
// Only the own credential the shared one (+ the 'Create new' option) // Only the own credential the shared one (+ the 'Create new' option)
@ -398,7 +398,7 @@ describe('Credential Usage in Cross Shared Workflows', () => {
credentialsPage.getters.createCredentialButton().click(); credentialsPage.getters.createCredentialButton().click();
credentialsModal.actions.createNewCredential('Notion API'); credentialsModal.actions.createNewCredential('Notion API');
cy.visit(workflowsPage.url); cy.visit(workflowsPage.url);
workflowsPage.getters.workflowCard(workflowName).click(); workflowsPage.getters.workflowCardContent(workflowName).click();
workflowPage.actions.addNodeToCanvas(NOTION_NODE_NAME, true, true); workflowPage.actions.addNodeToCanvas(NOTION_NODE_NAME, true, true);
// Only the personal credentials of the workflow owner and the global owner // Only the personal credentials of the workflow owner and the global owner

4
cypress/e2e/39-projects.cy.ts
View file

@ -186,7 +186,7 @@ describe('Projects', { disableAutoLogin: true }, () => {
menuItems.filter(':contains("Development")[class*=active_]').should('exist'); menuItems.filter(':contains("Development")[class*=active_]').should('exist');
cy.intercept('GET', '/rest/workflows/*').as('loadWorkflow'); cy.intercept('GET', '/rest/workflows/*').as('loadWorkflow');
workflowsPage.getters.workflowCards().first().click(); workflowsPage.getters.workflowCards().first().findChildByTestId('card-content').click();
cy.wait('@loadWorkflow'); cy.wait('@loadWorkflow');
menuItems = cy.getByTestId('menu-item'); menuItems = cy.getByTestId('menu-item');
@ -747,7 +747,7 @@ describe('Projects', { disableAutoLogin: true }, () => {
// Open the moved workflow // Open the moved workflow
workflowsPage.getters.workflowCards().should('have.length', 1); workflowsPage.getters.workflowCards().should('have.length', 1);
workflowsPage.getters.workflowCards().first().click(); workflowsPage.getters.workflowCards().first().findChildByTestId('card-content').click();
// Check if the credential can be changed // Check if the credential can be changed
workflowPage.getters.canvasNodeByName(NOTION_NODE_NAME).should('be.visible').dblclick(); workflowPage.getters.canvasNodeByName(NOTION_NODE_NAME).should('be.visible').dblclick();

2
cypress/pages/workflows.ts
View file

@ -56,6 +56,8 @@ export class WorkflowsPage extends BasePage {
.parents('[data-test-id="resources-list-item"]'), .parents('[data-test-id="resources-list-item"]'),
workflowTags: (workflowName: string) => workflowTags: (workflowName: string) =>
this.getters.workflowCard(workflowName).findChildByTestId('workflow-card-tags'), this.getters.workflowCard(workflowName).findChildByTestId('workflow-card-tags'),
workflowCardContent: (workflowName: string) =>
this.getters.workflowCard(workflowName).findChildByTestId('card-content'),
workflowActivator: (workflowName: string) => workflowActivator: (workflowName: string) =>
this.getters.workflowCard(workflowName).findChildByTestId('workflow-card-activator'), this.getters.workflowCard(workflowName).findChildByTestId('workflow-card-activator'),
workflowActivatorStatus: (workflowName: string) => workflowActivatorStatus: (workflowName: string) =>

6
packages/design-system/src/components/N8nCard/Card.vue
View file

@ -20,10 +20,10 @@ const classes = computed(() => ({
<template> <template>
<div :class="classes" v-bind="$attrs"> <div :class="classes" v-bind="$attrs">
<div v-if="$slots.prepend" :class="$style.icon"> <div v-if="$slots.prepend" data-test-id="card-prepend" :class="$style.icon">
<slot name="prepend" /> <slot name="prepend" />
</div> </div>
<div :class="$style.content"> <div :class="$style.content" data-test-id="card-content">
<div v-if="$slots.header" :class="$style.header"> <div v-if="$slots.header" :class="$style.header">
<slot name="header" /> <slot name="header" />
</div> </div>
@ -34,7 +34,7 @@ const classes = computed(() => ({
<slot name="footer" /> <slot name="footer" />
</div> </div>
</div> </div>
<div v-if="$slots.append" :class="$style.append"> <div v-if="$slots.append" data-test-id="card-append" :class="$style.append">
<slot name="append" /> <slot name="append" />
</div> </div>
</div> </div>

4
packages/design-system/src/components/N8nCard/__snapshots__/Card.test.ts.snap
View file

@ -3,7 +3,7 @@
exports[`components > N8nCard > should render correctly 1`] = ` exports[`components > N8nCard > should render correctly 1`] = `
"<div class="card"> "<div class="card">
<!--v-if--> <!--v-if-->
<div class="content"> <div class="content" data-test-id="card-content">
<!--v-if--> <!--v-if-->
<div class="body">This is a card.</div> <div class="body">This is a card.</div>
<!--v-if--> <!--v-if-->
@ -15,7 +15,7 @@ exports[`components > N8nCard > should render correctly 1`] = `
exports[`components > N8nCard > should render correctly with header and footer 1`] = ` exports[`components > N8nCard > should render correctly with header and footer 1`] = `
"<div class="card"> "<div class="card">
<!--v-if--> <!--v-if-->
<div class="content"> <div class="content" data-test-id="card-content">
<div class="header">Header</div> <div class="header">Header</div>
<div class="body">This is a card.</div> <div class="body">This is a card.</div>
<div class="footer">Footer</div> <div class="footer">Footer</div>