diff --git a/.github/workflows/e2e-tests-pr.yml b/.github/workflows/e2e-tests-pr.yml index 648383750d..4d6aea14cf 100644 --- a/.github/workflows/e2e-tests-pr.yml +++ b/.github/workflows/e2e-tests-pr.yml @@ -48,5 +48,5 @@ jobs: run: exit 0 - name: Fail job if run-e2e-tests failed - if: needs.run-e2e-tests.result == 'failure' + if: ${{ github.event.review.state != 'approved' || needs.run-e2e-tests.result == 'failure' }} run: exit 1 diff --git a/packages/editor-ui/src/plugins/i18n/docs/README.md b/packages/editor-ui/src/plugins/i18n/docs/README.md index 344ae7ab57..664c3e1a2f 100644 --- a/packages/editor-ui/src/plugins/i18n/docs/README.md +++ b/packages/editor-ui/src/plugins/i18n/docs/README.md @@ -507,3 +507,4 @@ After changing the dynamic text file: If a `headerText` section was changed, re-run `pnpm build:translations` in `/nodes-base`. > **Note**: To translate base and dynamic text simultaneously, run three terminals following the steps from both sections (first terminal running only once) and browse `http://localhost:8080`. +