mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-12 15:44:06 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix(core): Account for itemless case on restoring binary data ID (#7305)

Browse source 
https://linear.app/n8n/issue/PAY-862
This commit is contained in:
Iván Ovejero 2023-10-02 09:13:55 +02:00 committed by GitHub
parent d1b6c7fd79
commit 1691223789
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/cli/src/executionLifecycleHooks/restoreBinaryDataId.ts
View file

@ -25,7 +25,7 @@ export async function restoreBinaryDataId(run: IRun, executionId: string) {
const { runData } = run.data.resultData; const { runData } = run.data.resultData;
const promises = Object.keys(runData).map(async (nodeName) => { const promises = Object.keys(runData).map(async (nodeName) => {
const binaryDataId = runData[nodeName]?.[0]?.data?.main?.[0]?.[0].binary?.data.id; const binaryDataId = runData[nodeName]?.[0]?.data?.main?.[0]?.[0]?.binary?.data.id;
if (!binaryDataId || !isMissingExecutionId(binaryDataId)) return; if (!binaryDataId || !isMissingExecutionId(binaryDataId)) return;

12
packages/cli/test/unit/execution.lifecycle.test.ts
View file

@ -3,7 +3,7 @@ import { BinaryDataService } from 'n8n-core';
import { mockInstance } from '../integration/shared/utils/mocking'; import { mockInstance } from '../integration/shared/utils/mocking';
import type { IRun } from 'n8n-workflow'; import type { IRun } from 'n8n-workflow';
function toIRun(item: object) { function toIRun(item?: object) {
return { return {
data: { data: {
resultData: { resultData: {
@ -84,4 +84,14 @@ describe('restoreBinaryDataId()', () => {
expect(binaryDataService.rename).not.toHaveBeenCalled(); expect(binaryDataService.rename).not.toHaveBeenCalled();
expect(getDataId(run, 'json')).toBe(dataId); expect(getDataId(run, 'json')).toBe(dataId);
}); });
it('should do nothing on itemless case', async () => {
const executionId = '999';
const promise = restoreBinaryDataId(toIRun(), executionId);
await expect(promise).resolves.not.toThrow();
expect(binaryDataService.rename).not.toHaveBeenCalled();
});
}); });