mirror of
https://github.com/n8n-io/n8n.git
synced 2025-01-12 05:17:28 -08:00
🐛 Fix bug with displaying node-issues
This commit is contained in:
parent
bcaddecdd6
commit
16ba7e6ed7
|
@ -49,6 +49,11 @@ export const nodeHelpers = mixins(
|
||||||
let nodeIssues: INodeIssues | null = null;
|
let nodeIssues: INodeIssues | null = null;
|
||||||
ignoreIssues = ignoreIssues || [];
|
ignoreIssues = ignoreIssues || [];
|
||||||
|
|
||||||
|
if (node.disabled === true) {
|
||||||
|
// Ignore issues on disabled nodes
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
if (nodeType === null) {
|
if (nodeType === null) {
|
||||||
// Node type is not known
|
// Node type is not known
|
||||||
if (!ignoreIssues.includes('typeUnknown')) {
|
if (!ignoreIssues.includes('typeUnknown')) {
|
||||||
|
@ -127,13 +132,18 @@ export const nodeHelpers = mixins(
|
||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (nodeType!.credentials === undefined) {
|
||||||
|
// No credentials defined for node type
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
const foundIssues: INodeIssueObjectProperty = {};
|
const foundIssues: INodeIssueObjectProperty = {};
|
||||||
|
|
||||||
let userCredentials: ICredentialsResponse[] | null;
|
let userCredentials: ICredentialsResponse[] | null;
|
||||||
let credentialType: ICredentialType | null;
|
let credentialType: ICredentialType | null;
|
||||||
let credentialDisplayName: string;
|
let credentialDisplayName: string;
|
||||||
let selectedCredentials: string;
|
let selectedCredentials: string;
|
||||||
for (const credentialTypeDescription of nodeType!.credentials) {
|
for (const credentialTypeDescription of nodeType!.credentials!) {
|
||||||
// Check if credentials should be displayed else ignore
|
// Check if credentials should be displayed else ignore
|
||||||
if (this.displayParameter(node.parameters, credentialTypeDescription, '') !== true) {
|
if (this.displayParameter(node.parameters, credentialTypeDescription, '') !== true) {
|
||||||
continue;
|
continue;
|
||||||
|
|
|
@ -134,6 +134,7 @@ export const workflowHelpers = mixins(
|
||||||
node = workflow.nodes[nodeName];
|
node = workflow.nodes[nodeName];
|
||||||
|
|
||||||
if (node.disabled === true) {
|
if (node.disabled === true) {
|
||||||
|
// Ignore issues on disabled nodes
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -447,6 +447,11 @@ export function getNodeParametersIssues(nodePropertiesArray: INodeProperties[],
|
||||||
const foundIssues: INodeIssues = {};
|
const foundIssues: INodeIssues = {};
|
||||||
let propertyIssues: INodeIssues;
|
let propertyIssues: INodeIssues;
|
||||||
|
|
||||||
|
if (node.disabled === true) {
|
||||||
|
// Ignore issues on disabled nodes
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
for (const nodeProperty of nodePropertiesArray) {
|
for (const nodeProperty of nodePropertiesArray) {
|
||||||
propertyIssues = getParameterIssues(nodeProperty, node.parameters, '');
|
propertyIssues = getParameterIssues(nodeProperty, node.parameters, '');
|
||||||
mergeIssues(foundIssues, propertyIssues);
|
mergeIssues(foundIssues, propertyIssues);
|
||||||
|
|
Loading…
Reference in a new issue