mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-01-11 21:07:28 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

🐛 Fix bug with displaying node-issues

Browse source
This commit is contained in:
Jan Oberhauser 2019-07-07 19:17:34 +02:00
parent bcaddecdd6
commit 16ba7e6ed7
3 changed files with 17 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
packages/editor-ui/src/components/mixins/nodeHelpers.ts
View file

@ -49,6 +49,11 @@ export const nodeHelpers = mixins(
let nodeIssues: INodeIssues | null = null;
ignoreIssues = ignoreIssues || [];
if (node.disabled === true) {
// Ignore issues on disabled nodes
return null;
}
if (nodeType === null) {
// Node type is not known
if (!ignoreIssues.includes('typeUnknown')) {
@ -127,13 +132,18 @@ export const nodeHelpers = mixins(
return null;
}
if (nodeType!.credentials === undefined) {
// No credentials defined for node type
return null;
}
const foundIssues: INodeIssueObjectProperty = {};
let userCredentials: ICredentialsResponse[] | null;
let credentialType: ICredentialType | null;
let credentialDisplayName: string;
let selectedCredentials: string;
for (const credentialTypeDescription of nodeType!.credentials) {
for (const credentialTypeDescription of nodeType!.credentials!) {
// Check if credentials should be displayed else ignore
if (this.displayParameter(node.parameters, credentialTypeDescription, '') !== true) {
continue;

1
packages/editor-ui/src/components/mixins/workflowHelpers.ts
View file

@ -134,6 +134,7 @@ export const workflowHelpers = mixins(
node = workflow.nodes[nodeName];
if (node.disabled === true) {
// Ignore issues on disabled nodes
continue;
}

5
packages/workflow/src/NodeHelpers.ts
View file

@ -447,6 +447,11 @@ export function getNodeParametersIssues(nodePropertiesArray: INodeProperties[],
const foundIssues: INodeIssues = {};
let propertyIssues: INodeIssues;
if (node.disabled === true) {
// Ignore issues on disabled nodes
return null;
}
for (const nodeProperty of nodePropertiesArray) {
propertyIssues = getParameterIssues(nodeProperty, node.parameters, '');
mergeIssues(foundIssues, propertyIssues);