mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-24 20:24:05 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix: Better error message when calling data transformation functions on a null value (#10210)

Browse source
This commit is contained in:
Michael Kret 2024-07-26 20:04:55 +03:00 committed by GitHub
parent 6f1d4adf05
commit 1718125c6d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 5 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
packages/workflow/src/Extensions/utils.ts
View file

@ -21,12 +21,8 @@ export const convertToDateTime = (value: string | Date | DateTime): DateTime | u
export function checkIfValueDefinedOrThrow<T>(value: T, functionName: string): void { export function checkIfValueDefinedOrThrow<T>(value: T, functionName: string): void {
if (value === undefined || value === null) { if (value === undefined || value === null) {
throw new ExpressionExtensionError( throw new ExpressionExtensionError(`${functionName} can't be used on ${String(value)} value`, {
`${functionName}() could not be called on "${String(value)}" type`, description: `To ignore this error, add a ? to the variable before this function, e.g. my_var?.${functionName}`,
{ });
description:
'You are trying to access a field that does not exist, modify your expression or set a default value',
},
);
} }
} }

7
packages/workflow/test/ExpressionExtensions/ExpressionExtension.test.ts
View file

@ -250,10 +250,7 @@ describe('tmpl Expression Parser', () => {
extend(undefined, 'toDateTime', []); extend(undefined, 'toDateTime', []);
} catch (error) { } catch (error) {
expect(error).toBeInstanceOf(ExpressionExtensionError); expect(error).toBeInstanceOf(ExpressionExtensionError);
expect(error).toHaveProperty( expect(error).toHaveProperty('message', "toDateTime can't be used on undefined value");
'message',
'toDateTime() could not be called on "undefined" type',
);
} }
}); });
test('input is null', () => { test('input is null', () => {
@ -261,7 +258,7 @@ describe('tmpl Expression Parser', () => {
extend(null, 'startsWith', []); extend(null, 'startsWith', []);
} catch (error) { } catch (error) {
expect(error).toBeInstanceOf(ExpressionExtensionError); expect(error).toBeInstanceOf(ExpressionExtensionError);
expect(error).toHaveProperty('message', 'startsWith() could not be called on "null" type'); expect(error).toHaveProperty('message', "startsWith can't be used on null value");
} }
}); });
test('input should be converted to upper case', () => { test('input should be converted to upper case', () => {