mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-01-11 12:57:29 -08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

refactor(core): Convey error stack from job failure to main (#11261)

Browse source
This commit is contained in:
Iván Ovejero 2024-10-15 16:55:54 +02:00 committed by GitHub
parent 76ab780cdd
commit 190665d8e6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 14 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
packages/cli/src/scaling/scaling.service.ts
View file

@ -114,6 +114,7 @@ export class ScalingService {
executionId, executionId,
workerId: this.instanceSettings.hostId, workerId: this.instanceSettings.hostId,
errorMsg: error.message, errorMsg: error.message,
errorStack: error.stack ?? '',
}; };
await job.progress(msg); await job.progress(msg);
@ -295,12 +296,18 @@ export class ScalingService {
}); });
break; break;
case 'job-failed': case 'job-failed':
this.logger.error(`Execution ${msg.executionId} (job ${jobId}) failed`, { this.logger.error(
[
`Execution ${msg.executionId} (job ${jobId}) failed`,
msg.errorStack ? `\n${msg.errorStack}\n` : '',
].join(''),
{
workerId: msg.workerId, workerId: msg.workerId,
errorMsg: msg.errorMsg, errorMsg: msg.errorMsg,
executionId: msg.executionId, executionId: msg.executionId,
jobId, jobId,
}); },
);
break; break;
case 'abort-job': case 'abort-job':
break; // only for worker break; // only for worker

1
packages/cli/src/scaling/scaling.types.ts
View file

@ -56,6 +56,7 @@ export type JobFailedMessage = {
executionId: string; executionId: string;
workerId: string; workerId: string;
errorMsg: string; errorMsg: string;
errorStack: string;
}; };
/** Message sent by main to worker to abort a job. */ /** Message sent by main to worker to abort a job. */