mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-10 06:34:05 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: Fix workflow deactivating bug

Browse source 
Fix a bug which crashed n8n under some circumstances on shutdown or
workflow deactivate and so resulted in other workflows not getting
deactviated correctly.
This commit is contained in:
Jan Oberhauser 2022-03-12 19:50:42 +01:00
parent bb3fa05318
commit 195f104ef5
1 changed files with 20 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
packages/core/src/ActiveWorkflows.ts
View file

@ -255,7 +255,16 @@ export class ActiveWorkflows {
if (workflowData.triggerResponses) {
for (const triggerResponse of workflowData.triggerResponses) {
if (triggerResponse.closeFunction) {
await triggerResponse.closeFunction();
try {
await triggerResponse.closeFunction();
} catch (error) {
Logger.error(
`There was a problem deactivating trigger of workflow "${id}": "${error.message}"`,
{
workflowId: id,
},
);
}
}
}
}
@ -263,7 +272,16 @@ export class ActiveWorkflows {
if (workflowData.pollResponses) {
for (const pollResponse of workflowData.pollResponses) {
if (pollResponse.closeFunction) {
await pollResponse.closeFunction();
try {
await pollResponse.closeFunction();
} catch (error) {
Logger.error(
`There was a problem deactivating polling trigger of workflow "${id}": "${error.message}"`,
{
workflowId: id,
},
);
}
}
}
}