mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix remaining test

Browse source
This commit is contained in:
Danny Martini 2024-09-17 23:12:59 +02:00
parent c7ed0485f9
commit 1c768b7199
No known key found for this signature in database
2 changed files with 19 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
packages/cli/src/__tests__/active-executions.test.ts
View file

@ -94,10 +94,19 @@ describe('ActiveExecutions', () => {
}); });
test('Should remove an existing execution', async () => { test('Should remove an existing execution', async () => {
// ARRANGE
const newExecution = mockExecutionData(); const newExecution = mockExecutionData();
const executionId = await activeExecutions.add(newExecution); const executionId = await activeExecutions.add(newExecution);
// ACT
activeExecutions.finishExecution(executionId); activeExecutions.finishExecution(executionId);
// TODO: Wait 2 ticks. This will be unnecessary once the `setImmediate` in
// `active-executions` is removed.
await new Promise((resolve) => setImmediate(resolve));
await new Promise((resolve) => setImmediate(resolve));
// ASSERT
expect(activeExecutions.getActiveExecutions().length).toBe(0); expect(activeExecutions.getActiveExecutions().length).toBe(0);
}); });

16
packages/cli/src/active-executions.ts
View file

@ -106,12 +106,16 @@ export class ActiveExecutions {
}; };
// Automatically remove execution once the postExecutePromise settles // Automatically remove execution once the postExecutePromise settles
void postExecutePromise.promise.finally(() => { void postExecutePromise.promise
this.concurrencyControl.release({ mode: executionData.executionMode }); .finally(() => {
setImmediate(() => { this.concurrencyControl.release({ mode: executionData.executionMode });
delete this.activeExecutions[executionId]; setImmediate(() => {
}); delete this.activeExecutions[executionId];
}); });
})
// Attach a no-op handler to prevent an unhandled rejection, because
// finally will not handle it, but rather rethrow it.
.catch(() => {});
return executionId; return executionId;
} }