mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-02-21 02:56:40 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(core): Fix browser session refreshes not working (#9212)

Browse source 
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
This commit is contained in:
Danny Martini 2024-04-24 18:28:19 +02:00 committed by GitHub
parent 306b68da6b
commit 1efeeccc5b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/cli/src/auth/auth.service.ts
View file

@ -150,7 +150,7 @@ export class AuthService {
if (jwtPayload.exp * 1000 - Date.now() < this.jwtRefreshTimeout) { if (jwtPayload.exp * 1000 - Date.now() < this.jwtRefreshTimeout) {
this.logger.debug('JWT about to expire. Will be refreshed'); this.logger.debug('JWT about to expire. Will be refreshed');
this.issueCookie(res, user, jwtPayload.browserId); this.issueCookie(res, user, req.browserId);
} }
return user; return user;

7
packages/cli/test/unit/auth/auth.service.test.ts
View file

@ -202,6 +202,13 @@ describe('AuthService', () => {
sameSite: 'lax', sameSite: 'lax',
secure: false, secure: false,
}); });
const newToken = res.cookie.mock.calls[0].at(1);
expect(newToken).not.toBe(validToken);
expect(await authService.resolveJwt(newToken, req, res)).toEqual(user);
expect((jwt.decode(newToken) as jwt.JwtPayload).browserId).toEqual(
(jwt.decode(validToken) as jwt.JwtPayload).browserId,
);
}); });
it('should refresh the cookie only if less than 1/4th of time is left', async () => { it('should refresh the cookie only if less than 1/4th of time is left', async () => {