From 2052cadce9ed28597b4b3dc13c4fbca575a5ef37 Mon Sep 17 00:00:00 2001 From: Ahsan Virani Date: Thu, 6 May 2021 02:46:33 +0200 Subject: [PATCH] :sparkles: Add more frontend hooks (#1687) * :zap: add hook for nodecreatelist mount * :zap: add hook for nodeCreateList selectedTypeChanged * :zap: add hook for nodeCreateList nodeFilterChanged * :zap: add hook for nodeCreateList filteredNodeTypesComputed * :zap: add hook for nodeView.activeNodeChanged * :zap: add hook for credentialsEdit credentialTypeChanged * :zap: add hook for onDocumentationUrlClick * :zap: add hook for executionsList openDialog * :zap: add hook for execution open * :zap: add hook for credentialsList dialogVisibleChanged * :zap: add hook for workflowSettings * :zap: add hook for showMessage showError * :zap: add hook for nodeView createNodeActiveChanged * :zap: add hook for nodeView addNodeButton * :zap: cleanup * :zap: add hook for workflowRun runWorkflow * :zap: add hook for pushConnection executionFinished * :zap: add hook for runData.displayModeChanged * :zap: update nodeCreateList.nodeFilterChanged hook * :zap: update dataDisplay nodeTypeChanged hook * :zap: update dataDisplay nodeTypeChanged hook * :zap: update dataDisplay nodeTypeChanged hook * :zap: update error data in hooks * update workflowRun runError hook * :zap: Minor improvements Co-authored-by: Jan Oberhauser --- .../src/components/CredentialsEdit.vue | 6 ++- .../src/components/CredentialsList.vue | 3 ++ .../editor-ui/src/components/DataDisplay.vue | 20 ++++++++- .../src/components/ExecutionsList.vue | 4 ++ packages/editor-ui/src/components/Node.vue | 45 ++----------------- .../src/components/NodeCreateList.vue | 18 +++++++- packages/editor-ui/src/components/RunData.vue | 7 ++- .../src/components/WorkflowSettings.vue | 7 +++ .../src/components/mixins/nodeHelpers.ts | 40 +++++++++++++++++ .../src/components/mixins/pushConnection.ts | 20 +++++++++ .../src/components/mixins/showMessage.ts | 7 ++- .../src/components/mixins/workflowRun.ts | 10 +++-- packages/editor-ui/src/views/NodeView.vue | 10 ++++- 13 files changed, 143 insertions(+), 54 deletions(-) diff --git a/packages/editor-ui/src/components/CredentialsEdit.vue b/packages/editor-ui/src/components/CredentialsEdit.vue index 77a64de7bd..874a4e3451 100644 --- a/packages/editor-ui/src/components/CredentialsEdit.vue +++ b/packages/editor-ui/src/components/CredentialsEdit.vue @@ -50,6 +50,7 @@ diff --git a/packages/editor-ui/src/components/RunData.vue b/packages/editor-ui/src/components/RunData.vue index b64029e69b..da72d6ed1b 100644 --- a/packages/editor-ui/src/components/RunData.vue +++ b/packages/editor-ui/src/components/RunData.vue @@ -5,7 +5,7 @@ @@ -228,6 +228,7 @@ import BinaryDataDisplay from '@/components/BinaryDataDisplay.vue'; import NodeErrorView from '@/components/Error/NodeViewError.vue'; import { copyPaste } from '@/components/mixins/copyPaste'; +import { externalHooks } from "@/components/mixins/externalHooks"; import { genericHelpers } from '@/components/mixins/genericHelpers'; import { nodeHelpers } from '@/components/mixins/nodeHelpers'; import { workflowRun } from '@/components/mixins/workflowRun'; @@ -239,6 +240,7 @@ const deselectedPlaceholder = '_!^&*'; export default mixins( copyPaste, + externalHooks, genericHelpers, nodeHelpers, workflowRun, @@ -617,8 +619,9 @@ export default mixins( jsonData () { this.refreshDataSize(); }, - displayMode () { + displayMode (newValue, oldValue) { this.closeBinaryDataDisplay(); + this.$externalHooks().run('runData.displayModeChanged', { newValue, oldValue }); }, maxRunIndex () { this.runIndex = Math.min(this.runIndex, this.maxRunIndex); diff --git a/packages/editor-ui/src/components/WorkflowSettings.vue b/packages/editor-ui/src/components/WorkflowSettings.vue index ad1d7fd7e9..53ffc57fd0 100644 --- a/packages/editor-ui/src/components/WorkflowSettings.vue +++ b/packages/editor-ui/src/components/WorkflowSettings.vue @@ -167,6 +167,7 @@