From 21624b7f4006e1ce83298d2bf4d87485a8258bc2 Mon Sep 17 00:00:00 2001 From: Alex Grozav Date: Wed, 26 Jul 2023 12:23:23 +0300 Subject: [PATCH] fix: fix linting issues --- packages/editor-ui/src/App.vue | 1 + .../src/components/BreakpointsObserver.vue | 2 +- .../src/components/CollectionsCarousel.vue | 2 +- .../src/components/DuplicateWorkflowDialog.vue | 2 +- .../components/ExecutionsView/ExecutionsList.vue | 4 ++-- packages/editor-ui/src/components/Fragment.vue | 3 --- .../src/components/IntersectionObserved.vue | 2 +- .../src/components/MainHeader/MainHeader.vue | 2 ++ packages/editor-ui/src/components/MainSidebar.vue | 1 + packages/editor-ui/src/components/Node.vue | 4 ++-- .../Node/NodeCreator/Renderers/ItemsRenderer.vue | 4 ++-- .../NodeCreator/__tests__/NodesListPanel.test.ts | 2 +- .../__tests__/useKeyboardNavigation.test.ts | 1 - .../editor-ui/src/components/NodeDetailsView.vue | 1 + .../editor-ui/src/components/NodeExecuteButton.vue | 1 + packages/editor-ui/src/components/NodeTitle.vue | 2 +- .../editor-ui/src/components/ParameterInput.vue | 4 ++-- .../EventDestinationSettingsModal.ee.vue | 2 +- packages/editor-ui/src/components/Sticky.vue | 2 +- packages/editor-ui/src/components/TextEdit.vue | 2 +- packages/editor-ui/src/components/VariablesRow.vue | 2 +- .../editor-ui/src/components/WorkflowActivator.vue | 1 + .../src/components/__tests__/BannersStack.test.ts | 3 ++- .../src/components/__tests__/CopyInput.test.ts | 2 -- .../components/__tests__/ExecutionFilter.test.ts | 1 - .../components/__tests__/ExecutionsList.test.ts | 3 ++- .../__tests__/PersonalizationModal.spec.ts | 1 - .../components/__tests__/ResourceMapper.test.ts | 2 +- .../src/components/__tests__/RunData.test.ts | 14 -------------- .../src/components/__tests__/RunDataSchema.test.ts | 2 +- .../src/components/__tests__/SQLEditor.test.ts | 3 --- .../src/components/layouts/ResourcesListLayout.vue | 2 +- packages/editor-ui/src/plugins/components.ts | 2 -- .../src/utils/__tests__/userUtils.test.ts | 3 +-- packages/editor-ui/src/views/NodeView.vue | 11 ++++++----- .../src/views/SettingsCommunityNodesView.vue | 5 +++-- .../editor-ui/src/views/__tests__/AuthView.test.ts | 3 --- .../src/views/__tests__/SamlOnboarding.test.ts | 3 --- .../views/__tests__/SettingsPersonalView.test.ts | 3 --- 39 files changed, 42 insertions(+), 68 deletions(-) delete mode 100644 packages/editor-ui/src/components/Fragment.vue diff --git a/packages/editor-ui/src/App.vue b/packages/editor-ui/src/App.vue index ce606c3386..9a25ec4217 100644 --- a/packages/editor-ui/src/App.vue +++ b/packages/editor-ui/src/App.vue @@ -75,6 +75,7 @@ export default defineComponent({ ...useHistoryHelper(useRoute()), ...useToast(), externalHooks: useExternalHooks(), + // eslint-disable-next-line @typescript-eslint/no-misused-promises ...newVersions.setup?.(props), }; }, diff --git a/packages/editor-ui/src/components/BreakpointsObserver.vue b/packages/editor-ui/src/components/BreakpointsObserver.vue index 15d6cc802b..cc4430afbf 100644 --- a/packages/editor-ui/src/components/BreakpointsObserver.vue +++ b/packages/editor-ui/src/components/BreakpointsObserver.vue @@ -43,7 +43,7 @@ export default defineComponent({ }, onResizeEnd() { this.width = window.innerWidth; - this.$nextTick(async () => { + void this.$nextTick(async () => { const bannerHeight = await getBannerRowHeight(); useUIStore().updateBannersHeight(bannerHeight); }); diff --git a/packages/editor-ui/src/components/CollectionsCarousel.vue b/packages/editor-ui/src/components/CollectionsCarousel.vue index 1699ddbb65..fd26e3f623 100644 --- a/packages/editor-ui/src/components/CollectionsCarousel.vue +++ b/packages/editor-ui/src/components/CollectionsCarousel.vue @@ -99,7 +99,7 @@ export default defineComponent({ }, }, mounted() { - this.$nextTick(() => { + void this.$nextTick(() => { const sliderRef = this.$refs.slider as SliderRef | undefined; if (!sliderRef) { return; diff --git a/packages/editor-ui/src/components/DuplicateWorkflowDialog.vue b/packages/editor-ui/src/components/DuplicateWorkflowDialog.vue index a9332c3022..ab3d7949bc 100644 --- a/packages/editor-ui/src/components/DuplicateWorkflowDialog.vue +++ b/packages/editor-ui/src/components/DuplicateWorkflowDialog.vue @@ -89,7 +89,7 @@ export default defineComponent({ }, async mounted() { this.name = await this.workflowsStore.getDuplicateCurrentWorkflowName(this.data.name); - this.$nextTick(() => this.focusOnNameInput()); + void this.$nextTick(() => this.focusOnNameInput()); }, computed: { ...mapStores(useCredentialsStore, useUsersStore, useSettingsStore, useWorkflowsStore), diff --git a/packages/editor-ui/src/components/ExecutionsView/ExecutionsList.vue b/packages/editor-ui/src/components/ExecutionsView/ExecutionsList.vue index c1e3ccadc0..b767cd4091 100644 --- a/packages/editor-ui/src/components/ExecutionsView/ExecutionsList.vue +++ b/packages/editor-ui/src/components/ExecutionsView/ExecutionsList.vue @@ -194,7 +194,7 @@ export default defineComponent({ } this.autoRefresh = this.uiStore.executionSidebarAutoRefresh === true; - this.startAutoRefreshInterval(); + void this.startAutoRefreshInterval(); document.addEventListener('visibilitychange', this.onDocumentVisibilityChange); this.loading = false; @@ -453,7 +453,7 @@ export default defineComponent({ return []; } try { - return this.workflowsStore.loadCurrentWorkflowExecutions(this.requestFilter); + return await this.workflowsStore.loadCurrentWorkflowExecutions(this.requestFilter); } catch (error) { if (error.errorCode === NO_NETWORK_ERROR_CODE) { this.showMessage( diff --git a/packages/editor-ui/src/components/Fragment.vue b/packages/editor-ui/src/components/Fragment.vue deleted file mode 100644 index 3d70f5054a..0000000000 --- a/packages/editor-ui/src/components/Fragment.vue +++ /dev/null @@ -1,3 +0,0 @@ - diff --git a/packages/editor-ui/src/components/IntersectionObserved.vue b/packages/editor-ui/src/components/IntersectionObserved.vue index 6b6581d824..1a0940450e 100644 --- a/packages/editor-ui/src/components/IntersectionObserved.vue +++ b/packages/editor-ui/src/components/IntersectionObserved.vue @@ -27,7 +27,7 @@ export default defineComponent({ return; } - this.$nextTick(() => { + void this.$nextTick(() => { this.eventBus.emit('observe', this.$refs.observed); }); }, diff --git a/packages/editor-ui/src/components/MainHeader/MainHeader.vue b/packages/editor-ui/src/components/MainHeader/MainHeader.vue index 6f83b6a9f8..fbd49bf83e 100644 --- a/packages/editor-ui/src/components/MainHeader/MainHeader.vue +++ b/packages/editor-ui/src/components/MainHeader/MainHeader.vue @@ -41,7 +41,9 @@ export default defineComponent({ mixins: [pushConnection, workflowHelpers], setup(props) { return { + // eslint-disable-next-line @typescript-eslint/no-misused-promises ...pushConnection.setup?.(props), + // eslint-disable-next-line @typescript-eslint/no-misused-promises ...workflowHelpers.setup?.(props), }; }, diff --git a/packages/editor-ui/src/components/MainSidebar.vue b/packages/editor-ui/src/components/MainSidebar.vue index c08ffd8095..13326336be 100644 --- a/packages/editor-ui/src/components/MainSidebar.vue +++ b/packages/editor-ui/src/components/MainSidebar.vue @@ -138,6 +138,7 @@ export default defineComponent({ setup(props) { return { ...useMessage(), + // eslint-disable-next-line @typescript-eslint/no-misused-promises ...workflowRun.setup?.(props), }; }, diff --git a/packages/editor-ui/src/components/Node.vue b/packages/editor-ui/src/components/Node.vue index ba72b4960e..174b1cc9b9 100644 --- a/packages/editor-ui/src/components/Node.vue +++ b/packages/editor-ui/src/components/Node.vue @@ -576,7 +576,7 @@ export default defineComponent({ workflow_id: this.workflowsStore.workflowId, }); - this.$nextTick(() => { + void this.$nextTick(() => { // Wait a tick else vue causes problems because the data is gone this.$emit('removeNode', this.data.name); }); @@ -587,7 +587,7 @@ export default defineComponent({ button_name: 'duplicate', workflow_id: this.workflowsStore.workflowId, }); - this.$nextTick(() => { + void this.$nextTick(() => { // Wait a tick else vue causes problems because the data is gone this.$emit('duplicateNode', this.data.name); }); diff --git a/packages/editor-ui/src/components/Node/NodeCreator/Renderers/ItemsRenderer.vue b/packages/editor-ui/src/components/Node/NodeCreator/Renderers/ItemsRenderer.vue index 310b34e738..0d55d55518 100644 --- a/packages/editor-ui/src/components/Node/NodeCreator/Renderers/ItemsRenderer.vue +++ b/packages/editor-ui/src/components/Node/NodeCreator/Renderers/ItemsRenderer.vue @@ -125,7 +125,7 @@ watch( :data-keyboard-nav-id="item.uuid" @click="wrappedEmit('selected', item)" > - +
@@ -148,7 +148,7 @@ watch( :view="item.properties" :class="$style.viewItem" /> - +
diff --git a/packages/editor-ui/src/components/Node/NodeCreator/__tests__/NodesListPanel.test.ts b/packages/editor-ui/src/components/Node/NodeCreator/__tests__/NodesListPanel.test.ts index 99fdb2842f..83f316e35e 100644 --- a/packages/editor-ui/src/components/Node/NodeCreator/__tests__/NodesListPanel.test.ts +++ b/packages/editor-ui/src/components/Node/NodeCreator/__tests__/NodesListPanel.test.ts @@ -1,7 +1,7 @@ import { defineComponent, nextTick, watch } from 'vue'; import type { PropType } from 'vue'; import { createPinia } from 'pinia'; -import { render, screen, fireEvent } from '@testing-library/vue'; +import { screen, fireEvent } from '@testing-library/vue'; import type { INodeTypeDescription } from 'n8n-workflow'; import { useNodeCreatorStore } from '@/stores/nodeCreator.store'; import { mockSimplifiedNodeType } from './utils'; diff --git a/packages/editor-ui/src/components/Node/NodeCreator/__tests__/useKeyboardNavigation.test.ts b/packages/editor-ui/src/components/Node/NodeCreator/__tests__/useKeyboardNavigation.test.ts index e11c032828..105d4443a4 100644 --- a/packages/editor-ui/src/components/Node/NodeCreator/__tests__/useKeyboardNavigation.test.ts +++ b/packages/editor-ui/src/components/Node/NodeCreator/__tests__/useKeyboardNavigation.test.ts @@ -2,7 +2,6 @@ import userEvent from '@testing-library/user-event'; import { defineComponent, computed } from 'vue'; import { useKeyboardNavigation } from '../composables/useKeyboardNavigation'; import { createComponentRenderer } from '@/__tests__/render'; -import { createTestingPinia } from '@pinia/testing'; import { createPinia } from 'pinia'; const eventHookSpy = vi.fn(); diff --git a/packages/editor-ui/src/components/NodeDetailsView.vue b/packages/editor-ui/src/components/NodeDetailsView.vue index aefb0fe9cf..dfaa71acd5 100644 --- a/packages/editor-ui/src/components/NodeDetailsView.vue +++ b/packages/editor-ui/src/components/NodeDetailsView.vue @@ -192,6 +192,7 @@ export default defineComponent({ return { ...useDeviceSupport(), ...useMessage(), + // eslint-disable-next-line @typescript-eslint/no-misused-promises ...workflowActivate.setup?.(props), }; }, diff --git a/packages/editor-ui/src/components/NodeExecuteButton.vue b/packages/editor-ui/src/components/NodeExecuteButton.vue index 128a21a414..9aa382044d 100644 --- a/packages/editor-ui/src/components/NodeExecuteButton.vue +++ b/packages/editor-ui/src/components/NodeExecuteButton.vue @@ -64,6 +64,7 @@ export default defineComponent({ return { ...useToast(), ...useMessage(), + // eslint-disable-next-line @typescript-eslint/no-misused-promises ...workflowRun.setup?.(props), }; }, diff --git a/packages/editor-ui/src/components/NodeTitle.vue b/packages/editor-ui/src/components/NodeTitle.vue index 6afa63fd61..f5c4c1d824 100644 --- a/packages/editor-ui/src/components/NodeTitle.vue +++ b/packages/editor-ui/src/components/NodeTitle.vue @@ -74,7 +74,7 @@ export default defineComponent({ onEdit() { this.newName = this.modelValue; this.editName = true; - this.$nextTick(() => { + void this.$nextTick(() => { const inputRef = this.$refs.input as HTMLInputElement | undefined; if (inputRef) { inputRef.focus(); diff --git a/packages/editor-ui/src/components/ParameterInput.vue b/packages/editor-ui/src/components/ParameterInput.vue index 6d63933cea..221de16373 100644 --- a/packages/editor-ui/src/components/ParameterInput.vue +++ b/packages/editor-ui/src/components/ParameterInput.vue @@ -991,7 +991,7 @@ export default defineComponent({ this.nodeName = this.node.name; } - this.$nextTick(() => { + void this.$nextTick(() => { // @ts-ignore if (this.$refs.inputField?.focus && this.$refs.inputField?.$el) { // @ts-ignore @@ -1162,7 +1162,7 @@ export default defineComponent({ }, }, updated() { - this.$nextTick(() => { + void this.$nextTick(() => { const remoteParameterOptions = this.$el.querySelectorAll('.remote-parameter-option'); if (remoteParameterOptions.length > 0) { diff --git a/packages/editor-ui/src/components/SettingsLogStreaming/EventDestinationSettingsModal.ee.vue b/packages/editor-ui/src/components/SettingsLogStreaming/EventDestinationSettingsModal.ee.vue index 252dedfc77..9d846e5056 100644 --- a/packages/editor-ui/src/components/SettingsLogStreaming/EventDestinationSettingsModal.ee.vue +++ b/packages/editor-ui/src/components/SettingsLogStreaming/EventDestinationSettingsModal.ee.vue @@ -378,7 +378,7 @@ export default defineComponent({ if (newDestination) { this.headerLabel = newDestination?.label ?? this.headerLabel; - nextTick(() => { + void nextTick(() => { this.setupNode(newDestination); }); } diff --git a/packages/editor-ui/src/components/Sticky.vue b/packages/editor-ui/src/components/Sticky.vue index 1a5e57013d..aa596d0f99 100644 --- a/packages/editor-ui/src/components/Sticky.vue +++ b/packages/editor-ui/src/components/Sticky.vue @@ -163,7 +163,7 @@ export default defineComponent({ }, methods: { deleteNode() { - this.$nextTick(() => { + void this.$nextTick(() => { // Wait a tick else vue causes problems because the data is gone this.$emit('removeNode', this.data.name); }); diff --git a/packages/editor-ui/src/components/TextEdit.vue b/packages/editor-ui/src/components/TextEdit.vue index 622ea21561..56473f5eda 100644 --- a/packages/editor-ui/src/components/TextEdit.vue +++ b/packages/editor-ui/src/components/TextEdit.vue @@ -64,7 +64,7 @@ export default defineComponent({ watch: { dialogVisible() { if (this.dialogVisible === true) { - nextTick(() => { + void nextTick(() => { (this.$refs.inputField as HTMLInputElement).focus(); }); } diff --git a/packages/editor-ui/src/components/VariablesRow.vue b/packages/editor-ui/src/components/VariablesRow.vue index 9112e1fcf8..528b31a1cd 100644 --- a/packages/editor-ui/src/components/VariablesRow.vue +++ b/packages/editor-ui/src/components/VariablesRow.vue @@ -80,7 +80,7 @@ const valueValidationRules: Array = [ watch( () => modelValue.value.key, () => { - nextTick(() => { + void nextTick(() => { if (formValidationStatus.value.key) { updateUsageSyntax(); } diff --git a/packages/editor-ui/src/components/WorkflowActivator.vue b/packages/editor-ui/src/components/WorkflowActivator.vue index 4eee200800..c6bd5274ff 100644 --- a/packages/editor-ui/src/components/WorkflowActivator.vue +++ b/packages/editor-ui/src/components/WorkflowActivator.vue @@ -65,6 +65,7 @@ export default defineComponent({ setup(props) { return { ...useToast(), + // eslint-disable-next-line @typescript-eslint/no-misused-promises ...workflowActivate.setup?.(props), }; }, diff --git a/packages/editor-ui/src/components/__tests__/BannersStack.test.ts b/packages/editor-ui/src/components/__tests__/BannersStack.test.ts index 40d56e1a82..7458b9804f 100644 --- a/packages/editor-ui/src/components/__tests__/BannersStack.test.ts +++ b/packages/editor-ui/src/components/__tests__/BannersStack.test.ts @@ -9,7 +9,8 @@ import { createTestingPinia } from '@pinia/testing'; import BannerStack from '@/components/banners/BannerStack.vue'; import { useUIStore } from '@/stores/ui.store'; import { useUsersStore } from '@/stores/users.store'; -import { createComponentRenderer, RenderOptions } from '@/__tests__/render'; +import type { RenderOptions } from '@/__tests__/render'; +import { createComponentRenderer } from '@/__tests__/render'; let uiStore: ReturnType; let usersStore: ReturnType; diff --git a/packages/editor-ui/src/components/__tests__/CopyInput.test.ts b/packages/editor-ui/src/components/__tests__/CopyInput.test.ts index 8cb9b0b749..31a44fd8f4 100644 --- a/packages/editor-ui/src/components/__tests__/CopyInput.test.ts +++ b/packages/editor-ui/src/components/__tests__/CopyInput.test.ts @@ -1,5 +1,3 @@ -import { PiniaVuePlugin } from 'pinia'; -import { render } from '@testing-library/vue'; import { merge } from 'lodash-es'; import { SETTINGS_STORE_DEFAULT_STATE } from '@/__tests__/utils'; diff --git a/packages/editor-ui/src/components/__tests__/ExecutionFilter.test.ts b/packages/editor-ui/src/components/__tests__/ExecutionFilter.test.ts index a979542284..b41770a9b7 100644 --- a/packages/editor-ui/src/components/__tests__/ExecutionFilter.test.ts +++ b/packages/editor-ui/src/components/__tests__/ExecutionFilter.test.ts @@ -9,7 +9,6 @@ import { createComponentRenderer } from '@/__tests__/render'; import * as telemetryModule from '@/composables/useTelemetry'; import type { Telemetry } from '@/plugins/telemetry'; import { merge } from 'lodash-es'; -import { nextTick } from 'vue'; const defaultFilterState: ExecutionFilterType = { status: 'all', diff --git a/packages/editor-ui/src/components/__tests__/ExecutionsList.test.ts b/packages/editor-ui/src/components/__tests__/ExecutionsList.test.ts index ee716ca1c3..fea38132e4 100644 --- a/packages/editor-ui/src/components/__tests__/ExecutionsList.test.ts +++ b/packages/editor-ui/src/components/__tests__/ExecutionsList.test.ts @@ -9,7 +9,8 @@ import type { IWorkflowDb } from '@/Interface'; import type { IExecutionsSummary } from 'n8n-workflow'; import { retry, SETTINGS_STORE_DEFAULT_STATE, waitAllPromises } from '@/__tests__/utils'; import { useWorkflowsStore } from '@/stores/workflows.store'; -import { RenderOptions, createComponentRenderer } from '@/__tests__/render'; +import type { RenderOptions } from '@/__tests__/render'; +import { createComponentRenderer } from '@/__tests__/render'; let pinia: ReturnType; diff --git a/packages/editor-ui/src/components/__tests__/PersonalizationModal.spec.ts b/packages/editor-ui/src/components/__tests__/PersonalizationModal.spec.ts index 222d8f5b8e..aa50c757e0 100644 --- a/packages/editor-ui/src/components/__tests__/PersonalizationModal.spec.ts +++ b/packages/editor-ui/src/components/__tests__/PersonalizationModal.spec.ts @@ -4,7 +4,6 @@ import { PERSONALIZATION_MODAL_KEY, STORES } from '@/constants'; import { retry } from '@/__tests__/utils'; import { createComponentRenderer } from '@/__tests__/render'; import { fireEvent } from '@testing-library/vue'; -import { nextTick } from 'vue'; const renderComponent = createComponentRenderer(PersonalizationModal, { props: { diff --git a/packages/editor-ui/src/components/__tests__/ResourceMapper.test.ts b/packages/editor-ui/src/components/__tests__/ResourceMapper.test.ts index d024a1b967..8c523ae056 100644 --- a/packages/editor-ui/src/components/__tests__/ResourceMapper.test.ts +++ b/packages/editor-ui/src/components/__tests__/ResourceMapper.test.ts @@ -1,4 +1,4 @@ -import { render, within } from '@testing-library/vue'; +import { within } from '@testing-library/vue'; import { DEFAULT_SETUP, MAPPING_COLUMNS_RESPONSE, diff --git a/packages/editor-ui/src/components/__tests__/RunData.test.ts b/packages/editor-ui/src/components/__tests__/RunData.test.ts index 0d1d9519df..b1b07bdc60 100644 --- a/packages/editor-ui/src/components/__tests__/RunData.test.ts +++ b/packages/editor-ui/src/components/__tests__/RunData.test.ts @@ -1,26 +1,12 @@ -import { defineComponent } from 'vue'; import { waitFor } from '@testing-library/vue'; import userEvent from '@testing-library/user-event'; import { createTestingPinia } from '@pinia/testing'; import { merge } from 'lodash-es'; import RunData from '@/components/RunData.vue'; import { STORES, VIEWS } from '@/constants'; -import { useSSOStore } from '@/stores/sso.store'; import { SETTINGS_STORE_DEFAULT_STATE } from '@/__tests__/utils'; -import { useNDVStore, useWorkflowsStore } from '@/stores'; import { createComponentRenderer } from '@/__tests__/render'; -let pinia: ReturnType; -let ssoStore: ReturnType; -let workflowsStore: ReturnType; -let ndvStore: ReturnType; - -// const nodeHelpers = defineComponent({ -// methods: { -// getNodeInputData: vi.fn().mockReturnValue(), -// }, -// }); - const renderComponent = createComponentRenderer(RunData, { props: { nodeUi: { diff --git a/packages/editor-ui/src/components/__tests__/RunDataSchema.test.ts b/packages/editor-ui/src/components/__tests__/RunDataSchema.test.ts index d0ac7a5168..2c8cfc4c08 100644 --- a/packages/editor-ui/src/components/__tests__/RunDataSchema.test.ts +++ b/packages/editor-ui/src/components/__tests__/RunDataSchema.test.ts @@ -1,5 +1,5 @@ import { createTestingPinia } from '@pinia/testing'; -import { render, cleanup } from '@testing-library/vue'; +import { cleanup } from '@testing-library/vue'; import RunDataJsonSchema from '@/components/RunDataSchema.vue'; import { STORES } from '@/constants'; import { createComponentRenderer } from '@/__tests__/render'; diff --git a/packages/editor-ui/src/components/__tests__/SQLEditor.test.ts b/packages/editor-ui/src/components/__tests__/SQLEditor.test.ts index 870f511b3e..0469e9a72e 100644 --- a/packages/editor-ui/src/components/__tests__/SQLEditor.test.ts +++ b/packages/editor-ui/src/components/__tests__/SQLEditor.test.ts @@ -5,9 +5,6 @@ import { createTestingPinia } from '@pinia/testing'; import SqlEditor from '@/components/SqlEditor/SqlEditor.vue'; import { expressionManager } from '@/mixins/expressionManager'; import type { TargetItem } from '@/Interface'; -import { N8nPlugin } from 'n8n-design-system/plugin'; -import { PiniaVuePlugin } from 'pinia'; -import { GlobalDirectivesPlugin } from '@/plugins/directives'; import { renderComponent } from '@/__tests__/render'; const EXPRESSION_OUTPUT_TEST_ID = 'inline-expression-editor-output'; diff --git a/packages/editor-ui/src/components/layouts/ResourcesListLayout.vue b/packages/editor-ui/src/components/layouts/ResourcesListLayout.vue index bf8d81cadd..6eac8d382a 100644 --- a/packages/editor-ui/src/components/layouts/ResourcesListLayout.vue +++ b/packages/editor-ui/src/components/layouts/ResourcesListLayout.vue @@ -394,7 +394,7 @@ export default defineComponent({ await this.initialize(); this.loading = false; - this.$nextTick(this.focusSearchInput); + void this.$nextTick(this.focusSearchInput); }, setCurrentPage(page: number) { this.currentPage = page; diff --git a/packages/editor-ui/src/plugins/components.ts b/packages/editor-ui/src/plugins/components.ts index 6b60d58651..e5d8d6cde5 100644 --- a/packages/editor-ui/src/plugins/components.ts +++ b/packages/editor-ui/src/plugins/components.ts @@ -7,14 +7,12 @@ import { ElLoading, ElMessageBox } from 'element-plus'; import { N8nPlugin } from 'n8n-design-system'; import { useMessage } from '@/composables/useMessage'; import EnterpriseEdition from '@/components/EnterpriseEdition.ee.vue'; -import Fragment from '@/components/Fragment.vue'; export const GlobalComponentsPlugin: Plugin<{}> = { install(app) { const messageService = useMessage(); app.component('enterprise-edition', EnterpriseEdition); - app.component('Fragment', Fragment); app.use(ElementPlus); app.use(N8nPlugin); diff --git a/packages/editor-ui/src/utils/__tests__/userUtils.test.ts b/packages/editor-ui/src/utils/__tests__/userUtils.test.ts index 2d8ce5cd01..8ed6ed606a 100644 --- a/packages/editor-ui/src/utils/__tests__/userUtils.test.ts +++ b/packages/editor-ui/src/utils/__tests__/userUtils.test.ts @@ -1,11 +1,10 @@ import { beforeAll } from 'vitest'; -import { setActivePinia, createPinia } from 'pinia'; +import { setActivePinia } from 'pinia'; import { merge } from 'lodash-es'; import { isAuthorized, ROLE } from '@/utils'; import { useSettingsStore } from '@/stores/settings.store'; import { useSSOStore } from '@/stores/sso.store'; import type { IUser } from '@/Interface'; -import { VIEWS } from '@/constants'; import { SETTINGS_STORE_DEFAULT_STATE } from '@/__tests__/utils'; import type { IN8nUISettings } from 'n8n-workflow'; import { createTestingPinia } from '@pinia/testing'; diff --git a/packages/editor-ui/src/views/NodeView.vue b/packages/editor-ui/src/views/NodeView.vue index cc7474e0c9..23946dff15 100644 --- a/packages/editor-ui/src/views/NodeView.vue +++ b/packages/editor-ui/src/views/NodeView.vue @@ -354,6 +354,7 @@ export default defineComponent({ ...useToast(), ...useMessage(), ...useUniqueNodeName(), + // eslint-disable-next-line @typescript-eslint/no-misused-promises ...workflowRun.setup?.(props), }; }, @@ -452,7 +453,7 @@ export default defineComponent({ if (from.name === VIEWS.NEW_WORKFLOW) { // Replace the current route with the new workflow route // before navigating to the new route when saving new workflow. - this.$router.replace( + await this.$router.replace( { name: VIEWS.WORKFLOW, params: { name: this.currentWorkflow } }, () => { // We can't use next() here since vue-router @@ -764,7 +765,7 @@ export default defineComponent({ deepCopy(data.workflowData.nodes), deepCopy(data.workflowData.connections), ); - this.$nextTick(() => { + void this.$nextTick(() => { this.canvasStore.zoomToFit(); this.uiStore.stateIsDirty = false; }); @@ -835,7 +836,7 @@ export default defineComponent({ this.workflowsStore.setWorkflowPinData(data.workflow.pinData); } - this.$nextTick(() => { + void this.$nextTick(() => { this.canvasStore.zoomToFit(); }); }, @@ -878,7 +879,7 @@ export default defineComponent({ await this.addNodes(data.workflow.nodes, data.workflow.connections); this.workflowData = (await this.workflowsStore.getNewWorkflowData(data.name)) || {}; - this.$nextTick(() => { + void this.$nextTick(() => { this.canvasStore.zoomToFit(); this.uiStore.stateIsDirty = true; }); @@ -3748,7 +3749,7 @@ export default defineComponent({ const lastAddedNode = this.nodes[this.nodes.length - 1]; const previouslyAddedNode = this.nodes[this.nodes.length - 2]; - this.$nextTick(() => + void this.$nextTick(() => this.connectTwoNodes(previouslyAddedNode.name, 0, lastAddedNode.name, 0), ); diff --git a/packages/editor-ui/src/views/SettingsCommunityNodesView.vue b/packages/editor-ui/src/views/SettingsCommunityNodesView.vue index 9830c41c1a..eb371742e1 100644 --- a/packages/editor-ui/src/views/SettingsCommunityNodesView.vue +++ b/packages/editor-ui/src/views/SettingsCommunityNodesView.vue @@ -76,10 +76,11 @@ export default defineComponent({ components: { CommunityPackageCard, }, - setup(props) { + setup(props, ctx) { return { ...useToast(), - ...pushConnection.setup?.(props), + // eslint-disable-next-line @typescript-eslint/no-misused-promises + ...pushConnection.setup?.(props, ctx), }; }, data() { diff --git a/packages/editor-ui/src/views/__tests__/AuthView.test.ts b/packages/editor-ui/src/views/__tests__/AuthView.test.ts index e6edc53826..e776e86942 100644 --- a/packages/editor-ui/src/views/__tests__/AuthView.test.ts +++ b/packages/editor-ui/src/views/__tests__/AuthView.test.ts @@ -1,7 +1,4 @@ -import { PiniaVuePlugin } from 'pinia'; -import { render } from '@testing-library/vue'; import { createTestingPinia } from '@pinia/testing'; -import { merge } from 'lodash-es'; import AuthView from '@/views/AuthView.vue'; import { createComponentRenderer } from '@/__tests__/render'; diff --git a/packages/editor-ui/src/views/__tests__/SamlOnboarding.test.ts b/packages/editor-ui/src/views/__tests__/SamlOnboarding.test.ts index 18ffaf1192..13158b217e 100644 --- a/packages/editor-ui/src/views/__tests__/SamlOnboarding.test.ts +++ b/packages/editor-ui/src/views/__tests__/SamlOnboarding.test.ts @@ -1,5 +1,3 @@ -import { PiniaVuePlugin } from 'pinia'; -import { render } from '@testing-library/vue'; import userEvent from '@testing-library/user-event'; import { useRouter } from 'vue-router'; import { createTestingPinia } from '@pinia/testing'; @@ -8,7 +6,6 @@ import SamlOnboarding from '@/views/SamlOnboarding.vue'; import { useSSOStore } from '@/stores/sso.store'; import { STORES } from '@/constants'; import { SETTINGS_STORE_DEFAULT_STATE, waitAllPromises } from '@/__tests__/utils'; -import { i18nInstance } from '@/plugins/i18n'; import { createComponentRenderer } from '@/__tests__/render'; vi.mock('vue-router', () => { diff --git a/packages/editor-ui/src/views/__tests__/SettingsPersonalView.test.ts b/packages/editor-ui/src/views/__tests__/SettingsPersonalView.test.ts index fd0059482b..f975d2e24f 100644 --- a/packages/editor-ui/src/views/__tests__/SettingsPersonalView.test.ts +++ b/packages/editor-ui/src/views/__tests__/SettingsPersonalView.test.ts @@ -6,9 +6,6 @@ import { useSettingsStore } from '@/stores'; import { useUsersStore } from '@/stores/users.store'; import { createComponentRenderer } from '@/__tests__/render'; import { setupServer } from '@/__tests__/server'; -import { EnterpriseEditionFeature } from '@/constants'; -import { UserManagementAuthenticationMethod } from '@/Interface'; -import { nextTick } from 'vue'; let pinia: ReturnType; let settingsStore: ReturnType;