mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-10 06:34:05 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(editor): Force parse on long expressions (#5009)

Browse source 
⚡ Force parse on long expressions
This commit is contained in:
Iván Ovejero 2022-12-22 17:42:37 +01:00 committed by GitHub
parent c738aa53e9
commit 22fcc8f2be
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 23 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/editor-ui/src/components/ExpressionEditorModal/ExpressionEditorModalInput.vue
View file

@ -16,6 +16,7 @@ import { highlighter } from '@/plugins/codemirror/resolvableHighlighter';
import { inputTheme } from './theme';
import type { IVariableItemSelected } from '@/Interface';
import { forceParse } from '@/utils/forceParse';
export default mixins(expressionManager, workflowHelpers).extend({
name: 'ExpressionEditorModalInput',
@ -40,6 +41,7 @@ export default mixins(expressionManager, workflowHelpers).extend({
doubleBraceHandler(),
EditorView.lineWrapping,
EditorState.readOnly.of(this.isReadOnly),
EditorView.domEventHandlers({ scroll: forceParse }),
EditorView.updateListener.of((viewUpdate) => {
if (!this.editor || !viewUpdate.docChanged) return;

8
packages/editor-ui/src/components/ExpressionEditorModal/ExpressionEditorModalOutput.vue
View file

@ -11,6 +11,7 @@ import { highlighter } from '@/plugins/codemirror/resolvableHighlighter';
import { outputTheme } from './theme';
import type { Plaintext, Resolved, Segment } from '@/types/expressions';
import { forceParse } from '@/utils/forceParse';
export default Vue.extend({
name: 'ExpressionEditorModalOutput',
@ -37,7 +38,12 @@ export default Vue.extend({
};
},
mounted() {
const extensions = [outputTheme(), EditorState.readOnly.of(true), EditorView.lineWrapping];
const extensions = [
outputTheme(),
EditorState.readOnly.of(true),
EditorView.lineWrapping,
EditorView.domEventHandlers({ scroll: forceParse }),
];
this.editor = new EditorView({
parent: this.$refs.root as HTMLDivElement,

14
packages/editor-ui/src/utils/forceParse.ts Normal file
View file

@ -0,0 +1,14 @@
import { EditorView } from '@codemirror/view';
/**
* Simulate user action to force parser to catch up during scroll.
*/
export function forceParse(_: Event, view: EditorView) {
view.dispatch({
changes: { from: view.viewport.to, insert: '_' },
});
view.dispatch({
changes: { from: view.viewport.to - 1, to: view.viewport.to, insert: '' },
});
}