⚡ Minor improvements to S3-Node

packages/nodes-base/credentials/S3.credentials.ts

@@ -4,9 +4,9 @@ import {
 } from 'n8n-workflow';
 
 
-export class CustomS3Endpoint implements ICredentialType {
-	name = 'customS3Endpoint';
-	displayName = 'Custom S3';
+export class S3 implements ICredentialType {
+	name = 's3';
+	displayName = 'S3';
 	properties = [
 		{
 			displayName: 'S3 endpoint',

packages/nodes-base/nodes/S3/GenericFunctions.ts

@@ -31,7 +31,7 @@ export async function s3ApiRequest(this: IHookFunctions | IExecuteFunctions | IL
 
 	let credentials;
 
-	credentials = this.getCredentials('customS3Endpoint');
+	credentials = this.getCredentials('s3');
 
 	if (credentials === undefined) {
 		throw new Error('No credentials got returned!');
@@ -70,7 +70,7 @@ export async function s3ApiRequest(this: IHookFunctions | IExecuteFunctions | IL
 		headers: signOpts.headers,
 		method,
 		qs: query,
-		uri: endpoint,
+		uri: endpoint.toString(),
 		body: signOpts.body,
 	};
 

packages/nodes-base/nodes/S3/S3.node.ts

@@ -49,12 +49,12 @@ import {
 export class S3 implements INodeType {
 	description: INodeTypeDescription = {
 		displayName: 'S3',
-		name: 'S3',
-		icon: 'file:generic-s3.png',
+		name: 's3',
+		icon: 'file:s3.png',
 		group: ['output'],
 		version: 1,
 		subtitle: '={{$parameter["operation"] + ": " + $parameter["resource"]}}',
-		description: 'Sends data to any S3-compatible services',
+		description: 'Sends data to any S3-compatible service',
 		defaults: {
 			name: 'S3',
 			color: '#d05b4b',
@@ -63,7 +63,7 @@ export class S3 implements INodeType {
 		outputs: ['main'],
 		credentials: [
 			{
-				name: 'customS3Endpoint',
+				name: 's3',
 				required: true,
 			},
 		],
@@ -117,7 +117,7 @@ export class S3 implements INodeType {
 					let credentials;
 
 					try {
-						credentials = this.getCredentials('customS3Endpoint');
+						credentials = this.getCredentials('s3');
 					} catch (error) {
 						throw new Error(error);
 					}

packages/nodes-base/package.json

@@ -52,7 +52,7 @@
       "dist/credentials/CopperApi.credentials.js",
       "dist/credentials/CalendlyApi.credentials.js",
       "dist/credentials/CustomerIoApi.credentials.js",
-      "dist/credentials/CustomS3Endpoint.credentials.js",
+      "dist/credentials/S3.credentials.js",
       "dist/credentials/CrateDb.credentials.js",
       "dist/credentials/DisqusApi.credentials.js",
       "dist/credentials/DriftApi.credentials.js",