From 24ce141815b08de1fa9cb660ef3c916a515e25c7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Iv=C3=A1n=20Ovejero?= Date: Tue, 1 Aug 2023 15:32:33 +0200 Subject: [PATCH] refactor: Clear unused ESLint directives from nodes-base (no-changelog) (#6812) * refactor: Clear unused ESLint directives from nodes-base (no-changelog) * removed unused disable directives --------- Co-authored-by: Marcus --- packages/nodes-base/credentials/Aws.credentials.ts | 1 - packages/nodes-base/nodes/AgileCrm/AgileCrm.node.ts | 1 - .../nodes-base/nodes/Airtable/v2/AirtableV2.node.ts | 1 - .../Airtable/v2/actions/record/Record.resource.ts | 1 - packages/nodes-base/nodes/Aws/S3/V2/AwsS3V2.node.ts | 2 +- .../nodes-base/nodes/BambooHr/v1/actions/router.ts | 1 - .../nodes-base/nodes/Clockify/TaskDescription.ts | 2 -- .../nodes/Clockify/TimeEntryDescription.ts | 2 -- packages/nodes-base/nodes/Coda/Coda.node.ts | 2 -- packages/nodes-base/nodes/Code/JavaScriptSandbox.ts | 2 -- .../nodes-base/nodes/CoinGecko/CoinDescription.ts | 2 +- packages/nodes-base/nodes/ERPNext/ERPNext.node.ts | 2 -- .../nodes-base/nodes/EditImage/EditImage.node.ts | 2 -- packages/nodes-base/nodes/Egoi/Egoi.node.ts | 2 -- .../ExecuteWorkflowTrigger.node.ts | 2 +- .../nodes/ExecutionData/ExecutionData.node.ts | 2 -- .../nodes-base/nodes/Facebook/GenericFunctions.ts | 1 - packages/nodes-base/nodes/Figma/FigmaTrigger.node.ts | 1 - .../nodes/Freshservice/Freshservice.node.ts | 2 +- .../Freshservice/descriptions/AgentDescription.ts | 12 ++++-------- .../Freshservice/descriptions/ChangeDescription.ts | 4 ++-- .../Freshservice/descriptions/ReleaseDescription.ts | 4 ++-- .../FreshworksCrm/descriptions/SearchDescription.ts | 2 +- .../Google/Analytics/v1/GoogleAnalyticsV1.node.ts | 1 - .../Google/Analytics/v2/GoogleAnalyticsV2.node.ts | 1 - .../v2/actions/report/get.universal.operation.ts | 1 - .../Google/BigQuery/v2/GoogleBigQueryV2.node.ts | 1 - .../nodes/Google/BigQuery/v2/methods/loadOptions.ts | 2 +- .../nodes/Google/Drive/v2/GoogleDriveV2.node.ts | 1 - .../Drive/v2/actions/file/download.operation.ts | 2 +- .../nodes/Google/Drive/v2/methods/listSearch.ts | 1 - .../nodes/Google/Sheet/v1/GenericFunctions.ts | 1 - .../Google/Sheet/v2/actions/sheet/Sheet.resource.ts | 1 - .../Google/Sheet/v2/helpers/GoogleSheets.utils.ts | 1 - packages/nodes-base/nodes/Html/utils.ts | 2 +- .../nodes/HttpRequest/V1/HttpRequestV1.node.ts | 1 - .../nodes-base/nodes/Hubspot/V1/DealDescription.ts | 1 - .../nodes/ItemLists/V2/summarize.operation.ts | 1 - .../V3/actions/itemList/summarize.operation.ts | 1 - packages/nodes-base/nodes/Jira/Jira.node.ts | 1 - packages/nodes-base/nodes/Jira/JiraTrigger.node.ts | 1 - .../nodes-base/nodes/KoBoToolbox/GenericFunctions.ts | 2 +- packages/nodes-base/nodes/Ldap/Ldap.node.ts | 6 ++---- packages/nodes-base/nodes/Linear/IssueDescription.ts | 2 +- packages/nodes-base/nodes/LinkedIn/LinkedIn.node.ts | 1 - .../nodes/LocalFileTrigger/LocalFileTrigger.node.ts | 2 +- .../nodes-base/nodes/LoneScale/LoneScale.node.ts | 2 -- .../nodes/LoneScale/LoneScaleTrigger.node.ts | 1 - .../nodes/ManualTrigger/ManualTrigger.node.ts | 2 +- .../Microsoft/Excel/v2/MicrosoftExcelV2.node.ts | 1 - .../Excel/v2/actions/table/getRows.operation.ts | 1 - .../nodes/Microsoft/Sql/MicrosoftSql.node.ts | 4 ++-- packages/nodes-base/nodes/MySql/v2/MySqlV2.node.ts | 1 - .../MySql/v2/actions/database/update.operation.ts | 2 +- .../MySql/v2/actions/database/upsert.operation.ts | 2 +- .../nodes-base/nodes/N8n/ExecutionDescription.ts | 1 - .../nodes-base/nodes/Notion/NotionTrigger.node.ts | 1 - .../nodes/Odoo/descriptions/ContactDescription.ts | 1 - .../Odoo/descriptions/CustomResourceDescription.ts | 1 - .../nodes/Odoo/descriptions/NoteDescription.ts | 1 - .../Odoo/descriptions/OpportunityDescription.ts | 1 - packages/nodes-base/nodes/OpenAi/ChatDescription.ts | 1 - packages/nodes-base/nodes/OpenAi/TextDescription.ts | 1 - .../nodes-base/nodes/Postgres/v2/PostgresV2.node.ts | 1 - .../Postgres/v2/actions/database/update.operation.ts | 2 +- .../Postgres/v2/actions/database/upsert.operation.ts | 2 +- packages/nodes-base/nodes/Pushover/Pushover.node.ts | 2 +- .../nodes-base/nodes/QuickBooks/GenericFunctions.ts | 1 - packages/nodes-base/nodes/RabbitMQ/RabbitMQ.node.ts | 1 - .../nodes/RabbitMQ/RabbitMQTrigger.node.ts | 2 +- .../nodes/ReadBinaryFile/ReadBinaryFile.node.ts | 2 +- .../nodes/Schedule/ScheduleTrigger.node.ts | 2 +- .../nodes-base/nodes/SendGrid/GenericFunctions.ts | 1 - .../nodes-base/nodes/Spotify/GenericFunctions.ts | 2 +- packages/nodes-base/nodes/Spotify/Spotify.node.ts | 2 +- .../nodes-base/nodes/Supabase/GenericFunctions.ts | 2 +- packages/nodes-base/nodes/Switch/Switch.node.ts | 1 - .../nodes/Taiga/descriptions/IssueDescription.ts | 1 - .../nodes-base/nodes/Twist/ChannelDescription.ts | 2 +- .../nodes/Typeform/TypeformTrigger.node.ts | 3 +-- .../UptimeRobot/MaintenanceWindowDescription.ts | 4 ++-- .../nodes/UptimeRobot/MonitorDescription.ts | 2 +- .../nodes/WriteBinaryFile/WriteBinaryFile.node.ts | 2 +- packages/nodes-base/package.json | 4 ++-- packages/nodes-base/utils/utilities.ts | 2 +- 85 files changed, 44 insertions(+), 110 deletions(-) diff --git a/packages/nodes-base/credentials/Aws.credentials.ts b/packages/nodes-base/credentials/Aws.credentials.ts index 73638b762f..6b5620384c 100644 --- a/packages/nodes-base/credentials/Aws.credentials.ts +++ b/packages/nodes-base/credentials/Aws.credentials.ts @@ -165,7 +165,6 @@ export class Aws implements ICredentialType { { displayName: 'Temporary Security Credentials', name: 'temporaryCredentials', - // eslint-disable-next-line n8n-nodes-base/node-param-description-boolean-without-whether description: 'Support for temporary credentials from AWS STS', type: 'boolean', default: false, diff --git a/packages/nodes-base/nodes/AgileCrm/AgileCrm.node.ts b/packages/nodes-base/nodes/AgileCrm/AgileCrm.node.ts index 0730efd29b..51d32d3d66 100644 --- a/packages/nodes-base/nodes/AgileCrm/AgileCrm.node.ts +++ b/packages/nodes-base/nodes/AgileCrm/AgileCrm.node.ts @@ -190,7 +190,6 @@ export class AgileCrm implements INodeType { } if (simple) { - // eslint-disable-next-line @typescript-eslint/no-unsafe-argument responseData = simplifyResponse(responseData); } } else if (operation === 'create') { diff --git a/packages/nodes-base/nodes/Airtable/v2/AirtableV2.node.ts b/packages/nodes-base/nodes/Airtable/v2/AirtableV2.node.ts index 336ce44a2d..a8f99ce4f2 100644 --- a/packages/nodes-base/nodes/Airtable/v2/AirtableV2.node.ts +++ b/packages/nodes-base/nodes/Airtable/v2/AirtableV2.node.ts @@ -1,4 +1,3 @@ -/* eslint-disable n8n-nodes-base/node-filename-against-convention */ import type { IExecuteFunctions, INodeType, diff --git a/packages/nodes-base/nodes/Airtable/v2/actions/record/Record.resource.ts b/packages/nodes-base/nodes/Airtable/v2/actions/record/Record.resource.ts index 3ac6c7e4c7..7c526bfa82 100644 --- a/packages/nodes-base/nodes/Airtable/v2/actions/record/Record.resource.ts +++ b/packages/nodes-base/nodes/Airtable/v2/actions/record/Record.resource.ts @@ -24,7 +24,6 @@ export const description: INodeProperties[] = [ action: 'Create a record', }, { - // eslint-disable-next-line n8n-nodes-base/node-param-option-name-wrong-for-upsert name: 'Create or Update', value: 'upsert', description: 'Create a new record, or update the current one if it already exists (upsert)', diff --git a/packages/nodes-base/nodes/Aws/S3/V2/AwsS3V2.node.ts b/packages/nodes-base/nodes/Aws/S3/V2/AwsS3V2.node.ts index 2473fc973a..81e2dec0c0 100644 --- a/packages/nodes-base/nodes/Aws/S3/V2/AwsS3V2.node.ts +++ b/packages/nodes-base/nodes/Aws/S3/V2/AwsS3V2.node.ts @@ -283,7 +283,7 @@ export class AwsS3V2 implements INodeType { this.helpers.returnJsonArray(responseData as IDataObject[]), { itemData: { item: i } }, ); - // eslint-disable-next-line @typescript-eslint/no-unsafe-argument + returnData.push(...executionData); } } diff --git a/packages/nodes-base/nodes/BambooHr/v1/actions/router.ts b/packages/nodes-base/nodes/BambooHr/v1/actions/router.ts index fe667dfa0a..9e8cb85a9e 100644 --- a/packages/nodes-base/nodes/BambooHr/v1/actions/router.ts +++ b/packages/nodes-base/nodes/BambooHr/v1/actions/router.ts @@ -1,4 +1,3 @@ -/* eslint-disable @typescript-eslint/no-unsafe-argument */ import type { IExecuteFunctions, INodeExecutionData } from 'n8n-workflow'; import * as employee from './employee'; diff --git a/packages/nodes-base/nodes/Clockify/TaskDescription.ts b/packages/nodes-base/nodes/Clockify/TaskDescription.ts index 50ef0f1b54..8545a5aa56 100644 --- a/packages/nodes-base/nodes/Clockify/TaskDescription.ts +++ b/packages/nodes-base/nodes/Clockify/TaskDescription.ts @@ -97,7 +97,6 @@ export const taskFields: INodeProperties[] = [ default: {}, options: [ { - // eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-multi-options displayName: 'Assignee Names or IDs', name: 'assigneeIds', type: 'multiOptions', @@ -277,7 +276,6 @@ export const taskFields: INodeProperties[] = [ default: {}, options: [ { - // eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-multi-options displayName: 'Assignee Names or IDs', name: 'assigneeIds', type: 'multiOptions', diff --git a/packages/nodes-base/nodes/Clockify/TimeEntryDescription.ts b/packages/nodes-base/nodes/Clockify/TimeEntryDescription.ts index 0cceac1a4e..342281875d 100644 --- a/packages/nodes-base/nodes/Clockify/TimeEntryDescription.ts +++ b/packages/nodes-base/nodes/Clockify/TimeEntryDescription.ts @@ -140,7 +140,6 @@ export const timeEntryFields: INodeProperties[] = [ default: '', }, { - // eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-multi-options displayName: 'Tag Names or IDs', name: 'tagIds', type: 'multiOptions', @@ -328,7 +327,6 @@ export const timeEntryFields: INodeProperties[] = [ default: '', }, { - // eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-multi-options displayName: 'Tag Names or IDs', name: 'tagIds', type: 'multiOptions', diff --git a/packages/nodes-base/nodes/Coda/Coda.node.ts b/packages/nodes-base/nodes/Coda/Coda.node.ts index ecd308d1e8..9666a8a5ca 100644 --- a/packages/nodes-base/nodes/Coda/Coda.node.ts +++ b/packages/nodes-base/nodes/Coda/Coda.node.ts @@ -411,7 +411,6 @@ export class Coda implements INodeType { return [this.helpers.returnJsonArray(responseData as IDataObject[])]; } else { for (const item of responseData) { - // eslint-disable-next-line @typescript-eslint/no-unsafe-argument returnData.push({ id: item.id, ...item.values, @@ -758,7 +757,6 @@ export class Coda implements INodeType { return [this.helpers.returnJsonArray(responseData as IDataObject[])]; } else { for (const item of responseData) { - // eslint-disable-next-line @typescript-eslint/no-unsafe-argument returnData.push({ id: item.id, ...item.values, diff --git a/packages/nodes-base/nodes/Code/JavaScriptSandbox.ts b/packages/nodes-base/nodes/Code/JavaScriptSandbox.ts index 68a5fcc767..6980281d58 100644 --- a/packages/nodes-base/nodes/Code/JavaScriptSandbox.ts +++ b/packages/nodes-base/nodes/Code/JavaScriptSandbox.ts @@ -66,7 +66,6 @@ export class JavaScriptSandbox extends Sandbox { error.message = (quoted as string) + '. Did you mean `$input.all()`?'; } - // eslint-disable-next-line @typescript-eslint/no-unsafe-argument throw new ExecutionError(error); } @@ -111,7 +110,6 @@ export class JavaScriptSandbox extends Sandbox { error.message = (quoted as string) + '. Did you mean `$input.item.json`?'; } - // eslint-disable-next-line @typescript-eslint/no-unsafe-argument throw new ExecutionError(error, this.itemIndex); } diff --git a/packages/nodes-base/nodes/CoinGecko/CoinDescription.ts b/packages/nodes-base/nodes/CoinGecko/CoinDescription.ts index f29c830852..58dbb956a1 100644 --- a/packages/nodes-base/nodes/CoinGecko/CoinDescription.ts +++ b/packages/nodes-base/nodes/CoinGecko/CoinDescription.ts @@ -301,7 +301,7 @@ export const coinFields: INodeProperties[] = [ name: 'days', required: true, type: 'options', - // eslint-disable-next-line n8n-nodes-base/node-param-options-type-unsorted-items + options: [ { name: '1', diff --git a/packages/nodes-base/nodes/ERPNext/ERPNext.node.ts b/packages/nodes-base/nodes/ERPNext/ERPNext.node.ts index 13a5d39d0d..a328f79abb 100644 --- a/packages/nodes-base/nodes/ERPNext/ERPNext.node.ts +++ b/packages/nodes-base/nodes/ERPNext/ERPNext.node.ts @@ -89,7 +89,6 @@ export class ERPNext implements INodeType { docFields.unshift({ name: '*', value: '*' }); - // eslint-disable-next-line @typescript-eslint/no-unsafe-argument return processNames(docFields); }, async getDocFields(this: ILoadOptionsFunctions): Promise { @@ -107,7 +106,6 @@ export class ERPNext implements INodeType { }, ); - // eslint-disable-next-line @typescript-eslint/no-unsafe-argument return processNames(docFields); }, }, diff --git a/packages/nodes-base/nodes/EditImage/EditImage.node.ts b/packages/nodes-base/nodes/EditImage/EditImage.node.ts index 6d3f2420df..0266e0b23b 100644 --- a/packages/nodes-base/nodes/EditImage/EditImage.node.ts +++ b/packages/nodes-base/nodes/EditImage/EditImage.node.ts @@ -1108,7 +1108,6 @@ export class EditImage implements INodeType { const operator = operationData.operator as string; const geometryString = - // eslint-disable-next-line @typescript-eslint/restrict-plus-operands (positionX >= 0 ? '+' : '') + positionX + (positionY >= 0 ? '+' : '') + positionY; const binaryPropertyName = operationData.dataPropertyNameComposite as string; @@ -1284,7 +1283,6 @@ export class EditImage implements INodeType { const fileName = newItem.binary![dataPropertyName].fileName; if (fileName?.includes('.')) { newItem.binary![dataPropertyName].fileName = - // eslint-disable-next-line @typescript-eslint/restrict-plus-operands fileName.split('.').slice(0, -1).join('.') + '.' + options.format; } } diff --git a/packages/nodes-base/nodes/Egoi/Egoi.node.ts b/packages/nodes-base/nodes/Egoi/Egoi.node.ts index 54d36f42c9..0ebe6e657c 100644 --- a/packages/nodes-base/nodes/Egoi/Egoi.node.ts +++ b/packages/nodes-base/nodes/Egoi/Egoi.node.ts @@ -631,7 +631,6 @@ export class Egoi implements INodeType { } if (simple) { - // eslint-disable-next-line @typescript-eslint/no-unsafe-argument const data = (await simplify.call(this, [responseData], listId))[0]; responseData = { @@ -675,7 +674,6 @@ export class Egoi implements INodeType { } if (simple) { - // eslint-disable-next-line @typescript-eslint/no-unsafe-argument responseData = await simplify.call(this, responseData, listId); } } diff --git a/packages/nodes-base/nodes/ExecuteWorkflowTrigger/ExecuteWorkflowTrigger.node.ts b/packages/nodes-base/nodes/ExecuteWorkflowTrigger/ExecuteWorkflowTrigger.node.ts index d73f7331e7..adfee24751 100644 --- a/packages/nodes-base/nodes/ExecuteWorkflowTrigger/ExecuteWorkflowTrigger.node.ts +++ b/packages/nodes-base/nodes/ExecuteWorkflowTrigger/ExecuteWorkflowTrigger.node.ts @@ -20,7 +20,7 @@ export class ExecuteWorkflowTrigger implements INodeType { name: 'Execute Workflow Trigger', color: '#ff6d5a', }, - // eslint-disable-next-line n8n-nodes-base/node-class-description-inputs-wrong-regular-node + inputs: [], outputs: ['main'], properties: [ diff --git a/packages/nodes-base/nodes/ExecutionData/ExecutionData.node.ts b/packages/nodes-base/nodes/ExecutionData/ExecutionData.node.ts index 8d68f30135..0dd3097e13 100644 --- a/packages/nodes-base/nodes/ExecutionData/ExecutionData.node.ts +++ b/packages/nodes-base/nodes/ExecutionData/ExecutionData.node.ts @@ -1,4 +1,3 @@ -/* eslint-disable n8n-nodes-base/node-class-description-missing-subtitle */ import type { IDataObject, IExecuteFunctions, @@ -37,7 +36,6 @@ export class ExecutionData implements INodeType { noDataExpression: true, options: [ { - // eslint-disable-next-line n8n-nodes-base/node-param-display-name-miscased name: 'Save Execution Data for Search', value: 'save', action: 'Save execution data for search', diff --git a/packages/nodes-base/nodes/Facebook/GenericFunctions.ts b/packages/nodes-base/nodes/Facebook/GenericFunctions.ts index bbad071aa2..3ddb130efb 100644 --- a/packages/nodes-base/nodes/Facebook/GenericFunctions.ts +++ b/packages/nodes-base/nodes/Facebook/GenericFunctions.ts @@ -554,7 +554,6 @@ export function getFields(object: string) { ], } as { [key: string]: any }; - // eslint-disable-next-line @typescript-eslint/no-unsafe-argument return [{ name: '*', value: '*' }].concat(data[object] || []).map((fieldObject: IDataObject) => ({ ...fieldObject, name: fieldObject.value !== '*' ? capitalCase(fieldObject.value as string) : fieldObject.value, diff --git a/packages/nodes-base/nodes/Figma/FigmaTrigger.node.ts b/packages/nodes-base/nodes/Figma/FigmaTrigger.node.ts index eecb109bf1..707fe46644 100644 --- a/packages/nodes-base/nodes/Figma/FigmaTrigger.node.ts +++ b/packages/nodes-base/nodes/Figma/FigmaTrigger.node.ts @@ -15,7 +15,6 @@ import { randomBytes } from 'crypto'; export class FigmaTrigger implements INodeType { description: INodeTypeDescription = { - // eslint-disable-next-line n8n-nodes-base/node-class-description-display-name-unsuffixed-trigger-node displayName: 'Figma Trigger (Beta)', name: 'figmaTrigger', icon: 'file:figma.svg', diff --git a/packages/nodes-base/nodes/Freshservice/Freshservice.node.ts b/packages/nodes-base/nodes/Freshservice/Freshservice.node.ts index 0f8854b1b8..54b168461f 100644 --- a/packages/nodes-base/nodes/Freshservice/Freshservice.node.ts +++ b/packages/nodes-base/nodes/Freshservice/Freshservice.node.ts @@ -236,7 +236,7 @@ export class Freshservice implements INodeType { fields = fields .concat(...asset_type_fields.map((data) => data.fields)) .map((data) => ({ name: data.label, id: data.name })); - // eslint-disable-next-line @typescript-eslint/no-unsafe-argument + return toOptions(fields); }, diff --git a/packages/nodes-base/nodes/Freshservice/descriptions/AgentDescription.ts b/packages/nodes-base/nodes/Freshservice/descriptions/AgentDescription.ts index ec00210e97..9e9f152d3b 100644 --- a/packages/nodes-base/nodes/Freshservice/descriptions/AgentDescription.ts +++ b/packages/nodes-base/nodes/Freshservice/descriptions/AgentDescription.ts @@ -222,8 +222,7 @@ export const agentFields: INodeProperties[] = [ }, }, { - // eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-multi-options - displayName: 'Member of Group Names/IDs', + displayName: 'Group Names or IDs', name: 'member_of', type: 'multiOptions', default: [], @@ -240,7 +239,6 @@ export const agentFields: INodeProperties[] = [ default: '', }, { - // eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-multi-options displayName: 'Observer of Group Names/IDs', name: 'observer_of', type: 'multiOptions', @@ -257,7 +255,7 @@ export const agentFields: INodeProperties[] = [ type: 'options', description: 'ID of the level of the agent in the Arcade', default: 1, - // eslint-disable-next-line n8n-nodes-base/node-param-options-type-unsorted-items + options: [ { name: 'Beginner', @@ -558,8 +556,7 @@ export const agentFields: INodeProperties[] = [ }, }, { - // eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-multi-options - displayName: 'Member of Group Names/IDs', + displayName: 'Group Names or IDs', name: 'member_of', type: 'multiOptions', default: [], @@ -576,7 +573,6 @@ export const agentFields: INodeProperties[] = [ default: '', }, { - // eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-multi-options displayName: 'Observer of Group Names/IDs', name: 'observer_of', type: 'multiOptions', @@ -593,7 +589,7 @@ export const agentFields: INodeProperties[] = [ type: 'options', description: 'ID of the level of the agent in the Arcade', default: 1, - // eslint-disable-next-line n8n-nodes-base/node-param-options-type-unsorted-items + options: [ { name: 'Beginner', diff --git a/packages/nodes-base/nodes/Freshservice/descriptions/ChangeDescription.ts b/packages/nodes-base/nodes/Freshservice/descriptions/ChangeDescription.ts index 6de31b1a45..5753f86106 100644 --- a/packages/nodes-base/nodes/Freshservice/descriptions/ChangeDescription.ts +++ b/packages/nodes-base/nodes/Freshservice/descriptions/ChangeDescription.ts @@ -259,7 +259,7 @@ export const changeFields: INodeProperties[] = [ name: 'status', type: 'options', default: 1, - // eslint-disable-next-line n8n-nodes-base/node-param-options-type-unsorted-items + options: [ { name: 'Open', @@ -610,7 +610,7 @@ export const changeFields: INodeProperties[] = [ name: 'status', type: 'options', default: 1, - // eslint-disable-next-line n8n-nodes-base/node-param-options-type-unsorted-items + options: [ { name: 'Open', diff --git a/packages/nodes-base/nodes/Freshservice/descriptions/ReleaseDescription.ts b/packages/nodes-base/nodes/Freshservice/descriptions/ReleaseDescription.ts index 9404ba7558..60de514d0f 100644 --- a/packages/nodes-base/nodes/Freshservice/descriptions/ReleaseDescription.ts +++ b/packages/nodes-base/nodes/Freshservice/descriptions/ReleaseDescription.ts @@ -135,7 +135,7 @@ export const releaseFields: INodeProperties[] = [ operation: ['create'], }, }, - // eslint-disable-next-line n8n-nodes-base/node-param-options-type-unsorted-items + options: [ { name: 'Open', @@ -412,7 +412,7 @@ export const releaseFields: INodeProperties[] = [ name: 'status', type: 'options', default: 1, - // eslint-disable-next-line n8n-nodes-base/node-param-options-type-unsorted-items + options: [ { name: 'Open', diff --git a/packages/nodes-base/nodes/FreshworksCrm/descriptions/SearchDescription.ts b/packages/nodes-base/nodes/FreshworksCrm/descriptions/SearchDescription.ts index 675984ff99..865b37b9ef 100644 --- a/packages/nodes-base/nodes/FreshworksCrm/descriptions/SearchDescription.ts +++ b/packages/nodes-base/nodes/FreshworksCrm/descriptions/SearchDescription.ts @@ -216,7 +216,7 @@ export const searchFields: INodeProperties[] = [ value: 'sales_account', }, ], - // eslint-disable-next-line n8n-nodes-base/node-param-description-unneeded-backticks + description: "Use 'entities' to query against related entities. You can include multiple entities at once, provided the field is available in both entities or else you'd receive an error response.", }, diff --git a/packages/nodes-base/nodes/Google/Analytics/v1/GoogleAnalyticsV1.node.ts b/packages/nodes-base/nodes/Google/Analytics/v1/GoogleAnalyticsV1.node.ts index 04d668464b..045b22b210 100644 --- a/packages/nodes-base/nodes/Google/Analytics/v1/GoogleAnalyticsV1.node.ts +++ b/packages/nodes-base/nodes/Google/Analytics/v1/GoogleAnalyticsV1.node.ts @@ -247,7 +247,6 @@ export class GoogleAnalyticsV1 implements INodeType { if (simple) { responseData = simplify(responseData); } else if (returnAll && responseData.length > 1) { - // eslint-disable-next-line @typescript-eslint/no-unsafe-argument responseData = merge(responseData); } } diff --git a/packages/nodes-base/nodes/Google/Analytics/v2/GoogleAnalyticsV2.node.ts b/packages/nodes-base/nodes/Google/Analytics/v2/GoogleAnalyticsV2.node.ts index ec1dd18965..1ae20cf865 100644 --- a/packages/nodes-base/nodes/Google/Analytics/v2/GoogleAnalyticsV2.node.ts +++ b/packages/nodes-base/nodes/Google/Analytics/v2/GoogleAnalyticsV2.node.ts @@ -1,4 +1,3 @@ -/* eslint-disable n8n-nodes-base/node-filename-against-convention */ import type { IExecuteFunctions, INodeExecutionData, diff --git a/packages/nodes-base/nodes/Google/Analytics/v2/actions/report/get.universal.operation.ts b/packages/nodes-base/nodes/Google/Analytics/v2/actions/report/get.universal.operation.ts index faca9dfe42..85952e951f 100644 --- a/packages/nodes-base/nodes/Google/Analytics/v2/actions/report/get.universal.operation.ts +++ b/packages/nodes-base/nodes/Google/Analytics/v2/actions/report/get.universal.operation.ts @@ -717,7 +717,6 @@ export async function execute( if (simple) { responseData = simplify(responseData); } else if (returnAll && responseData.length > 1) { - // eslint-disable-next-line @typescript-eslint/no-unsafe-argument responseData = merge(responseData); } diff --git a/packages/nodes-base/nodes/Google/BigQuery/v2/GoogleBigQueryV2.node.ts b/packages/nodes-base/nodes/Google/BigQuery/v2/GoogleBigQueryV2.node.ts index 1c0f589da7..07ef323406 100644 --- a/packages/nodes-base/nodes/Google/BigQuery/v2/GoogleBigQueryV2.node.ts +++ b/packages/nodes-base/nodes/Google/BigQuery/v2/GoogleBigQueryV2.node.ts @@ -1,4 +1,3 @@ -/* eslint-disable n8n-nodes-base/node-filename-against-convention */ import type { IExecuteFunctions, INodeExecutionData, diff --git a/packages/nodes-base/nodes/Google/BigQuery/v2/methods/loadOptions.ts b/packages/nodes-base/nodes/Google/BigQuery/v2/methods/loadOptions.ts index 41966678c6..aaf6fe7608 100644 --- a/packages/nodes-base/nodes/Google/BigQuery/v2/methods/loadOptions.ts +++ b/packages/nodes-base/nodes/Google/BigQuery/v2/methods/loadOptions.ts @@ -44,7 +44,7 @@ export async function getSchema(this: ILoadOptionsFunctions): Promise { - // eslint-disable-next-line @typescript-eslint/restrict-plus-operands return r + r + g + g + b + b; }); diff --git a/packages/nodes-base/nodes/Google/Sheet/v2/actions/sheet/Sheet.resource.ts b/packages/nodes-base/nodes/Google/Sheet/v2/actions/sheet/Sheet.resource.ts index 0be8b33ee7..ea56f9c6c3 100644 --- a/packages/nodes-base/nodes/Google/Sheet/v2/actions/sheet/Sheet.resource.ts +++ b/packages/nodes-base/nodes/Google/Sheet/v2/actions/sheet/Sheet.resource.ts @@ -30,7 +30,6 @@ export const descriptions: INodeProperties[] = [ action: 'Append data to a sheet', }, { - // eslint-disable-next-line n8n-nodes-base/node-param-option-name-wrong-for-upsert name: 'Append or Update', value: 'appendOrUpdate', description: 'Append a new row or update the current one if it already exists (upsert)', diff --git a/packages/nodes-base/nodes/Google/Sheet/v2/helpers/GoogleSheets.utils.ts b/packages/nodes-base/nodes/Google/Sheet/v2/helpers/GoogleSheets.utils.ts index 6451b38956..0ca0e2445a 100644 --- a/packages/nodes-base/nodes/Google/Sheet/v2/helpers/GoogleSheets.utils.ts +++ b/packages/nodes-base/nodes/Google/Sheet/v2/helpers/GoogleSheets.utils.ts @@ -66,7 +66,6 @@ export function hexToRgb(hex: string) { // Expand shorthand form (e.g. "03F") to full form (e.g. "0033FF") const shorthandRegex = /^#?([a-f\d])([a-f\d])([a-f\d])$/i; hex = hex.replace(shorthandRegex, (m, r, g, b) => { - // eslint-disable-next-line @typescript-eslint/restrict-plus-operands return r + r + g + g + b + b; }); diff --git a/packages/nodes-base/nodes/Html/utils.ts b/packages/nodes-base/nodes/Html/utils.ts index 355a720161..1b163b14f1 100644 --- a/packages/nodes-base/nodes/Html/utils.ts +++ b/packages/nodes-base/nodes/Html/utils.ts @@ -7,7 +7,7 @@ const extractFunctions: { } = { attribute: ($: Cheerio, valueData: IValueData): string | undefined => $.attr(valueData.attribute!), - // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing + html: ($: Cheerio, _valueData: IValueData): string | undefined => $.html() || undefined, text: ($: Cheerio, _valueData: IValueData): string | undefined => $.text(), value: ($: Cheerio, _valueData: IValueData): string | undefined => $.val(), diff --git a/packages/nodes-base/nodes/HttpRequest/V1/HttpRequestV1.node.ts b/packages/nodes-base/nodes/HttpRequest/V1/HttpRequestV1.node.ts index 47819d15d3..5cb1860874 100644 --- a/packages/nodes-base/nodes/HttpRequest/V1/HttpRequestV1.node.ts +++ b/packages/nodes-base/nodes/HttpRequest/V1/HttpRequestV1.node.ts @@ -1,4 +1,3 @@ -// eslint-disable-next-line n8n-nodes-base/node-filename-against-convention import type { IExecuteFunctions, IDataObject, diff --git a/packages/nodes-base/nodes/Hubspot/V1/DealDescription.ts b/packages/nodes-base/nodes/Hubspot/V1/DealDescription.ts index 78e006452c..b8953f0711 100644 --- a/packages/nodes-base/nodes/Hubspot/V1/DealDescription.ts +++ b/packages/nodes-base/nodes/Hubspot/V1/DealDescription.ts @@ -433,7 +433,6 @@ export const dealFields: INodeProperties[] = [ '

Used to include specific deal properties in the results. By default, the results will only include Deal ID and will not include the values for any properties for your Deals.

Including this parameter will include the data for the specified property in the results. You can include this parameter multiple times to request multiple properties separated by a comma: ,.

. Choose from the list, or specify IDs using an expression.', }, { - // eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-multi-options displayName: 'Properties with History', name: 'propertiesWithHistory', type: 'multiOptions', diff --git a/packages/nodes-base/nodes/ItemLists/V2/summarize.operation.ts b/packages/nodes-base/nodes/ItemLists/V2/summarize.operation.ts index dac7a97c69..6bb7c5419e 100644 --- a/packages/nodes-base/nodes/ItemLists/V2/summarize.operation.ts +++ b/packages/nodes-base/nodes/ItemLists/V2/summarize.operation.ts @@ -29,7 +29,6 @@ type Aggregation = { type Aggregations = Aggregation[]; -// eslint-disable-next-line no-restricted-syntax const AggregationDisplayNames = { append: 'appended_', average: 'average_', diff --git a/packages/nodes-base/nodes/ItemLists/V3/actions/itemList/summarize.operation.ts b/packages/nodes-base/nodes/ItemLists/V3/actions/itemList/summarize.operation.ts index 4ff21ac137..476be2f961 100644 --- a/packages/nodes-base/nodes/ItemLists/V3/actions/itemList/summarize.operation.ts +++ b/packages/nodes-base/nodes/ItemLists/V3/actions/itemList/summarize.operation.ts @@ -32,7 +32,6 @@ type Aggregation = { type Aggregations = Aggregation[]; -// eslint-disable-next-line no-restricted-syntax const AggregationDisplayNames = { append: 'appended_', average: 'average_', diff --git a/packages/nodes-base/nodes/Jira/Jira.node.ts b/packages/nodes-base/nodes/Jira/Jira.node.ts index 88fc088256..1ce6bf6108 100644 --- a/packages/nodes-base/nodes/Jira/Jira.node.ts +++ b/packages/nodes-base/nodes/Jira/Jira.node.ts @@ -793,7 +793,6 @@ export class Jira implements INodeType { ); } const executionData = this.helpers.constructExecutionMetaData( - // eslint-disable-next-line @typescript-eslint/no-unsafe-argument this.helpers.returnJsonArray(simplifyIssueOutput(responseData)), { itemData: { item: i } }, ); diff --git a/packages/nodes-base/nodes/Jira/JiraTrigger.node.ts b/packages/nodes-base/nodes/Jira/JiraTrigger.node.ts index 8a2e1113d4..97a6044306 100644 --- a/packages/nodes-base/nodes/Jira/JiraTrigger.node.ts +++ b/packages/nodes-base/nodes/Jira/JiraTrigger.node.ts @@ -44,7 +44,6 @@ export class JiraTrigger implements INodeType { }, }, { - // eslint-disable-next-line n8n-nodes-base/node-class-description-credentials-name-unsuffixed name: 'httpQueryAuth', required: true, displayOptions: { diff --git a/packages/nodes-base/nodes/KoBoToolbox/GenericFunctions.ts b/packages/nodes-base/nodes/KoBoToolbox/GenericFunctions.ts index 7bfa1a02af..dcc06652e7 100644 --- a/packages/nodes-base/nodes/KoBoToolbox/GenericFunctions.ts +++ b/packages/nodes-base/nodes/KoBoToolbox/GenericFunctions.ts @@ -132,7 +132,7 @@ const formatValue = (value: any, format: string): any => { // Only return if all values are properly parsed if (coordinates.length === points.length) { // If the shape is closed, declare it as Polygon, otherwise as LineString - // eslint-disable-next-line @typescript-eslint/no-unsafe-argument + if (first(points) === last(points)) { return { type: 'Polygon', diff --git a/packages/nodes-base/nodes/Ldap/Ldap.node.ts b/packages/nodes-base/nodes/Ldap/Ldap.node.ts index 379c42ab35..e59db1aab8 100644 --- a/packages/nodes-base/nodes/Ldap/Ldap.node.ts +++ b/packages/nodes-base/nodes/Ldap/Ldap.node.ts @@ -1,4 +1,3 @@ -/* eslint-disable n8n-nodes-base/node-filename-against-convention */ import type { ICredentialDataDecryptedObject, ICredentialsDecrypted, @@ -33,7 +32,6 @@ export class Ldap implements INodeType { outputs: ['main'], credentials: [ { - // eslint-disable-next-line n8n-nodes-base/node-class-description-credentials-name-unsuffixed name: 'ldap', required: true, testedBy: 'ldapConnectionTest', @@ -132,7 +130,7 @@ export class Ldap implements INodeType { const baseDN = this.getNodeParameter('baseDN', 0) as string; const results = await client.search(baseDN, { sizeLimit: 200, paged: false }); // should this size limit be set in credentials? - // eslint-disable-next-line @typescript-eslint/no-unsafe-argument + const unique = Object.keys(Object.assign({}, ...results.searchEntries)); return unique.map((x) => ({ name: x, @@ -183,7 +181,7 @@ export class Ldap implements INodeType { const baseDN = this.getNodeParameter('dn', 0) as string; const results = await client.search(baseDN, { sizeLimit: 1, paged: false }); - // eslint-disable-next-line @typescript-eslint/no-unsafe-argument + const unique = Object.keys(Object.assign({}, ...results.searchEntries)); return unique.map((x) => ({ name: x, diff --git a/packages/nodes-base/nodes/Linear/IssueDescription.ts b/packages/nodes-base/nodes/Linear/IssueDescription.ts index e303af34d3..e54f86e583 100644 --- a/packages/nodes-base/nodes/Linear/IssueDescription.ts +++ b/packages/nodes-base/nodes/Linear/IssueDescription.ts @@ -253,7 +253,7 @@ export const issueFields: INodeProperties[] = [ displayName: 'Priority Name/ID', name: 'priorityId', type: 'options', - // eslint-disable-next-line n8n-nodes-base/node-param-options-type-unsorted-items + options: [ { name: 'Urgent', diff --git a/packages/nodes-base/nodes/LinkedIn/LinkedIn.node.ts b/packages/nodes-base/nodes/LinkedIn/LinkedIn.node.ts index 1b007fa65a..b1b751fa15 100644 --- a/packages/nodes-base/nodes/LinkedIn/LinkedIn.node.ts +++ b/packages/nodes-base/nodes/LinkedIn/LinkedIn.node.ts @@ -11,7 +11,6 @@ import { linkedInApiRequest } from './GenericFunctions'; import { postFields, postOperations } from './PostDescription'; export class LinkedIn implements INodeType { - // eslint-disable-next-line n8n-nodes-base/node-class-description-missing-subtitle description: INodeTypeDescription = { displayName: 'LinkedIn', name: 'linkedIn', diff --git a/packages/nodes-base/nodes/LocalFileTrigger/LocalFileTrigger.node.ts b/packages/nodes-base/nodes/LocalFileTrigger/LocalFileTrigger.node.ts index eaf6525486..65b698d0be 100644 --- a/packages/nodes-base/nodes/LocalFileTrigger/LocalFileTrigger.node.ts +++ b/packages/nodes-base/nodes/LocalFileTrigger/LocalFileTrigger.node.ts @@ -142,7 +142,7 @@ export class LocalFileTrigger implements INodeType { description: 'Files or paths to ignore. The whole path is tested, not just the filename. Supports Anymatch- syntax.', }, - // eslint-disable-next-line n8n-nodes-base/node-param-default-missing + { displayName: 'Max Folder Depth', name: 'depth', diff --git a/packages/nodes-base/nodes/LoneScale/LoneScale.node.ts b/packages/nodes-base/nodes/LoneScale/LoneScale.node.ts index 37210c8c7a..6d9726e944 100644 --- a/packages/nodes-base/nodes/LoneScale/LoneScale.node.ts +++ b/packages/nodes-base/nodes/LoneScale/LoneScale.node.ts @@ -378,7 +378,6 @@ export class LoneScale implements INodeType { responseData = await lonescaleApiRequest.call(this, 'POST', '/lists', body); const executionData = this.helpers.constructExecutionMetaData( - // eslint-disable-next-line @typescript-eslint/no-unsafe-argument this.helpers.returnJsonArray(responseData), { itemData: { item: i } }, ); @@ -459,7 +458,6 @@ export class LoneScale implements INodeType { body, ); const executionData = this.helpers.constructExecutionMetaData( - // eslint-disable-next-line @typescript-eslint/no-unsafe-argument this.helpers.returnJsonArray(responseData), { itemData: { item: i } }, ); diff --git a/packages/nodes-base/nodes/LoneScale/LoneScaleTrigger.node.ts b/packages/nodes-base/nodes/LoneScale/LoneScaleTrigger.node.ts index 562c5cbfdc..766e73aa58 100644 --- a/packages/nodes-base/nodes/LoneScale/LoneScaleTrigger.node.ts +++ b/packages/nodes-base/nodes/LoneScale/LoneScaleTrigger.node.ts @@ -124,7 +124,6 @@ export class LoneScaleTrigger implements INodeType { const req = this.getRequestObject(); return { - // eslint-disable-next-line @typescript-eslint/no-unsafe-argument workflowData: [this.helpers.returnJsonArray(req.body)], }; } diff --git a/packages/nodes-base/nodes/ManualTrigger/ManualTrigger.node.ts b/packages/nodes-base/nodes/ManualTrigger/ManualTrigger.node.ts index 66b47a5d7e..3504a02b4f 100644 --- a/packages/nodes-base/nodes/ManualTrigger/ManualTrigger.node.ts +++ b/packages/nodes-base/nodes/ManualTrigger/ManualTrigger.node.ts @@ -19,7 +19,7 @@ export class ManualTrigger implements INodeType { name: 'When clicking "Execute Workflow"', color: '#909298', }, - // eslint-disable-next-line n8n-nodes-base/node-class-description-inputs-wrong-regular-node + inputs: [], outputs: ['main'], properties: [ diff --git a/packages/nodes-base/nodes/Microsoft/Excel/v2/MicrosoftExcelV2.node.ts b/packages/nodes-base/nodes/Microsoft/Excel/v2/MicrosoftExcelV2.node.ts index 7c05811017..797165df3e 100644 --- a/packages/nodes-base/nodes/Microsoft/Excel/v2/MicrosoftExcelV2.node.ts +++ b/packages/nodes-base/nodes/Microsoft/Excel/v2/MicrosoftExcelV2.node.ts @@ -1,4 +1,3 @@ -/* eslint-disable n8n-nodes-base/node-filename-against-convention */ import type { IExecuteFunctions, INodeType, diff --git a/packages/nodes-base/nodes/Microsoft/Excel/v2/actions/table/getRows.operation.ts b/packages/nodes-base/nodes/Microsoft/Excel/v2/actions/table/getRows.operation.ts index f38f1ab6cb..b3e12c3cd3 100644 --- a/packages/nodes-base/nodes/Microsoft/Excel/v2/actions/table/getRows.operation.ts +++ b/packages/nodes-base/nodes/Microsoft/Excel/v2/actions/table/getRows.operation.ts @@ -75,7 +75,6 @@ const properties: INodeProperties[] = [ }, }, { - // eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-options displayName: 'Column Names or IDs', name: 'column', type: 'multiOptions', diff --git a/packages/nodes-base/nodes/Microsoft/Sql/MicrosoftSql.node.ts b/packages/nodes-base/nodes/Microsoft/Sql/MicrosoftSql.node.ts index 9aaecf0714..c63d3402a5 100644 --- a/packages/nodes-base/nodes/Microsoft/Sql/MicrosoftSql.node.ts +++ b/packages/nodes-base/nodes/Microsoft/Sql/MicrosoftSql.node.ts @@ -101,7 +101,7 @@ export class MicrosoftSql implements INodeType { }, }, default: '', - // eslint-disable-next-line n8n-nodes-base/node-param-placeholder-miscased-id + placeholder: 'SELECT id, name FROM product WHERE id < 40', required: true, description: 'The SQL query to execute', @@ -133,7 +133,7 @@ export class MicrosoftSql implements INodeType { }, }, default: '', - // eslint-disable-next-line n8n-nodes-base/node-param-placeholder-miscased-id + placeholder: 'id,name,description', description: 'Comma-separated list of the properties which should used as columns for the new rows', diff --git a/packages/nodes-base/nodes/MySql/v2/MySqlV2.node.ts b/packages/nodes-base/nodes/MySql/v2/MySqlV2.node.ts index 01bc2aa8a2..e8dc7c05ee 100644 --- a/packages/nodes-base/nodes/MySql/v2/MySqlV2.node.ts +++ b/packages/nodes-base/nodes/MySql/v2/MySqlV2.node.ts @@ -1,4 +1,3 @@ -/* eslint-disable n8n-nodes-base/node-filename-against-convention */ import type { IExecuteFunctions, INodeExecutionData, diff --git a/packages/nodes-base/nodes/MySql/v2/actions/database/update.operation.ts b/packages/nodes-base/nodes/MySql/v2/actions/database/update.operation.ts index 812e54a1a8..c613461550 100644 --- a/packages/nodes-base/nodes/MySql/v2/actions/database/update.operation.ts +++ b/packages/nodes-base/nodes/MySql/v2/actions/database/update.operation.ts @@ -49,7 +49,7 @@ const properties: INodeProperties[] = [ }, }, { - // eslint-disable-next-line n8n-nodes-base/node-param-display-name-miscased, n8n-nodes-base/node-param-display-name-wrong-for-dynamic-options + // eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-options displayName: 'Column to Match On', name: 'columnToMatchOn', type: 'options', diff --git a/packages/nodes-base/nodes/MySql/v2/actions/database/upsert.operation.ts b/packages/nodes-base/nodes/MySql/v2/actions/database/upsert.operation.ts index 3f9ea1334c..157cbcd855 100644 --- a/packages/nodes-base/nodes/MySql/v2/actions/database/upsert.operation.ts +++ b/packages/nodes-base/nodes/MySql/v2/actions/database/upsert.operation.ts @@ -49,7 +49,7 @@ const properties: INodeProperties[] = [ }, }, { - // eslint-disable-next-line n8n-nodes-base/node-param-display-name-miscased, n8n-nodes-base/node-param-display-name-wrong-for-dynamic-options + // eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-options displayName: 'Column to Match On', name: 'columnToMatchOn', type: 'options', diff --git a/packages/nodes-base/nodes/N8n/ExecutionDescription.ts b/packages/nodes-base/nodes/N8n/ExecutionDescription.ts index 85f31b97fe..e40317af1e 100644 --- a/packages/nodes-base/nodes/N8n/ExecutionDescription.ts +++ b/packages/nodes-base/nodes/N8n/ExecutionDescription.ts @@ -1,4 +1,3 @@ -/* eslint-disable n8n-nodes-base/node-param-default-missing */ import { getCursorPaginator } from './GenericFunctions'; import type { INodeProperties } from 'n8n-workflow'; import { workflowIdLocator } from './WorkflowLocator'; diff --git a/packages/nodes-base/nodes/Notion/NotionTrigger.node.ts b/packages/nodes-base/nodes/Notion/NotionTrigger.node.ts index fb58578bc0..b7c84cc42a 100644 --- a/packages/nodes-base/nodes/Notion/NotionTrigger.node.ts +++ b/packages/nodes-base/nodes/Notion/NotionTrigger.node.ts @@ -13,7 +13,6 @@ import { getDatabases } from './SearchFunctions'; export class NotionTrigger implements INodeType { description: INodeTypeDescription = { - // eslint-disable-next-line n8n-nodes-base/node-class-description-display-name-unsuffixed-trigger-node displayName: 'Notion Trigger', name: 'notionTrigger', icon: 'file:notion.svg', diff --git a/packages/nodes-base/nodes/Odoo/descriptions/ContactDescription.ts b/packages/nodes-base/nodes/Odoo/descriptions/ContactDescription.ts index 34971d068f..88b9872244 100644 --- a/packages/nodes-base/nodes/Odoo/descriptions/ContactDescription.ts +++ b/packages/nodes-base/nodes/Odoo/descriptions/ContactDescription.ts @@ -254,7 +254,6 @@ export const contactDescription: INodeProperties[] = [ }, options: [ { - // eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-multi-options displayName: 'Fields to Include', name: 'fieldsList', type: 'multiOptions', diff --git a/packages/nodes-base/nodes/Odoo/descriptions/CustomResourceDescription.ts b/packages/nodes-base/nodes/Odoo/descriptions/CustomResourceDescription.ts index 08b3616e96..a59a592c5f 100644 --- a/packages/nodes-base/nodes/Odoo/descriptions/CustomResourceDescription.ts +++ b/packages/nodes-base/nodes/Odoo/descriptions/CustomResourceDescription.ts @@ -175,7 +175,6 @@ export const customResourceDescription: INodeProperties[] = [ }, options: [ { - // eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-multi-options displayName: 'Fields to Include', name: 'fieldsList', type: 'multiOptions', diff --git a/packages/nodes-base/nodes/Odoo/descriptions/NoteDescription.ts b/packages/nodes-base/nodes/Odoo/descriptions/NoteDescription.ts index 140e115cfc..e144d2a4c3 100644 --- a/packages/nodes-base/nodes/Odoo/descriptions/NoteDescription.ts +++ b/packages/nodes-base/nodes/Odoo/descriptions/NoteDescription.ts @@ -156,7 +156,6 @@ export const noteDescription: INodeProperties[] = [ }, options: [ { - // eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-multi-options displayName: 'Fields to Include', name: 'fieldsList', type: 'multiOptions', diff --git a/packages/nodes-base/nodes/Odoo/descriptions/OpportunityDescription.ts b/packages/nodes-base/nodes/Odoo/descriptions/OpportunityDescription.ts index 2b19237d6c..1256052cdc 100644 --- a/packages/nodes-base/nodes/Odoo/descriptions/OpportunityDescription.ts +++ b/packages/nodes-base/nodes/Odoo/descriptions/OpportunityDescription.ts @@ -207,7 +207,6 @@ export const opportunityDescription: INodeProperties[] = [ }, options: [ { - // eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-multi-options displayName: 'Fields to Include', name: 'fieldsList', type: 'multiOptions', diff --git a/packages/nodes-base/nodes/OpenAi/ChatDescription.ts b/packages/nodes-base/nodes/OpenAi/ChatDescription.ts index c1db473ad7..4e05427eea 100644 --- a/packages/nodes-base/nodes/OpenAi/ChatDescription.ts +++ b/packages/nodes-base/nodes/OpenAi/ChatDescription.ts @@ -68,7 +68,6 @@ const completeOperations: INodeProperties[] = [ { type: 'setKeyValue', properties: { - // eslint-disable-next-line n8n-nodes-base/node-param-display-name-miscased-id name: '={{$responseItem.id}}', value: '={{$responseItem.id}}', }, diff --git a/packages/nodes-base/nodes/OpenAi/TextDescription.ts b/packages/nodes-base/nodes/OpenAi/TextDescription.ts index 746f202b89..e3e532ba2d 100644 --- a/packages/nodes-base/nodes/OpenAi/TextDescription.ts +++ b/packages/nodes-base/nodes/OpenAi/TextDescription.ts @@ -94,7 +94,6 @@ const completeOperations: INodeProperties[] = [ { type: 'setKeyValue', properties: { - // eslint-disable-next-line n8n-nodes-base/node-param-display-name-miscased-id name: '={{$responseItem.id}}', value: '={{$responseItem.id}}', }, diff --git a/packages/nodes-base/nodes/Postgres/v2/PostgresV2.node.ts b/packages/nodes-base/nodes/Postgres/v2/PostgresV2.node.ts index caa0ad669e..a113d1756c 100644 --- a/packages/nodes-base/nodes/Postgres/v2/PostgresV2.node.ts +++ b/packages/nodes-base/nodes/Postgres/v2/PostgresV2.node.ts @@ -1,4 +1,3 @@ -/* eslint-disable n8n-nodes-base/node-filename-against-convention */ import type { IExecuteFunctions, INodeExecutionData, diff --git a/packages/nodes-base/nodes/Postgres/v2/actions/database/update.operation.ts b/packages/nodes-base/nodes/Postgres/v2/actions/database/update.operation.ts index 047d3008ae..a45f2bbb37 100644 --- a/packages/nodes-base/nodes/Postgres/v2/actions/database/update.operation.ts +++ b/packages/nodes-base/nodes/Postgres/v2/actions/database/update.operation.ts @@ -67,7 +67,7 @@ const properties: INodeProperties[] = [ }, }, { - // eslint-disable-next-line n8n-nodes-base/node-param-display-name-miscased, n8n-nodes-base/node-param-display-name-wrong-for-dynamic-options + // eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-options displayName: 'Column to Match On', name: 'columnToMatchOn', type: 'options', diff --git a/packages/nodes-base/nodes/Postgres/v2/actions/database/upsert.operation.ts b/packages/nodes-base/nodes/Postgres/v2/actions/database/upsert.operation.ts index aee7c759c7..c2893b91ae 100644 --- a/packages/nodes-base/nodes/Postgres/v2/actions/database/upsert.operation.ts +++ b/packages/nodes-base/nodes/Postgres/v2/actions/database/upsert.operation.ts @@ -66,7 +66,7 @@ const properties: INodeProperties[] = [ }, }, { - // eslint-disable-next-line n8n-nodes-base/node-param-display-name-miscased, n8n-nodes-base/node-param-display-name-wrong-for-dynamic-options + // eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-options displayName: 'Unique Column', name: 'columnToMatchOn', type: 'options', diff --git a/packages/nodes-base/nodes/Pushover/Pushover.node.ts b/packages/nodes-base/nodes/Pushover/Pushover.node.ts index 477e997d4a..58d8e67ac9 100644 --- a/packages/nodes-base/nodes/Pushover/Pushover.node.ts +++ b/packages/nodes-base/nodes/Pushover/Pushover.node.ts @@ -92,7 +92,7 @@ export class Pushover implements INodeType { default: '', description: 'Your message', }, - // eslint-disable-next-line n8n-nodes-base/node-param-default-missing + { displayName: 'Priority', name: 'priority', diff --git a/packages/nodes-base/nodes/QuickBooks/GenericFunctions.ts b/packages/nodes-base/nodes/QuickBooks/GenericFunctions.ts index 6720dc9e22..0cf69aadf2 100644 --- a/packages/nodes-base/nodes/QuickBooks/GenericFunctions.ts +++ b/packages/nodes-base/nodes/QuickBooks/GenericFunctions.ts @@ -270,7 +270,6 @@ export async function loadResource(this: ILoadOptionsFunctions, resource: string if (resource === 'preferences') { const { - // eslint-disable-next-line @typescript-eslint/no-shadow SalesFormsPrefs: { CustomField }, } = resourceItems[0]; const customFields = CustomField[1].CustomField; diff --git a/packages/nodes-base/nodes/RabbitMQ/RabbitMQ.node.ts b/packages/nodes-base/nodes/RabbitMQ/RabbitMQ.node.ts index a0bdd74d05..b4056bc75c 100644 --- a/packages/nodes-base/nodes/RabbitMQ/RabbitMQ.node.ts +++ b/packages/nodes-base/nodes/RabbitMQ/RabbitMQ.node.ts @@ -17,7 +17,6 @@ import { rabbitmqConnectExchange, rabbitmqConnectQueue } from './GenericFunction export class RabbitMQ implements INodeType { description: INodeTypeDescription = { - // eslint-disable-next-line displayName: 'RabbitMQ', name: 'rabbitmq', // eslint-disable-next-line n8n-nodes-base/node-class-description-icon-not-svg diff --git a/packages/nodes-base/nodes/RabbitMQ/RabbitMQTrigger.node.ts b/packages/nodes-base/nodes/RabbitMQ/RabbitMQTrigger.node.ts index 7a1024ddb8..09781ac3fa 100644 --- a/packages/nodes-base/nodes/RabbitMQ/RabbitMQTrigger.node.ts +++ b/packages/nodes-base/nodes/RabbitMQ/RabbitMQTrigger.node.ts @@ -126,7 +126,7 @@ export class RabbitMQTrigger implements INodeType { default: false, description: 'Whether to return only the content property', }, - // eslint-disable-next-line n8n-nodes-base/node-param-default-missing + { displayName: 'Parallel Message Processing Limit', name: 'parallelMessages', diff --git a/packages/nodes-base/nodes/ReadBinaryFile/ReadBinaryFile.node.ts b/packages/nodes-base/nodes/ReadBinaryFile/ReadBinaryFile.node.ts index 4287b369eb..03aa9005e6 100644 --- a/packages/nodes-base/nodes/ReadBinaryFile/ReadBinaryFile.node.ts +++ b/packages/nodes-base/nodes/ReadBinaryFile/ReadBinaryFile.node.ts @@ -70,7 +70,7 @@ export class ReadBinaryFile implements INodeType { const stream = await this.helpers.createReadStream(filePath); const dataPropertyName = this.getNodeParameter('dataPropertyName', itemIndex); - // eslint-disable-next-line @typescript-eslint/no-non-null-assertion + newItem.binary![dataPropertyName] = await this.helpers.prepareBinaryData(stream, filePath); returnData.push(newItem); } catch (error) { diff --git a/packages/nodes-base/nodes/Schedule/ScheduleTrigger.node.ts b/packages/nodes-base/nodes/Schedule/ScheduleTrigger.node.ts index 20748917c9..10a9a4ae6e 100644 --- a/packages/nodes-base/nodes/Schedule/ScheduleTrigger.node.ts +++ b/packages/nodes-base/nodes/Schedule/ScheduleTrigger.node.ts @@ -27,7 +27,7 @@ export class ScheduleTrigger implements INodeType { name: 'Schedule Trigger', color: '#31C49F', }, - // eslint-disable-next-line n8n-nodes-base/node-class-description-inputs-wrong-regular-node + inputs: [], outputs: ['main'], properties: [ diff --git a/packages/nodes-base/nodes/SendGrid/GenericFunctions.ts b/packages/nodes-base/nodes/SendGrid/GenericFunctions.ts index 9b0791aab9..62754ad7b7 100644 --- a/packages/nodes-base/nodes/SendGrid/GenericFunctions.ts +++ b/packages/nodes-base/nodes/SendGrid/GenericFunctions.ts @@ -54,7 +54,6 @@ export async function sendGridApiRequestAllItems( let uri; do { - // eslint-disable-next-line @typescript-eslint/no-unsafe-argument responseData = await sendGridApiRequest.call(this, endpoint, method, body, query, uri); // possible bug, as function does not have uri parameter uri = responseData._metadata.next; returnData.push.apply(returnData, responseData[propertyName] as IDataObject[]); diff --git a/packages/nodes-base/nodes/Spotify/GenericFunctions.ts b/packages/nodes-base/nodes/Spotify/GenericFunctions.ts index c186fb728f..f78b01c5fa 100644 --- a/packages/nodes-base/nodes/Spotify/GenericFunctions.ts +++ b/packages/nodes-base/nodes/Spotify/GenericFunctions.ts @@ -55,7 +55,7 @@ export async function spotifyApiRequestAllItems( do { responseData = await spotifyApiRequest.call(this, method, endpoint, body, query, uri); - // eslint-disable-next-line @typescript-eslint/no-unsafe-argument + returnData.push.apply(returnData, get(responseData, propertyName)); uri = responseData.next || responseData[propertyName.split('.')[0]].next; //remove the query as the query parameters are already included in the next, else api throws error. diff --git a/packages/nodes-base/nodes/Spotify/Spotify.node.ts b/packages/nodes-base/nodes/Spotify/Spotify.node.ts index 2203cdbe4b..fad38cf9ef 100644 --- a/packages/nodes-base/nodes/Spotify/Spotify.node.ts +++ b/packages/nodes-base/nodes/Spotify/Spotify.node.ts @@ -362,7 +362,7 @@ export class Spotify implements INodeType { resource: ['playlist'], }, }, - // eslint-disable-next-line n8n-nodes-base/node-param-options-type-unsorted-items + options: [ { name: 'Add an Item', diff --git a/packages/nodes-base/nodes/Supabase/GenericFunctions.ts b/packages/nodes-base/nodes/Supabase/GenericFunctions.ts index 7570e95eb5..b88c75d60f 100644 --- a/packages/nodes-base/nodes/Supabase/GenericFunctions.ts +++ b/packages/nodes-base/nodes/Supabase/GenericFunctions.ts @@ -71,7 +71,7 @@ export function getFilters( includeNoneOption = true, filterTypeDisplayName = 'Filter', filterFixedCollectionDisplayName = 'Filters', - // eslint-disable-next-line @typescript-eslint/no-unused-vars + filterStringDisplayName = 'Filters (String)', mustMatchOptions = [ { diff --git a/packages/nodes-base/nodes/Switch/Switch.node.ts b/packages/nodes-base/nodes/Switch/Switch.node.ts index 994daa6b75..5cf4a923a1 100644 --- a/packages/nodes-base/nodes/Switch/Switch.node.ts +++ b/packages/nodes-base/nodes/Switch/Switch.node.ts @@ -477,7 +477,6 @@ export class Switch implements INodeType { ], }, - // eslint-disable-next-line n8n-nodes-base/node-param-default-missing { displayName: 'Fallback Output', name: 'fallbackOutput', diff --git a/packages/nodes-base/nodes/Taiga/descriptions/IssueDescription.ts b/packages/nodes-base/nodes/Taiga/descriptions/IssueDescription.ts index 65fdadbdf3..5a233f5660 100644 --- a/packages/nodes-base/nodes/Taiga/descriptions/IssueDescription.ts +++ b/packages/nodes-base/nodes/Taiga/descriptions/IssueDescription.ts @@ -96,7 +96,6 @@ export const issueFields: INodeProperties[] = [ }, options: [ { - // eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-dynamic-options displayName: 'Assignee Name or ID', name: 'assigned_to', type: 'options', diff --git a/packages/nodes-base/nodes/Twist/ChannelDescription.ts b/packages/nodes-base/nodes/Twist/ChannelDescription.ts index 84bcd31da6..afdc772ff4 100644 --- a/packages/nodes-base/nodes/Twist/ChannelDescription.ts +++ b/packages/nodes-base/nodes/Twist/ChannelDescription.ts @@ -179,7 +179,7 @@ export const channelFields: INodeProperties[] = [ default: false, description: 'Whether the channel will be marked as public', }, - // eslint-disable-next-line n8n-nodes-base/node-param-default-missing + { displayName: 'Temp ID', name: 'temp_id', diff --git a/packages/nodes-base/nodes/Typeform/TypeformTrigger.node.ts b/packages/nodes-base/nodes/Typeform/TypeformTrigger.node.ts index d2f153efb0..bfda4406b8 100644 --- a/packages/nodes-base/nodes/Typeform/TypeformTrigger.node.ts +++ b/packages/nodes-base/nodes/Typeform/TypeformTrigger.node.ts @@ -93,12 +93,11 @@ export class TypeformTrigger implements INodeType { 'Form which should trigger workflow on submission. Choose from the list, or specify an ID using an expression.', }, { - // eslint-disable-next-line n8n-nodes-base/node-param-display-name-wrong-for-simplify displayName: 'Simplify Answers', name: 'simplifyAnswers', type: 'boolean', default: true, - // eslint-disable-next-line n8n-nodes-base/node-param-description-wrong-for-simplify + description: 'Whether to convert the answers to a key:value pair ("FIELD_TITLE":"USER_ANSER") to be easily processable', }, diff --git a/packages/nodes-base/nodes/UptimeRobot/MaintenanceWindowDescription.ts b/packages/nodes-base/nodes/UptimeRobot/MaintenanceWindowDescription.ts index 296739d4da..6898522657 100644 --- a/packages/nodes-base/nodes/UptimeRobot/MaintenanceWindowDescription.ts +++ b/packages/nodes-base/nodes/UptimeRobot/MaintenanceWindowDescription.ts @@ -122,7 +122,7 @@ export const maintenanceWindowFields: INodeProperties[] = [ type: [3], }, }, - // eslint-disable-next-line n8n-nodes-base/node-param-options-type-unsorted-items + options: [ { name: 'Monday', @@ -354,7 +354,7 @@ export const maintenanceWindowFields: INodeProperties[] = [ type: [3], }, }, - // eslint-disable-next-line n8n-nodes-base/node-param-options-type-unsorted-items + options: [ { name: 'Monday', diff --git a/packages/nodes-base/nodes/UptimeRobot/MonitorDescription.ts b/packages/nodes-base/nodes/UptimeRobot/MonitorDescription.ts index 87329e8b58..7ba57fb4a9 100644 --- a/packages/nodes-base/nodes/UptimeRobot/MonitorDescription.ts +++ b/packages/nodes-base/nodes/UptimeRobot/MonitorDescription.ts @@ -234,7 +234,7 @@ export const monitorFields: INodeProperties[] = [ name: 'statuses', type: 'multiOptions', default: [], - // eslint-disable-next-line n8n-nodes-base/node-param-multi-options-type-unsorted-items + options: [ { name: 'Paused', diff --git a/packages/nodes-base/nodes/WriteBinaryFile/WriteBinaryFile.node.ts b/packages/nodes-base/nodes/WriteBinaryFile/WriteBinaryFile.node.ts index ed08ccec36..5b75b19981 100644 --- a/packages/nodes-base/nodes/WriteBinaryFile/WriteBinaryFile.node.ts +++ b/packages/nodes-base/nodes/WriteBinaryFile/WriteBinaryFile.node.ts @@ -97,7 +97,7 @@ export class WriteBinaryFile implements INodeType { } // Write the file to disk - // eslint-disable-next-line @typescript-eslint/no-unsafe-call + await this.helpers.writeContentToFile(fileName, fileContent, flag); if (item.binary !== undefined) { diff --git a/packages/nodes-base/package.json b/packages/nodes-base/package.json index b5fb5003fe..49356d63e3 100644 --- a/packages/nodes-base/package.json +++ b/packages/nodes-base/package.json @@ -21,8 +21,8 @@ "build:translations": "gulp build:translations", "build:metadata": "pnpm n8n-generate-known && pnpm n8n-generate-ui-types", "format": "prettier --write . --ignore-path ../../.prettierignore", - "lint": "eslint --quiet .; node ./scripts/validate-load-options-methods.js", - "lintfix": "eslint . --fix", + "lint": "eslint . --quiet --report-unused-disable-directives; node ./scripts/validate-load-options-methods.js", + "lintfix": "eslint . --fix --report-unused-disable-directives", "watch": "tsc-watch -p tsconfig.build.json --onSuccess \"pnpm n8n-generate-ui-types\"", "test": "jest" }, diff --git a/packages/nodes-base/utils/utilities.ts b/packages/nodes-base/utils/utilities.ts index 6de1b90978..ffdc4a0c8a 100644 --- a/packages/nodes-base/utils/utilities.ts +++ b/packages/nodes-base/utils/utilities.ts @@ -65,7 +65,7 @@ export function flatten(nestedArray: T[][]) { })(nestedArray); //TODO: check logic in MicrosoftSql.node.ts - // eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-return + return result as any; }