mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-01-12 05:17:28 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(Mattermost Node): Fix base url trailing slash error (#6097)

Browse source 
* 🐛 Fix credential base url with trailing slash

* Fix credential test base url with trailing slash
This commit is contained in:
Marcus 2023-04-27 11:42:37 +02:00 committed by GitHub
parent c65ac03368
commit 25a386dd70
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/nodes-base/credentials/MattermostApi.credentials.ts
View file

@ -46,7 +46,7 @@ export class MattermostApi implements ICredentialType {
test: ICredentialTestRequest = { test: ICredentialTestRequest = {
request: { request: {
baseURL: '={{$credentials.baseUrl}}/api/v4', baseURL: '={{$credentials.baseUrl.replace(/\\/$/, "")}}/api/v4',
url: '/users', url: '/users',
skipSslCertificateValidation: '={{$credentials?.allowUnauthorizedCerts}}', skipSslCertificateValidation: '={{$credentials?.allowUnauthorizedCerts}}',
}, },

3
packages/nodes-base/nodes/Mattermost/v1/transport/index.ts
View file

@ -19,12 +19,13 @@ export async function apiRequest(
query: IDataObject = {}, query: IDataObject = {},
) { ) {
const credentials = await this.getCredentials('mattermostApi'); const credentials = await this.getCredentials('mattermostApi');
const baseUrl = (credentials.baseUrl as string).replace(/\/$/, '');
const options: IHttpRequestOptions = { const options: IHttpRequestOptions = {
method, method,
body, body,
qs: query, qs: query,
url: `${credentials.baseUrl}/api/v4/${endpoint}`, url: `${baseUrl}/api/v4/${endpoint}`,
headers: { headers: {
'content-type': 'application/json; charset=utf-8', 'content-type': 'application/json; charset=utf-8',
}, },