mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(editor): Curb direct item access linting (#4591)

Browse source 
🐛 Curb direct item access linting
This commit is contained in:
Iván Ovejero 2022-11-14 11:22:55 +01:00 committed by GitHub
parent ccacd42b37
commit 271cd06a6a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
packages/editor-ui/src/components/CodeNodeEditor/linter.ts
View file

@ -412,14 +412,19 @@ export const linterExtension = (Vue as CodeNodeEditorMixin).extend({
left: { declarations: Array<{ id: { type: string; name: string } }> }; left: { declarations: Array<{ id: { type: string; name: string } }> };
}; };
const isForOfStatement = (node: Node) => const isForOfStatementOverN8nVar = (node: Node) =>
node.type === 'ForOfStatement' && node.type === 'ForOfStatement' &&
node.left.type === 'VariableDeclaration' && node.left.type === 'VariableDeclaration' &&
node.left.declarations.length === 1 && node.left.declarations.length === 1 &&
node.left.declarations[0].type === 'VariableDeclarator' && node.left.declarations[0].type === 'VariableDeclarator' &&
node.left.declarations[0].id.type === 'Identifier'; node.left.declarations[0].id.type === 'Identifier' &&
node.right.type === 'CallExpression' &&
node.right.callee.type === 'MemberExpression' &&
node.right.callee.computed === false &&
node.right.callee.object.type === 'Identifier' &&
node.right.callee.object.name.startsWith('$'); // n8n var, e.g $input
const found = walk<TargetNode>(ast, isForOfStatement); const found = walk<TargetNode>(ast, isForOfStatementOverN8nVar);
if (found.length === 1) { if (found.length === 1) {
const itemAlias = found[0].left.declarations[0].id.name; const itemAlias = found[0].left.declarations[0].id.name;