From 27d04062f503d8ca5c4be68942a0b00d423686f1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Iv=C3=A1n=20Ovejero?= Date: Thu, 13 Oct 2022 09:19:17 +0200 Subject: [PATCH] refactor(core): integrate lint rule `node-param-name-untrimmed` (#4331) * :arrow_up: Upgrade `eslint-plugin-n8n-nodes-base` * :package: Update `package-lock.json` * :shirt: Add `node-param-name-untrimmed` Co-authored-by: Michael Kret --- package-lock.json | 102 +++++++++++++++---------------- packages/nodes-base/.eslintrc.js | 1 + packages/nodes-base/package.json | 2 +- 3 files changed, 52 insertions(+), 53 deletions(-) diff --git a/package-lock.json b/package-lock.json index 500c44ab10..0ec3c5c4aa 100644 --- a/package-lock.json +++ b/package-lock.json @@ -17029,23 +17029,6 @@ "integrity": "sha512-qe6sVFDP1Vj5eXlqZxYZpIjwYvhuqXlI0P8OfPyhiPOhMkFtr0TpFphD8/6WCzkm7LJCvG1eJEzURCtMIsFTAg==", "dev": true }, - "node_modules/eslint-plugin-n8n-nodes-base": { - "version": "1.9.3", - "resolved": "https://registry.npmjs.org/eslint-plugin-n8n-nodes-base/-/eslint-plugin-n8n-nodes-base-1.9.3.tgz", - "integrity": "sha512-HcHTgcTuIudZE9vuTqjZkoG5GG7xn6wydL+ckqKpH7QkIK6p8wwDv/vL2SaDaRjT0vgO4/vzeUnCTQ/DQ2eZQg==", - "dev": true, - "dependencies": { - "@typescript-eslint/utils": "^5.17.0", - "camel-case": "^4.1.2", - "eslint-plugin-n8n-nodes-base": "^1.9.1", - "indefinite": "^2.4.1", - "pascal-case": "^3.1.2", - "pluralize": "^8.0.0", - "prettier": "^2.7.1", - "sentence-case": "^3.0.4", - "title-case": "^3.0.3" - } - }, "node_modules/eslint-plugin-prettier": { "version": "4.2.1", "resolved": "https://registry.npmjs.org/eslint-plugin-prettier/-/eslint-plugin-prettier-4.2.1.tgz", @@ -39610,7 +39593,6 @@ "version": "4.8.4", "resolved": "https://registry.npmjs.org/typescript/-/typescript-4.8.4.tgz", "integrity": "sha512-QCh+85mCy+h0IGff8r5XWzOVSbBO+KfeYrMQh7NJ58QujwcE22u+NUSmUxqF+un70P9GXKxa2HCNiTTMJknyjQ==", - "dev": true, "bin": { "tsc": "bin/tsc", "tsserver": "bin/tsserver" @@ -46277,7 +46259,7 @@ "@types/tmp": "^0.2.0", "@types/uuid": "^8.3.2", "@types/xml2js": "^0.4.3", - "eslint-plugin-n8n-nodes-base": "^1.9.3", + "eslint-plugin-n8n-nodes-base": "^1.10.0", "gulp": "^4.0.0", "jest": "^27.4.7", "n8n-workflow": "~0.119.0", @@ -46685,6 +46667,23 @@ "url": "https://github.com/sindresorhus/emittery?sponsor=1" } }, + "packages/nodes-base/node_modules/eslint-plugin-n8n-nodes-base": { + "version": "1.10.0", + "resolved": "https://registry.npmjs.org/eslint-plugin-n8n-nodes-base/-/eslint-plugin-n8n-nodes-base-1.10.0.tgz", + "integrity": "sha512-idQlzyCnlEyX6PvP/Rl6UFRFVv9JRN5gBqbkn++jUwLB+Jg8DQmA+Fy0jvYoe06fN0AKY0asoXSDjCTZD5EimQ==", + "dev": true, + "dependencies": { + "@typescript-eslint/utils": "^5.17.0", + "camel-case": "^4.1.2", + "eslint-plugin-n8n-nodes-base": "^1.9.5", + "indefinite": "^2.4.1", + "pascal-case": "^3.1.2", + "pluralize": "^8.0.0", + "prettier": "^2.7.1", + "sentence-case": "^3.0.4", + "title-case": "^3.0.3" + } + }, "packages/nodes-base/node_modules/expect": { "version": "27.5.1", "resolved": "https://registry.npmjs.org/expect/-/expect-27.5.1.tgz", @@ -52115,7 +52114,7 @@ "@oclif/errors": "^1.3.5", "@oclif/parser": "^3.8.0", "debug": "^4.1.1", - "globby": "^11.0.1", + "globby": "^11.0.2", "is-wsl": "^2.1.1", "tslib": "^2.3.1" }, @@ -52141,10 +52140,10 @@ "clean-stack": "^3.0.1", "cli-progress": "^3.10.0", "debug": "^4.3.4", - "ejs": "^3.1.6", + "ejs": "^3.1.8", "fs-extra": "^9.1.0", "get-package-type": "^0.1.0", - "globby": "^11.1.0", + "globby": "^11.0.2", "hyperlinker": "^1.0.0", "indent-string": "^4.0.0", "is-wsl": "^2.2.0", @@ -52356,7 +52355,7 @@ "@oclif/errors": "^1.3.3", "@oclif/parser": "^3.8.0", "debug": "^4.1.1", - "globby": "^11.0.1", + "globby": "^11.0.2", "is-wsl": "^2.1.1", "tslib": "^2.0.0" } @@ -52549,7 +52548,7 @@ "@oclif/errors": "^1.3.3", "@oclif/parser": "^3.8.0", "debug": "^4.1.1", - "globby": "^11.0.1", + "globby": "^11.0.2", "is-wsl": "^2.1.1", "tslib": "^2.0.0" } @@ -53055,7 +53054,7 @@ "css-loader": "^3.6.0", "file-loader": "^6.2.0", "find-up": "^5.0.0", - "fork-ts-checker-webpack-plugin": "^4.1.6", + "fork-ts-checker-webpack-plugin": "^6.0.4", "glob": "^7.1.6", "glob-promise": "^3.4.0", "global": "^4.4.0", @@ -55577,7 +55576,7 @@ "@typescript-eslint/types": "5.38.1", "@typescript-eslint/visitor-keys": "5.38.1", "debug": "^4.3.4", - "globby": "^11.1.0", + "globby": "^11.0.2", "is-glob": "^4.0.3", "semver": "^7.3.7", "tsutils": "^3.21.0" @@ -56947,7 +56946,7 @@ "integrity": "sha512-eM9d/swFopRt5gdJ7jrpCwgvEMIayITpojhkkSMRsFHYuH5bkSQ4p/9qTEHtmNudUZh22Tehu7I6CxAW0IXTKA==", "dev": true, "requires": { - "browserslist": "^4.12.0", + "browserslist": "^4.21.3", "caniuse-lite": "^1.0.30001109", "normalize-range": "^0.1.2", "num2fraction": "^1.2.2", @@ -59772,7 +59771,7 @@ "integrity": "sha512-xVtYpJQ5grszDHEUU9O7XbjjcZ0ccX3LgQsyqSvTnjX97ZqEgn9F5srmrwwwMtbKzDllyFPL+O+2OFMl1lU4TQ==", "dev": true, "requires": { - "browserslist": "^4.21.4" + "browserslist": "^4.21.3" } }, "core-js-pure": { @@ -59846,7 +59845,7 @@ "requires": { "arrify": "^2.0.1", "cp-file": "^7.0.0", - "globby": "^9.2.0", + "globby": "^11.0.2", "has-glob": "^1.0.0", "junk": "^3.1.0", "nested-error-stacks": "^2.1.0", @@ -61450,7 +61449,7 @@ "functional-red-black-tree": "^1.0.1", "glob-parent": "^6.0.1", "globals": "^13.15.0", - "globby": "^11.1.0", + "globby": "^11.0.2", "grapheme-splitter": "^1.0.4", "ignore": "^5.2.0", "import-fresh": "^3.0.0", @@ -61756,23 +61755,6 @@ "integrity": "sha512-qe6sVFDP1Vj5eXlqZxYZpIjwYvhuqXlI0P8OfPyhiPOhMkFtr0TpFphD8/6WCzkm7LJCvG1eJEzURCtMIsFTAg==", "dev": true }, - "eslint-plugin-n8n-nodes-base": { - "version": "1.9.3", - "resolved": "https://registry.npmjs.org/eslint-plugin-n8n-nodes-base/-/eslint-plugin-n8n-nodes-base-1.9.3.tgz", - "integrity": "sha512-HcHTgcTuIudZE9vuTqjZkoG5GG7xn6wydL+ckqKpH7QkIK6p8wwDv/vL2SaDaRjT0vgO4/vzeUnCTQ/DQ2eZQg==", - "dev": true, - "requires": { - "@typescript-eslint/utils": "^5.17.0", - "camel-case": "^4.1.2", - "eslint-plugin-n8n-nodes-base": "^1.9.1", - "indefinite": "^2.4.1", - "pascal-case": "^3.1.2", - "pluralize": "^8.0.0", - "prettier": "^2.7.1", - "sentence-case": "^3.0.4", - "title-case": "^3.0.3" - } - }, "eslint-plugin-prettier": { "version": "4.2.1", "resolved": "https://registry.npmjs.org/eslint-plugin-prettier/-/eslint-plugin-prettier-4.2.1.tgz", @@ -74148,7 +74130,7 @@ "chokidar": "3.5.2", "cron": "~1.7.2", "currency-codes": "^2.1.0", - "eslint-plugin-n8n-nodes-base": "^1.9.3", + "eslint-plugin-n8n-nodes-base": "^1.10.0", "eventsource": "^2.0.2", "fast-glob": "^3.2.5", "fflate": "^0.7.0", @@ -74508,6 +74490,23 @@ "integrity": "sha512-uDfvUjVrfGJJhymx/kz6prltenw1u7WrCg1oa94zYY8xxVpLLUu045LAT0dhDZdXG58/EpPL/5kA180fQ/qudg==", "dev": true }, + "eslint-plugin-n8n-nodes-base": { + "version": "1.10.0", + "resolved": "https://registry.npmjs.org/eslint-plugin-n8n-nodes-base/-/eslint-plugin-n8n-nodes-base-1.10.0.tgz", + "integrity": "sha512-idQlzyCnlEyX6PvP/Rl6UFRFVv9JRN5gBqbkn++jUwLB+Jg8DQmA+Fy0jvYoe06fN0AKY0asoXSDjCTZD5EimQ==", + "dev": true, + "requires": { + "@typescript-eslint/utils": "^5.17.0", + "camel-case": "^4.1.2", + "eslint-plugin-n8n-nodes-base": "^1.9.5", + "indefinite": "^2.4.1", + "pascal-case": "^3.1.2", + "pluralize": "^8.0.0", + "prettier": "^2.7.1", + "sentence-case": "^3.0.4", + "title-case": "^3.0.3" + } + }, "expect": { "version": "27.5.1", "resolved": "https://registry.npmjs.org/expect/-/expect-27.5.1.tgz", @@ -78458,7 +78457,7 @@ "fs-extra": "^6.0.1", "get-stream": "^5.1.0", "glob": "^7.1.2", - "globby": "^10.0.1", + "globby": "^11.0.2", "http-call": "^5.1.2", "load-json-file": "^6.2.0", "pkg-dir": "^4.2.0", @@ -83297,8 +83296,7 @@ "typescript": { "version": "4.8.4", "resolved": "https://registry.npmjs.org/typescript/-/typescript-4.8.4.tgz", - "integrity": "sha512-QCh+85mCy+h0IGff8r5XWzOVSbBO+KfeYrMQh7NJ58QujwcE22u+NUSmUxqF+un70P9GXKxa2HCNiTTMJknyjQ==", - "dev": true + "integrity": "sha512-QCh+85mCy+h0IGff8r5XWzOVSbBO+KfeYrMQh7NJ58QujwcE22u+NUSmUxqF+un70P9GXKxa2HCNiTTMJknyjQ==" }, "uc.micro": { "version": "1.0.6", @@ -84155,7 +84153,7 @@ "consola": "^2.15.3", "dotenv": "^16.0.0", "dotenv-expand": "^8.0.2", - "ejs": "^3.1.6", + "ejs": "^3.1.8", "fast-glob": "^3.2.11", "fs-extra": "^10.0.1", "html-minifier-terser": "^6.1.0", diff --git a/packages/nodes-base/.eslintrc.js b/packages/nodes-base/.eslintrc.js index e4ef1a3eec..ca87ba2613 100644 --- a/packages/nodes-base/.eslintrc.js +++ b/packages/nodes-base/.eslintrc.js @@ -146,6 +146,7 @@ module.exports = { 'n8n-nodes-base/node-param-display-name-wrong-for-update-fields': 'error', 'n8n-nodes-base/node-param-min-value-wrong-for-limit': 'error', 'n8n-nodes-base/node-param-multi-options-type-unsorted-items': 'error', + 'n8n-nodes-base/node-param-name-untrimmed': 'error', 'n8n-nodes-base/node-param-operation-option-action-wrong-for-get-many': 'error', 'n8n-nodes-base/node-param-operation-option-description-wrong-for-get-many': 'error', 'n8n-nodes-base/node-param-operation-option-without-action': 'error', diff --git a/packages/nodes-base/package.json b/packages/nodes-base/package.json index f6564eb065..8397cb9425 100644 --- a/packages/nodes-base/package.json +++ b/packages/nodes-base/package.json @@ -747,7 +747,7 @@ "@types/tmp": "^0.2.0", "@types/uuid": "^8.3.2", "@types/xml2js": "^0.4.3", - "eslint-plugin-n8n-nodes-base": "^1.9.3", + "eslint-plugin-n8n-nodes-base": "^1.10.0", "gulp": "^4.0.0", "jest": "^27.4.7", "n8n-workflow": "~0.119.0",