mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-10 06:34:05 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(editor): Setup push connection in NodeView (no-changelog) (#7821)

Browse source
This commit is contained in:
कारतोफ्फेलस्क्रिप्ट™ 2023-11-27 12:48:48 +01:00 committed by GitHub
parent 75a5807c72
commit 2807ddcd0d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/editor-ui/src/App.vue
View file

@ -56,7 +56,6 @@ import {
useCloudPlanStore,
useSourceControlStore,
useUsageStore,
usePushConnectionStore,
} from '@/stores';
import { useHistoryHelper } from '@/composables/useHistoryHelper';
import { useRoute } from 'vue-router';
@ -93,7 +92,6 @@ export default defineComponent({
useSourceControlStore,
useCloudPlanStore,
useUsageStore,
usePushConnectionStore,
),
defaultLocale(): string {
return this.rootStore.defaultLocale;
@ -122,7 +120,6 @@ export default defineComponent({
void initializeAuthenticatedFeatures();
void runExternalHook('app.mount');
this.pushStore.pushConnect();
this.loading = false;
},
watch: {

1
packages/editor-ui/src/stores/pushConnection.store.ts
View file

@ -149,6 +149,7 @@ export const usePushConnectionStore = defineStore(STORES.PUSH, () => {
isConnectionOpen,
addEventListener,
pushConnect,
pushDisconnect,
send,
};
});

11
packages/editor-ui/src/views/NodeView.vue
View file

@ -331,6 +331,7 @@ import {
useHistoryStore,
useExternalSecretsStore,
useCollaborationStore,
usePushConnectionStore,
} from '@/stores';
import * as NodeViewUtils from '@/utils/nodeViewUtils';
import { getAccountAge, getConnectionInfo, getNodeViewTab } from '@/utils';
@ -560,6 +561,7 @@ export default defineComponent({
useHistoryStore,
useExternalSecretsStore,
useCollaborationStore,
usePushConnectionStore,
),
nativelyNumberSuffixedDefaults(): string[] {
return this.nodeTypesStore.nativelyNumberSuffixedDefaults;
@ -4674,6 +4676,11 @@ export default defineComponent({
dataPinningEventBus.off('unpin-data', this.removePinDataConnections);
nodeViewEventBus.off('saveWorkflow', this.saveCurrentWorkflowExternal);
},
beforeMount() {
if (!this.isDemo) {
this.pushStore.pushConnect();
}
},
beforeUnmount() {
// Make sure the event listeners get removed again else we
// could add up with them registered multiple times
@ -4681,6 +4688,10 @@ export default defineComponent({
document.removeEventListener('keyup', this.keyUp);
this.unregisterCustomAction('showNodeCreator');
if (!this.isDemo) {
this.pushStore.pushDisconnect();
}
this.resetWorkspace();
this.instance.unbind();
this.instance.destroy();