mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-25 04:34:06 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(editor): Fix canvas selection for touch devices that use mouse (#9036)

Browse source
This commit is contained in:
Milorad FIlipović 2024-04-03 11:15:51 +02:00 committed by कारतोफ्फेलस्क्रिप्ट™
parent 571b6135dd
commit 286fa5cd7e
2 changed files with 0 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
packages/design-system/src/composables/useDeviceSupport.test.ts
View file

@ -69,12 +69,5 @@ describe('useDeviceSupport()', () => {
const event = new KeyboardEvent('keydown', { ctrlKey: true }); const event = new KeyboardEvent('keydown', { ctrlKey: true });
expect(isCtrlKeyPressed(event)).toEqual(true); expect(isCtrlKeyPressed(event)).toEqual(true);
}); });
it('should return true for touch device on MouseEvent', () => {
Object.defineProperty(window, 'ontouchstart', { value: {} });
const { isCtrlKeyPressed } = useDeviceSupport();
const mockEvent = new MouseEvent('click');
expect(isCtrlKeyPressed(mockEvent)).toEqual(true);
});
}); });
}); });

3
packages/design-system/src/composables/useDeviceSupport.ts
View file

@ -12,9 +12,6 @@ export function useDeviceSupport() {
const controlKeyCode = ref(isMacOs.value ? 'Meta' : 'Control'); const controlKeyCode = ref(isMacOs.value ? 'Meta' : 'Control');
function isCtrlKeyPressed(e: MouseEvent | KeyboardEvent): boolean { function isCtrlKeyPressed(e: MouseEvent | KeyboardEvent): boolean {
if (isTouchDevice.value && e instanceof MouseEvent) {
return true;
}
if (isMacOs.value) { if (isMacOs.value) {
return (e as KeyboardEvent).metaKey; return (e as KeyboardEvent).metaKey;
} }