From 29364ea7026e5e2a288b1866956f01e380ff05a0 Mon Sep 17 00:00:00 2001
From: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
Date: Tue, 20 Dec 2022 14:38:41 +0100
Subject: [PATCH] fix: Prevent keyboard shortcuts in expression editor modal
 (#4984)

* fix: prevent keyboard shortcuts in expression editor modal

* support esc
---
 packages/editor-ui/src/components/ExpressionEdit.vue         | 1 +
 .../ExpressionEditorModal/ExpressionEditorModalInput.vue     | 5 ++++-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/packages/editor-ui/src/components/ExpressionEdit.vue b/packages/editor-ui/src/components/ExpressionEdit.vue
index 6983487f0e..2baf3f9900 100644
--- a/packages/editor-ui/src/components/ExpressionEdit.vue
+++ b/packages/editor-ui/src/components/ExpressionEdit.vue
@@ -47,6 +47,7 @@
 								:value="value"
 								:isReadOnly="isReadOnly"
 								@change="valueChanged"
+								@close="closeDialog"
 								ref="inputFieldExpression"
 								data-test-id="expression-modal-input"
 							/>
diff --git a/packages/editor-ui/src/components/ExpressionEditorModal/ExpressionEditorModalInput.vue b/packages/editor-ui/src/components/ExpressionEditorModal/ExpressionEditorModalInput.vue
index 6ef6ddc4dd..f89bf2e325 100644
--- a/packages/editor-ui/src/components/ExpressionEditorModal/ExpressionEditorModalInput.vue
+++ b/packages/editor-ui/src/components/ExpressionEditorModal/ExpressionEditorModalInput.vue
@@ -1,5 +1,5 @@
 <template>
-	<div ref="root" class="ph-no-capture"></div>
+	<div ref="root" class="ph-no-capture" @keydown.stop @keydown.esc="onClose"></div>
 </template>
 
 <script lang="ts">
@@ -82,6 +82,9 @@ export default mixins(expressionManager, workflowHelpers).extend({
 		this.editor?.destroy();
 	},
 	methods: {
+		onClose() {
+			this.$emit('close');
+		},
 		itemSelected({ variable }: IVariableItemSelected) {
 			if (!this.editor || this.isReadOnly) return;