mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-01-12 21:37:32 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: Remove unnecessary console message (no-changelog) (#4848)

Browse source 
* refactor: Remove unnecessary console message (no-changelog)

* fix: Broken test now passing
This commit is contained in:
Omar Ajoue 2022-12-07 12:40:38 +01:00 committed by GitHub
parent 0bd13c7173
commit 2ad62bcd44
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
packages/cli/src/events/WorkflowStatistics.ts
View file

@ -52,7 +52,6 @@ export async function workflowExecutionCompleted(
// Send the metrics // Send the metrics
await InternalHooksManager.getInstance().onFirstProductionWorkflowSuccess(metrics); await InternalHooksManager.getInstance().onFirstProductionWorkflowSuccess(metrics);
} catch (error) { } catch (error) {
console.error(error);
// Do we just assume it's a conflict error? If there is any other sort of error in the DB it should trigger here too // Do we just assume it's a conflict error? If there is any other sort of error in the DB it should trigger here too
await Db.collections.WorkflowStatistics.update( await Db.collections.WorkflowStatistics.update(
{ workflowId, name }, { workflowId, name },

3
packages/cli/test/unit/Events.test.ts
View file

@ -132,7 +132,6 @@ describe('Events', () => {
test('should not send metrics for updated entries', async () => { test('should not send metrics for updated entries', async () => {
// Call the function with the id that causes insert to fail, ensure update is called *and* metrics aren't sent // Call the function with the id that causes insert to fail, ensure update is called *and* metrics aren't sent
const mockedError = jest.spyOn(console, 'error');
const workflow = { const workflow = {
id: '-1', id: '-1',
name: '', name: '',
@ -148,9 +147,7 @@ describe('Events', () => {
mode: 'internal' as WorkflowExecuteMode, mode: 'internal' as WorkflowExecuteMode,
startedAt: new Date(), startedAt: new Date(),
}; };
mockedError.mockClear();
await workflowExecutionCompleted(workflow, runData); await workflowExecutionCompleted(workflow, runData);
expect(mockedError).toBeCalled();
expect(mockedFirstProductionWorkflowSuccess).toBeCalledTimes(0); expect(mockedFirstProductionWorkflowSuccess).toBeCalledTimes(0);
}); });
}); });